2008-06-03 Beth Dakin <bdakin@apple.com>
authorbdakin@apple.com <bdakin@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 4 Jun 2008 22:04:32 +0000 (22:04 +0000)
committerbdakin@apple.com <bdakin@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 4 Jun 2008 22:04:32 +0000 (22:04 +0000)
        Reviewed by Adele.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=19381 WebKit
        Crashing Constantly on Gmail with accessibility turned on

        There was a missing null-check!

        * page/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::roleValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebCore/ChangeLog
WebCore/page/AccessibilityRenderObject.cpp

index 5ddd19225ab3e64893f89fa5c370d30bcb8cffa7..ea88937fe020cb1bdf4c3d832c95d68e68fa8a26 100644 (file)
@@ -1,3 +1,15 @@
+2008-06-03  Beth Dakin  <bdakin@apple.com>
+
+        Reviewed by Adele.
+
+        Fix for https://bugs.webkit.org/show_bug.cgi?id=19381 WebKit 
+        Crashing Constantly on Gmail with accessibility turned on
+
+        There was a missing null-check!
+
+        * page/AccessibilityRenderObject.cpp:
+        (WebCore::AccessibilityRenderObject::roleValue):
+
 2008-06-04  Anders Carlsson  <andersca@apple.com>
 
         Reviewed by Sam.
index 021826f5e5bb7be104dd1366613e26295499db3d..d5def6d300ebfee151af8bdfb7d9daa8fe38f859 100644 (file)
@@ -1998,7 +1998,7 @@ AccessibilityRole AccessibilityRenderObject::roleValue() const
     if (headingLevel(m_renderer->element()) != 0)
         return HeadingRole;
     
-    if (m_renderer->isBlockFlow() || node->hasTagName(labelTag))
+    if (m_renderer->isBlockFlow() || (node && node->hasTagName(labelTag)))
         return GroupRole;
     
     return UnknownRole;