https://bugs.webkit.org/show_bug.cgi?id=140807
<rdar://problem/
19571601>
Reviewed by Anders Carlsson.
* UIProcess/mac/WKImmediateActionController.mm:
(-[WKImmediateActionController _clearImmediateActionState]):
Clear _hasActivatedActionContext before calling didUseActions, because
didUseActions can call _clearImmediateActionState.
* WebView/WebImmediateActionController.mm:
(-[WebImmediateActionController _clearImmediateActionState]):
Use this opportunity to bring identical code to WebKit1, to avoid
getting DataDetectors stuck when an immediate action is canceled.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@179013
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
+2015-01-23 Timothy Horton <timothy_horton@apple.com>
+
+ Infinite recursion in _clearImmediateActionState
+ https://bugs.webkit.org/show_bug.cgi?id=140807
+ <rdar://problem/19571601>
+
+ Reviewed by Anders Carlsson.
+
+ * WebView/WebImmediateActionController.mm:
+ (-[WebImmediateActionController _clearImmediateActionState]):
+ Use this opportunity to bring identical code to WebKit1, to avoid
+ getting DataDetectors stuck when an immediate action is canceled.
+
2015-01-22 Ryosuke Niwa <rniwa@webkit.org>
Add a build flag for ES6 class syntax
- (void)_clearImmediateActionState
{
[_webView _clearTextIndicator];
+ DDActionsManager *actionsManager = [getDDActionsManagerClass() sharedManager];
+ if ([actionsManager respondsToSelector:@selector(requestBubbleClosureUnanchorOnFailure:)])
+ [actionsManager requestBubbleClosureUnanchorOnFailure:YES];
+
+ if (_currentActionContext && _hasActivatedActionContext) {
+ _hasActivatedActionContext = NO;
+ [getDDActionsManagerClass() didUseActions];
+ }
_type = WebImmediateActionNone;
_currentActionContext = nil;
+2015-01-23 Timothy Horton <timothy_horton@apple.com>
+
+ Infinite recursion in _clearImmediateActionState
+ https://bugs.webkit.org/show_bug.cgi?id=140807
+ <rdar://problem/19571601>
+
+ Reviewed by Anders Carlsson.
+
+ * UIProcess/mac/WKImmediateActionController.mm:
+ (-[WKImmediateActionController _clearImmediateActionState]):
+ Clear _hasActivatedActionContext before calling didUseActions, because
+ didUseActions can call _clearImmediateActionState.
+
2015-01-23 Carlos Garcia Campos <cgarcia@igalia.com>
[GTK] Add initial database process support
_page->clearTextIndicator();
if (_currentActionContext && _hasActivatedActionContext) {
- [getDDActionsManagerClass() didUseActions];
_hasActivatedActionContext = NO;
+ [getDDActionsManagerClass() didUseActions];
}
_state = ImmediateActionState::None;