Just linking LLVM into JSC causes all plugin tests to fail

https://bugs.webkit.org/show_bug.cgi?id=113915

Tools:

Reviewed by Oliver Hunt.

Hide all LLVM symbols. This should prevent us from exporting LLVM's overrides for
raise/abort/__assert_rtn.

* Scripts/configure-llvm:

WebKitLibraries:

Reviewed by Oliver Hunt.

Updated the binary drops to r189627 of llvm.org, and used the new configure-llvm that does CPPFLAGS=-fvisibility=hidden.

* LLVMIncludesMountainLion.tar.bz2:
* LLVMLibrariesMountainLion.tar.bz2:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@154867 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/Tools/ChangeLog b/Tools/ChangeLog
index 5554156..504644b 100644 (file)
--- a/Tools/ChangeLog
+++ b/Tools/ChangeLog
@@ -1,3 +1,15 @@
+2013-08-29  Filip Pizlo  <fpizlo@apple.com>
+
+        Just linking LLVM into JSC causes all plugin tests to fail
+        https://bugs.webkit.org/show_bug.cgi?id=113915
+
+        Reviewed by Oliver Hunt.
+        
+        Hide all LLVM symbols. This should prevent us from exporting LLVM's overrides for
+        raise/abort/__assert_rtn.
+
+        * Scripts/configure-llvm:
+
 2013-08-29  Joseph Pecoraro  <pecoraro@apple.com>
 
         new-run-webkit-tests does not respect --no-sample-on-timeout switch

diff --git a/Tools/Scripts/configure-llvm b/Tools/Scripts/configure-llvm
index d764560..9db67f9 100755 (executable)
--- a/Tools/Scripts/configure-llvm
+++ b/Tools/Scripts/configure-llvm
@@ -37,4 +37,8 @@ fi
 # only want to build a backend for our current target) and to add more flags to remove
 # dependencies and features.
 
-./configure --enable-optimized=yes --enable-backtraces=no --enable-targets=x86_64 --enable-libcpp=yes --enable-zlib=no --enable-terminfo=no
+# FIXME: We need LLVM to have its own sensible story for hiding symbols. But while we
+# don't have a sensible story, we use a hilarious one: CPPFLAGS=-fvisibility=hidden
+
+./configure --enable-optimized=yes --enable-backtraces=no --enable-targets=x86_64 --enable-libcpp=yes --enable-zlib=no --enable-terminfo=no CPPFLAGS=-fvisibility=hidden
+

diff --git a/WebKitLibraries/ChangeLog b/WebKitLibraries/ChangeLog
index d919a81..3333d1c 100644 (file)
--- a/WebKitLibraries/ChangeLog
+++ b/WebKitLibraries/ChangeLog
@@ -1,3 +1,15 @@
+2013-08-29  Filip Pizlo  <fpizlo@apple.com>
+
+        Just linking LLVM into JSC causes all plugin tests to fail
+        https://bugs.webkit.org/show_bug.cgi?id=113915
+
+        Reviewed by Oliver Hunt.
+        
+        Updated the binary drops to r189627 of llvm.org, and used the new configure-llvm that does CPPFLAGS=-fvisibility=hidden.
+
+        * LLVMIncludesMountainLion.tar.bz2:
+        * LLVMLibrariesMountainLion.tar.bz2:
+
 2013-08-29  Brent Fulgham  <bfulgham@apple.com>
 
         [Windows] Unreviewed build fix after r154847.

diff --git a/WebKitLibraries/LLVMIncludesMountainLion.tar.bz2 b/WebKitLibraries/LLVMIncludesMountainLion.tar.bz2
index b3dcbb6..f246564 100644 (file)
Binary files a/WebKitLibraries/LLVMIncludesMountainLion.tar.bz2 and b/WebKitLibraries/LLVMIncludesMountainLion.tar.bz2 differ

diff --git a/WebKitLibraries/LLVMLibrariesMountainLion.tar.bz2 b/WebKitLibraries/LLVMLibrariesMountainLion.tar.bz2
index 8574517..9af3d3b 100644 (file)
Binary files a/WebKitLibraries/LLVMLibrariesMountainLion.tar.bz2 and b/WebKitLibraries/LLVMLibrariesMountainLion.tar.bz2 differ