Should turn off frame pointer omission (FPO) for Release (not Production) builds

https://bugs.webkit.org/show_bug.cgi?id=54403

Reviewed by Adam Roben.

Leave it enabled for Windows Production builds.
Disabling this optimization improves stack traces for memory and performance tools like umdh and xperf.

We use both /Oy- and OmitFramePointers="false" since OmitFramePointers="false" isnt' enough
to override /O2.

* win/tools/vsprops/release.vsprops:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebKitLibraries/ChangeLog b/WebKitLibraries/ChangeLog
index ff3ec082923e729d21cc3fff0f5605985def520d..c917b97028e026906d32091351dbea5357571278 100644 (file)
--- a/WebKitLibraries/ChangeLog
+++ b/WebKitLibraries/ChangeLog
@@ -1,3 +1,18 @@
+2011-03-30  Steve Falkenburg  <sfalken@apple.com>
+
+        Reviewed by Adam Roben.
+
+        Should turn off frame pointer omission (FPO) for Release (not Production) builds
+        https://bugs.webkit.org/show_bug.cgi?id=54403
+
+        Leave it enabled for Windows Production builds.
+        Disabling this optimization improves stack traces for memory and performance tools like umdh and xperf.
+        
+        We use both /Oy- and OmitFramePointers="false" since OmitFramePointers="false" isnt' enough
+        to override /O2.
+
+        * win/tools/vsprops/release.vsprops:
+
 2011-03-30  Steve Falkenburg  <sfalken@apple.com>
 
         Reviewed by Adam Roben.

diff --git a/WebKitLibraries/win/tools/vsprops/release.vsprops b/WebKitLibraries/win/tools/vsprops/release.vsprops
index 6a26666a406170f02ffb159feb5ac841a3426302..881de7032fb919cb804e3b7f636e5ca712bfd4e1 100644 (file)
--- a/WebKitLibraries/win/tools/vsprops/release.vsprops
+++ b/WebKitLibraries/win/tools/vsprops/release.vsprops
@@ -6,5 +6,7 @@
        >
        <Tool
                Name="VCCLCompilerTool"
+               AdditionalOptions="/Oy-"
+               OmitFramePointers="false"
        />
 </VisualStudioPropertySheet>