2007-07-21 Ada Chan <adachan@apple.com>

        Reviewed by Adam.

        Fix bug 14706: http://bugs.webkit.org/show_bug.cgi?id=14706
        Need to set the last visited time before calling WebHistory::addItem().

        * WebHistory.cpp:
        (WebHistory::addItemForURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebKit/win/ChangeLog b/WebKit/win/ChangeLog
index 47acab4a53337156dc234468487909f4ee22480c..13e905098f6a0c22bb75f2ffb3d2c5dcfd069108 100644 (file)
--- a/WebKit/win/ChangeLog
+++ b/WebKit/win/ChangeLog
@@ -1,3 +1,13 @@
+2007-07-21  Ada Chan  <adachan@apple.com>
+
+        Reviewed by Adam.
+        
+        Fix bug 14706: http://bugs.webkit.org/show_bug.cgi?id=14706
+        Need to set the last visited time before calling WebHistory::addItem().
+
+        * WebHistory.cpp:
+        (WebHistory::addItemForURL):
+
 2007-07-20  Justin Garcia  <justin.garcia@apple.com>
 
         Reviewed by Darin.

diff --git a/WebKit/win/WebHistory.cpp b/WebKit/win/WebHistory.cpp
index 0ca75b4d89597118c79dc7550e3f7386a3bdd5c1..f9d1744b8f49293032b721457aa6f9891406c2ce 100644 (file)
--- a/WebKit/win/WebHistory.cpp
+++ b/WebKit/win/WebHistory.cpp
@@ -666,11 +666,11 @@ HRESULT WebHistory::addItemForURL(BSTR url, BSTR title)
     if (FAILED(hr))
         return hr;
 
-    hr = addItem(item.get());
+    hr = item->setLastVisitedTimeInterval(lastVisited); // also increments visitedCount
     if (FAILED(hr))
         return hr;
 
-    return item->setLastVisitedTimeInterval(lastVisited); // also increments visitedCount
+    return addItem(item.get());
 }
 
 HRESULT WebHistory::itemForURLString(