git://git.webkit.org / WebKit-https.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 57a4f09)
Unreviewed, rolling out r219334.
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 9 Aug 2017 22:08:35 +0000 (22:08 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 9 Aug 2017 22:08:35 +0000 (22:08 +0000)
https://bugs.webkit.org/show_bug.cgi?id=175398

Caused bug 175023 (Requested by ap on #webkit).

Reverted changeset:

"[SVG] Leak in SVGAnimatedListPropertyTearOff"
https://bugs.webkit.org/show_bug.cgi?id=172545
http://trac.webkit.org/changeset/219334

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog patch | blob | history
LayoutTests/svg/animations/animation-leak-list-property-instances-expected.txt [deleted file] patch | blob | history
LayoutTests/svg/animations/animation-leak-list-property-instances.html [deleted file] patch | blob | history
Source/WebCore/ChangeLog patch | blob | history
Source/WebCore/svg/properties/SVGAnimatedListPropertyTearOff.h patch | blob | history

diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
index bea96c7bc6c5d0a9a44fbcb8506a15ce718475a1..ec69c2674a7951340ff11083b2b314948fb918e3 100644 (file)
--- a/LayoutTests/ChangeLog
+++ b/LayoutTests/ChangeLog
@@ -1,3 +1,16 @@
+2017-08-09  Commit Queue  <commit-queue@webkit.org>
+
+        Unreviewed, rolling out r219334.
+        https://bugs.webkit.org/show_bug.cgi?id=175398
+
+        Caused bug 175023 (Requested by ap on #webkit).
+
+        Reverted changeset:
+
+        "[SVG] Leak in SVGAnimatedListPropertyTearOff"
+        https://bugs.webkit.org/show_bug.cgi?id=172545
+        http://trac.webkit.org/changeset/219334
+
 2017-08-09  Daniel Bates  <dabates@apple.com>
 
         Import CSS-UI-3 Web Platform Tests
diff --git a/LayoutTests/svg/animations/animation-leak-list-property-instances-expected.txt b/LayoutTests/svg/animations/animation-leak-list-property-instances-expected.txt
deleted file mode 100644 (file)
index cfca71e..0000000
--- a/LayoutTests/svg/animations/animation-leak-list-property-instances-expected.txt
+++ /dev/null
@@ -1,7 +0,0 @@
-This test checks that adding an animation to a SVG element does not leak the whole SVGDocument.
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-PASS 0 is 0
-
diff --git a/LayoutTests/svg/animations/animation-leak-list-property-instances.html b/LayoutTests/svg/animations/animation-leak-list-property-instances.html
deleted file mode 100644 (file)
index d55e6fd..0000000
--- a/LayoutTests/svg/animations/animation-leak-list-property-instances.html
+++ /dev/null
@@ -1,63 +0,0 @@
-<!DOCTYPE html>
-<script src="../../resources/js-test-pre.js"></script>
-
-<body onload="test()">
-    <svg id="rootSVG" width="300" height="300" xmlns="http://www.w3.org/2000/svg" version="1.1"></svg>
-</body>
-
-<script>
- description("This test checks that adding an animation to a SVG element does not leak the whole SVGDocument.")
-
- function addRect()
- {
-     var elem = document.createElementNS("http://www.w3.org/2000/svg", "rect");
-     elem.setAttribute("id", "rect");
-     elem.setAttribute("x", 50);
-     elem.setAttribute("y", 50);
-     elem.setAttribute("width", 50);
-     elem.setAttribute("height", 50);
-     elem.setAttribute("fill", "blue");
-
-     document.getElementById("rootSVG").appendChild(elem);
- }
-
- function applyTransform()
- {
-     var svgroot = document.getElementById("rootSVG");
-     var transformList = document.getElementById("rect").transform.baseVal;
-     var rotate = svgroot.createSVGTransform();
-     rotate.setRotate(15,0,0);
-     transformList.appendItem(rotate);
- }
-
- function removeRect()
- {
-     document.getElementById("rootSVG").removeChild(document.getElementById("rect"));
- }
-
- function test()
- {
-     if (!window.internals || !window.GCController) {
-        testFailed("This test requires internals and GCController");
-        return;
-     }
-
-     testRunner.dumpAsText();
-
-     // One gc() call is not enough and cause flakiness in some platforms.
-     gc();
-     gc();
-     var originalLiveElements = internals.numberOfLiveNodes();
-
-     addRect();
-     applyTransform();
-     removeRect();
-
-     // One gc() call is not enough and cause flakiness in some platforms.
-     gc();
-     gc();
-     var delta = internals.numberOfLiveNodes() - originalLiveElements;
-     shouldBeZero(delta.toString());
-     var successfullyParsed = true;
- }
-</script>
diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
index aff53c2466e70e418640e55af4f2669fce67979b..a1b282a061dbb3fc26f86d7294d25acfc50b4e72 100644 (file)
--- a/Source/WebCore/ChangeLog
+++ b/Source/WebCore/ChangeLog
@@ -1,3 +1,16 @@
+2017-08-09  Commit Queue  <commit-queue@webkit.org>
+
+        Unreviewed, rolling out r219334.
+        https://bugs.webkit.org/show_bug.cgi?id=175398
+
+        Caused bug 175023 (Requested by ap on #webkit).
+
+        Reverted changeset:
+
+        "[SVG] Leak in SVGAnimatedListPropertyTearOff"
+        https://bugs.webkit.org/show_bug.cgi?id=172545
+        http://trac.webkit.org/changeset/219334
+
 2017-08-09  Dave Hyatt  <hyatt@apple.com>
 
         [Repaint from Layout Removal] Move layer repaint rects into a map
diff --git a/Source/WebCore/svg/properties/SVGAnimatedListPropertyTearOff.h b/Source/WebCore/svg/properties/SVGAnimatedListPropertyTearOff.h
index bfa8e1356fb6bd2c8a0965ce0f5e9d1e21784bef..0ce9937931d7619804f1f34759cb9017d0591e0d 100644 (file)
--- a/Source/WebCore/svg/properties/SVGAnimatedListPropertyTearOff.h
+++ b/Source/WebCore/svg/properties/SVGAnimatedListPropertyTearOff.h
@@ -73,8 +73,6 @@ public:
             m_baseVal = nullptr;
         else if (&property == m_animVal)
             m_animVal = nullptr;
-        if (!m_baseVal && !m_animVal)
-            detachListWrappers(m_values.size());
     }
 
     int findItem(SVGProperty* property)
Mirror of the WebKit open source project from svn.webkit.org.