+2006-10-05 Adele Peterson <adele@apple.com>
+
+ Reviewed by the letter 'B'.
+
+ More build fixes.
+
+ * WebKit.xcodeproj/project.pbxproj:
+ * WebView/WebDynamicScrollBarsView.h:
+ * WebView/WebDynamicScrollBarsView.m:
+ (-[WebDynamicScrollBarsView updateScrollers]):
+ (-[WebDynamicScrollBarsView setAllowsScrolling:]):
+ (-[WebDynamicScrollBarsView allowsScrolling]):
+ (-[WebDynamicScrollBarsView setAllowsHorizontalScrolling:]):
+ (-[WebDynamicScrollBarsView setAllowsVerticalScrolling:]):
+ (-[WebDynamicScrollBarsView allowsHorizontalScrolling]):
+ (-[WebDynamicScrollBarsView allowsVerticalScrolling]):
+ (-[WebDynamicScrollBarsView horizontalScrollingMode]):
+ (-[WebDynamicScrollBarsView verticalScrollingMode]):
+ (-[WebDynamicScrollBarsView setHorizontalScrollingMode:]):
+ (-[WebDynamicScrollBarsView setVerticalScrollingMode:]):
+ (-[WebDynamicScrollBarsView setScrollingMode:]):
+ * WebView/WebView.m:
+ (-[WebView setAlwaysShowVerticalScroller:]):
+ (-[WebView alwaysShowVerticalScroller]):
+ (-[WebView setAlwaysShowHorizontalScroller:]):
+ (-[WebView alwaysShowHorizontalScroller]):
+
2006-10-05 Vladimir Olexa <vladimir.olexa@gmail.com>
Reviewed by Timothy.
BOOL scrollsHorizontally;
if (!suppressLayout && !suppressScrollers &&
- (hScroll == WebCoreScrollBarAuto || vScroll == WebCoreScrollBarAuto))
+ (hScroll == WebCoreScrollbarAuto || vScroll == WebCoreScrollbarAuto))
{
// Do a layout if pending, before checking if scrollbars are needed.
// This fixes 2969367, although may introduce a slowdown in live resize performance.
NSSize documentSize = [documentView frame].size;
NSSize frameSize = [self frame].size;
- scrollsVertically = (vScroll == WebCoreScrollBarAlwaysOn) ||
- (vScroll == WebCoreScrollBarAuto && documentSize.height > frameSize.height);
+ scrollsVertically = (vScroll == WebCoreScrollbarAlwaysOn) ||
+ (vScroll == WebCoreScrollbarAuto && documentSize.height > frameSize.height);
if (scrollsVertically)
- scrollsHorizontally = (hScroll == WebCoreScrollBarAlwaysOn) ||
- (hScroll == WebCoreScrollBarAuto && documentSize.width + [NSScroller scrollerWidth] > frameSize.width);
+ scrollsHorizontally = (hScroll == WebCoreScrollbarAlwaysOn) ||
+ (hScroll == WebCoreScrollbarAuto && documentSize.width + [NSScroller scrollerWidth] > frameSize.width);
else {
- scrollsHorizontally = (hScroll == WebCoreScrollBarAlwaysOn) ||
- (hScroll == WebCoreScrollBarAuto && documentSize.width > frameSize.width);
+ scrollsHorizontally = (hScroll == WebCoreScrollbarAlwaysOn) ||
+ (hScroll == WebCoreScrollbarAuto && documentSize.width > frameSize.width);
if (scrollsHorizontally)
- scrollsVertically = (vScroll == WebCoreScrollBarAlwaysOn) ||
- (vScroll == WebCoreScrollBarAuto && documentSize.height + [NSScroller scrollerWidth] > frameSize.height);
+ scrollsVertically = (vScroll == WebCoreScrollbarAlwaysOn) ||
+ (vScroll == WebCoreScrollbarAuto && documentSize.height + [NSScroller scrollerWidth] > frameSize.height);
}
}
else {
- scrollsHorizontally = (hScroll == WebCoreScrollBarAuto) ? hasHorizontalScroller : (hScroll == WebCoreScrollBarAlwaysOn);
- scrollsVertically = (vScroll == WebCoreScrollBarAuto) ? hasVerticalScroller : (vScroll == WebCoreScrollBarAlwaysOn);
+ scrollsHorizontally = (hScroll == WebCoreScrollbarAuto) ? hasHorizontalScroller : (hScroll == WebCoreScrollbarAlwaysOn);
+ scrollsVertically = (vScroll == WebCoreScrollbarAuto) ? hasVerticalScroller : (vScroll == WebCoreScrollbarAlwaysOn);
}
if (hasVerticalScroller != scrollsVertically) {
if (hScrollModeLocked && vScrollModeLocked)
return;
- if (flag && vScroll == WebCoreScrollBarAlwaysOff)
- vScroll = WebCoreScrollBarAuto;
- else if (!flag && vScroll != WebCoreScrollBarAlwaysOff)
- vScroll = WebCoreScrollBarAlwaysOff;
+ if (flag && vScroll == WebCoreScrollbarAlwaysOff)
+ vScroll = WebCoreScrollbarAuto;
+ else if (!flag && vScroll != WebCoreScrollbarAlwaysOff)
+ vScroll = WebCoreScrollbarAlwaysOff;
- if (flag && hScroll == WebCoreScrollBarAlwaysOff)
- hScroll = WebCoreScrollBarAuto;
- else if (!flag && hScroll != WebCoreScrollBarAlwaysOff)
- hScroll = WebCoreScrollBarAlwaysOff;
+ if (flag && hScroll == WebCoreScrollbarAlwaysOff)
+ hScroll = WebCoreScrollbarAuto;
+ else if (!flag && hScroll != WebCoreScrollbarAlwaysOff)
+ hScroll = WebCoreScrollbarAlwaysOff;
[self updateScrollers];
}
- (BOOL)allowsScrolling
{
// Returns YES if either horizontal or vertical scrolling is allowed.
- return hScroll != WebCoreScrollBarAlwaysOff || vScroll != WebCoreScrollBarAlwaysOff;
+ return hScroll != WebCoreScrollbarAlwaysOff || vScroll != WebCoreScrollbarAlwaysOff;
}
- (void)setAllowsHorizontalScrolling:(BOOL)flag
{
if (hScrollModeLocked)
return;
- if (flag && hScroll == WebCoreScrollBarAlwaysOff)
- hScroll = WebCoreScrollBarAuto;
- else if (!flag && hScroll != WebCoreScrollBarAlwaysOff)
- hScroll = WebCoreScrollBarAlwaysOff;
+ if (flag && hScroll == WebCoreScrollbarAlwaysOff)
+ hScroll = WebCoreScrollbarAuto;
+ else if (!flag && hScroll != WebCoreScrollbarAlwaysOff)
+ hScroll = WebCoreScrollbarAlwaysOff;
[self updateScrollers];
}
{
if (vScrollModeLocked)
return;
- if (flag && vScroll == WebCoreScrollBarAlwaysOff)
- vScroll = WebCoreScrollBarAuto;
- else if (!flag && vScroll != WebCoreScrollBarAlwaysOff)
- vScroll = WebCoreScrollBarAlwaysOff;
+ if (flag && vScroll == WebCoreScrollbarAlwaysOff)
+ vScroll = WebCoreScrollbarAuto;
+ else if (!flag && vScroll != WebCoreScrollbarAlwaysOff)
+ vScroll = WebCoreScrollbarAlwaysOff;
[self updateScrollers];
}
- (BOOL)allowsHorizontalScrolling
{
- return hScroll != WebCoreScrollBarAlwaysOff;
+ return hScroll != WebCoreScrollbarAlwaysOff;
}
- (BOOL)allowsVerticalScrolling
{
- return vScroll != WebCoreScrollBarAlwaysOff;
+ return vScroll != WebCoreScrollbarAlwaysOff;
}
--(WebCoreScrollBarMode)horizontalScrollingMode
+-(WebCoreScrollbarMode)horizontalScrollingMode
{
return hScroll;
}
--(WebCoreScrollBarMode)verticalScrollingMode
+-(WebCoreScrollbarMode)verticalScrollingMode
{
return vScroll;
}
-- (void)setHorizontalScrollingMode:(WebCoreScrollBarMode)mode
+- (void)setHorizontalScrollingMode:(WebCoreScrollbarMode)mode
{
if (mode == hScroll || hScrollModeLocked)
return;
[self updateScrollers];
}
-- (void)setVerticalScrollingMode:(WebCoreScrollBarMode)mode
+- (void)setVerticalScrollingMode:(WebCoreScrollbarMode)mode
{
if (mode == vScroll || vScrollModeLocked)
return;
[self updateScrollers];
}
-- (void)setScrollingMode:(WebCoreScrollBarMode)mode
+- (void)setScrollingMode:(WebCoreScrollbarMode)mode
{
if ((mode == vScroll && mode == hScroll) || (vScrollModeLocked && hScrollModeLocked))
return;
{
WebDynamicScrollBarsView *scrollview = (WebDynamicScrollBarsView *)[[[self mainFrame] frameView] _scrollView];
if (flag) {
- [scrollview setVerticalScrollingMode:WebCoreScrollBarAlwaysOn];
+ [scrollview setVerticalScrollingMode:WebCoreScrollbarAlwaysOn];
[scrollview setVerticalScrollingModeLocked:YES];
} else {
[scrollview setVerticalScrollingModeLocked:NO];
- [scrollview setVerticalScrollingMode:WebCoreScrollBarAuto];
+ [scrollview setVerticalScrollingMode:WebCoreScrollbarAuto];
}
}
- (BOOL)alwaysShowVerticalScroller
{
WebDynamicScrollBarsView *scrollview = (WebDynamicScrollBarsView *)[[[self mainFrame] frameView] _scrollView];
- return [scrollview verticalScrollingModeLocked] && [scrollview verticalScrollingMode] == WebCoreScrollBarAlwaysOn;
+ return [scrollview verticalScrollingModeLocked] && [scrollview verticalScrollingMode] == WebCoreScrollbarAlwaysOn;
}
- (void)setAlwaysShowHorizontalScroller:(BOOL)flag
{
WebDynamicScrollBarsView *scrollview = (WebDynamicScrollBarsView *)[[[self mainFrame] frameView] _scrollView];
if (flag) {
- [scrollview setHorizontalScrollingMode:WebCoreScrollBarAlwaysOn];
+ [scrollview setHorizontalScrollingMode:WebCoreScrollbarAlwaysOn];
[scrollview setHorizontalScrollingModeLocked:YES];
} else {
[scrollview setHorizontalScrollingModeLocked:NO];
- [scrollview setHorizontalScrollingMode:WebCoreScrollBarAuto];
+ [scrollview setHorizontalScrollingMode:WebCoreScrollbarAuto];
}
}
- (BOOL)alwaysShowHorizontalScroller
{
WebDynamicScrollBarsView *scrollview = (WebDynamicScrollBarsView *)[[[self mainFrame] frameView] _scrollView];
- return [scrollview horizontalScrollingModeLocked] && [scrollview horizontalScrollingMode] == WebCoreScrollBarAlwaysOn;
+ return [scrollview horizontalScrollingModeLocked] && [scrollview horizontalScrollingMode] == WebCoreScrollbarAlwaysOn;
}
- (void)_setInViewSourceMode:(BOOL)flag