Reviewed by John.

        - fixed <rdar://problem/3971372> SWB: template function DOM_cast() won't compile with gcc 4.0
        - fixed other gcc 4.0 compiling problems Patrick Beard pointed out on the phone

        * kwq/DOMInternal.h: (DOM_cast): Change the "failToCompile()" trick to use a dependent name.
        Nowadays, if a name is not dependent, it is checked at template definition time. But we want
        a failure only at template instantiation time.

        * ForwardingHeaders/editing/text_granularity.h: Added. Needed but a bug in the 3.3 compiler made
        it compile anyway without this.

        - other changes

        * khtml/html/html_miscimpl.h: For clarity, mark these functions virtual too. They are automatically
        virtual because the base class ones are virtual, but it's ugly to leave it this way.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebCore/ChangeLog-2005-08-23 b/WebCore/ChangeLog-2005-08-23
index 4cc4d508005ff5617ac28946eb65060c7ec3e8a5..814e7f9c616f54032c380009342da5c3483ed22f 100644 (file)
--- a/WebCore/ChangeLog-2005-08-23
+++ b/WebCore/ChangeLog-2005-08-23
@@ -1,3 +1,22 @@
+2005-01-27  Darin Adler  <darin@apple.com>
+
+        Reviewed by John.
+
+        - fixed <rdar://problem/3971372> SWB: template function DOM_cast() won't compile with gcc 4.0
+        - fixed other gcc 4.0 compiling problems Patrick Beard pointed out on the phone
+
+        * kwq/DOMInternal.h: (DOM_cast): Change the "failToCompile()" trick to use a dependent name.
+        Nowadays, if a name is not dependent, it is checked at template definition time. But we want
+        a failure only at template instantiation time.
+
+        * ForwardingHeaders/editing/text_granularity.h: Added. Needed but a bug in the 3.3 compiler made
+        it compile anyway without this.
+
+        - other changes
+
+        * khtml/html/html_miscimpl.h: For clarity, mark these functions virtual too. They are automatically
+        virtual because the base class ones are virtual, but it's ugly to leave it this way.
+
 2005-01-26  Ken Kocienda  <kocienda@apple.com>
 
         Reviewed by Hyatt

diff --git a/WebCore/ForwardingHeaders/editing/text_granularity.h b/WebCore/ForwardingHeaders/editing/text_granularity.h
new file mode 100644 (file)
index 0000000..51a7159
--- /dev/null
+++ b/WebCore/ForwardingHeaders/editing/text_granularity.h
@@ -0,0 +1 @@
+#import <text_granularity.h>

diff --git a/WebCore/khtml/html/html_miscimpl.h b/WebCore/khtml/html/html_miscimpl.h
index 13ea8aaf9373c0296cc2f855ba78c9def9975b3b..6cafc538115d79955c88d3179bb0c9290212ac4c 100644 (file)
--- a/WebCore/khtml/html/html_miscimpl.h
+++ b/WebCore/khtml/html/html_miscimpl.h
@@ -135,8 +135,8 @@ public:
     virtual NodeImpl *firstItem() const;
     virtual NodeImpl *nextItem() const;
 
-    NodeImpl *namedItem ( const DOMString &name, bool caseSensitive = true ) const;
-    NodeImpl *nextNamedItem( const DOMString &name ) const;
+    virtual NodeImpl *namedItem ( const DOMString &name, bool caseSensitive = true ) const;
+    virtual NodeImpl *nextNamedItem( const DOMString &name ) const;
 
 protected:
     virtual void updateNameCache() const;

diff --git a/WebCore/kwq/DOMInternal.h b/WebCore/kwq/DOMInternal.h
index 25fcb6b4dd1365831232df891110efee2fb233af..5514f5aada5a1775067006674cdf426617a6f250 100644 (file)
--- a/WebCore/kwq/DOMInternal.h
+++ b/WebCore/kwq/DOMInternal.h
@@ -102,7 +102,7 @@ namespace DOM {
 // Helper functions for DOM wrappers and gluing to Objective-C
 
 // Like reinterpret_cast, but a compiler error if you use it on the wrong type.
-template <class Target, class Source> Target DOM_cast(Source) { failToCompile(); }
+template <class Target, class Source> Target DOM_cast(Source) { Source::failToCompile(); }
 
 // Type safe DOM wrapper access.