WebInspector: View throughs the exception when a child view are removed by removeChil...
authorloislo@chromium.org <loislo@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 27 Oct 2011 11:50:53 +0000 (11:50 +0000)
committerloislo@chromium.org <loislo@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 27 Oct 2011 11:50:53 +0000 (11:50 +0000)
https://bugs.webkit.org/show_bug.cgi?id=71002

Another followup fix after r98225.

Reviewed by Pavel Feldman.

* inspector/front-end/DatabaseTableView.js:
(WebInspector.DatabaseTableView.prototype._queryFinished):
(WebInspector.DatabaseTableView.prototype._queryError):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/inspector/front-end/DatabaseTableView.js

index 8793036998b885ce58327d79b215a3fe6154ea2f..8d492adeaf555e3a5fa1cc5e53a846368598d8a8 100644 (file)
@@ -1,3 +1,16 @@
+2011-10-27  Ilya Tikhonovsky  <loislo@chromium.org>
+
+        WebInspector: View throughs the exception when a child view are removed by removeChildren call.
+        https://bugs.webkit.org/show_bug.cgi?id=71002
+
+        Another followup fix after r98225.
+
+        Reviewed by Pavel Feldman.
+
+        * inspector/front-end/DatabaseTableView.js:
+        (WebInspector.DatabaseTableView.prototype._queryFinished):
+        (WebInspector.DatabaseTableView.prototype._queryError):
+
 2011-10-27  Vsevolod Vlasov  <vsevik@chromium.org>
 
         Web Inspector: Execution line in selected call frame should keep showing after toggling format source.
 2011-10-27  Vsevolod Vlasov  <vsevik@chromium.org>
 
         Web Inspector: Execution line in selected call frame should keep showing after toggling format source.
index f4346d20bc54bc993105990a5281422d3d360f49..c7b87a20d235cefac7baa20b0c4045e80acc1604 100644 (file)
@@ -60,6 +60,7 @@ WebInspector.DatabaseTableView.prototype = {
     _queryFinished: function(columnNames, values)
     {
         this.detachChildViews();
     _queryFinished: function(columnNames, values)
     {
         this.detachChildViews();
+        this.element.removeChildren();
 
         var dataGrid = WebInspector.DataGrid.createSortableDataGrid(columnNames, values);
         if (!dataGrid) {
 
         var dataGrid = WebInspector.DataGrid.createSortableDataGrid(columnNames, values);
         if (!dataGrid) {
@@ -73,6 +74,7 @@ WebInspector.DatabaseTableView.prototype = {
 
     _queryError: function(error)
     {
 
     _queryError: function(error)
     {
+        this.detachChildViews();
         this.element.removeChildren();
 
         var errorMsgElement = document.createElement("div");
         this.element.removeChildren();
 
         var errorMsgElement = document.createElement("div");