2009-11-27 Adam Barth <abarth@webkit.org>

        Reviewed by Eric Seidel.

        [bzt] unit test ApplyPatches and ApplyAttachment
        https://bugs.webkit.org/show_bug.cgi?id=31935

        * Scripts/modules/commands/download.py:
        * Scripts/modules/commands/download_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebKitTools/ChangeLog b/WebKitTools/ChangeLog
index ce5e4022182e3956b0258c8813f2e49e48bccc5a..c92e3519891b93d5b190c486cbb56418fe3c5750 100644 (file)
--- a/WebKitTools/ChangeLog
+++ b/WebKitTools/ChangeLog
@@ -1,3 +1,13 @@
+2009-11-27  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Eric Seidel.
+
+        [bzt] unit test ApplyPatches and ApplyAttachment
+        https://bugs.webkit.org/show_bug.cgi?id=31935
+
+        * Scripts/modules/commands/download.py:
+        * Scripts/modules/commands/download_unittest.py:
+
 2009-11-27  Adam Barth  <abarth@webkit.org>
 
         Reviewed by Eric Seidel.

diff --git a/WebKitTools/Scripts/modules/commands/download.py b/WebKitTools/Scripts/modules/commands/download.py
index 365b4079a2b4a399d8b302650cc2709ad1a4cfd7..31af13387fea786f62891334ae8a3ae229de1cc3 100644 (file)
--- a/WebKitTools/Scripts/modules/commands/download.py
+++ b/WebKitTools/Scripts/modules/commands/download.py
@@ -79,7 +79,6 @@ class Build(Command):
         sequence.run_and_handle_errors()
 
 
-# FIXME: Requires unit test. Blocking issue: WebKitApplyingScripts
 class ApplyAttachment(Command):
     name = "apply-attachment"
     show_in_main_help = True
@@ -95,7 +94,6 @@ class ApplyAttachment(Command):
         WebKitApplyingScripts.apply_patches_with_options(tool.scm(), [attachment], options)
 
 
-# FIXME: Requires unit test. Blocking issue: WebKitApplyingScripts
 class ApplyPatches(Command):
     name = "apply-patches"
     show_in_main_help = True

diff --git a/WebKitTools/Scripts/modules/commands/download_unittest.py b/WebKitTools/Scripts/modules/commands/download_unittest.py
index d0fff6e78a25a2bb3c898bce8f88b9076374b9d6..a1ed41a5b3b4d800ff1897ddd4aa19671381bc00 100644 (file)
--- a/WebKitTools/Scripts/modules/commands/download_unittest.py
+++ b/WebKitTools/Scripts/modules/commands/download_unittest.py
@@ -49,6 +49,18 @@ class DownloadCommandsTest(CommandsTest):
     def test_build(self):
         self.assert_execute_outputs(Build(), [], options=self._default_options())
 
+    def test_apply_attachment(self):
+        options = self._default_options()
+        options.update = True
+        options.local_commit = True
+        self.assert_execute_outputs(ApplyAttachment(), [197], options=options)
+
+    def test_apply_patches(self):
+        options = self._default_options()
+        options.update = True
+        options.local_commit = True
+        self.assert_execute_outputs(ApplyPatches(), [42], options=options)
+
     def test_land_diff(self):
         self.assert_execute_outputs(LandDiff(), [42], options=self._default_options())