Reviewed by Adam Roben.
Fix for <rdar://problem/
5382579>
http/tests/security/cross-frame-access-put.html reports large
negative numbers for screenLeft and screenTop (Mac reports "0")
* DumpRenderTree/win/UIDelegate.cpp:
(UIDelegate::UIDelegate): Initialize the RECT.
(UIDelegate::setFrame): copy the contents of the rect, not the pointer.
(UIDelegate::webViewFrame): ditto.
* DumpRenderTree/win/UIDelegate.h: Use a RECT not a RECT*
LayoutTests:
Reviewed by Adam Roben.
Fix for <rdar://problem/
5382579>
http/tests/security/cross-frame-access-put.html reports large
negative numbers for screenLeft and screenTop (Mac reports "0")
* platform/win/Skipped: remove http/tests/security/cross-frame-access-put.html
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27771
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
+2007-11-13 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Adam Roben.
+
+ Fix for <rdar://problem/5382579>
+ http/tests/security/cross-frame-access-put.html reports large
+ negative numbers for screenLeft and screenTop (Mac reports "0")
+
+ * platform/win/Skipped: remove http/tests/security/cross-frame-access-put.html
+
2007-11-13 Anders Carlsson <andersca@apple.com>
Reviewed by Adam.
http/tests/security/cross-frame-access-protocol-explicit-domain.html
http/tests/security/cross-frame-access-protocol.html
-# Reports large negative numbers for screenLeft and screenTop <rdar://problem/5382579>
-http/tests/security/cross-frame-access-put.html
-
# <rdar://problem/5463489> A number of layout tests use textInputController for operations that should be crossplatform
editing/deleting/5300379.html
editing/deleting/delete-to-end-of-paragraph.html
+2007-11-13 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Adam Roben.
+
+ Fix for <rdar://problem/5382579>
+ http/tests/security/cross-frame-access-put.html reports large
+ negative numbers for screenLeft and screenTop (Mac reports "0")
+
+ * DumpRenderTree/win/UIDelegate.cpp:
+ (UIDelegate::UIDelegate): Initialize the RECT.
+ (UIDelegate::setFrame): copy the contents of the rect, not the pointer.
+ (UIDelegate::webViewFrame): ditto.
+ * DumpRenderTree/win/UIDelegate.h: Use a RECT not a RECT*
+
2007-11-13 Kevin McCullough <kmccullough@apple.com>
Reviewed by Adam.
#include <WebKit/IWebViewPrivate.h>
#include <stdio.h>
+UIDelegate::UIDelegate()
+ : m_refCount(1)
+{
+ m_frame.bottom = 0;
+ m_frame.top = 0;
+ m_frame.left = 0;
+ m_frame.right = 0;
+}
+
HRESULT STDMETHODCALLTYPE UIDelegate::QueryInterface(REFIID riid, void** ppvObject)
{
*ppvObject = 0;
/* [in] */ IWebView* /*sender*/,
/* [in] */ RECT* frame)
{
- m_frame = frame;
+ m_frame = *frame;
return S_OK;
}
/* [in] */ IWebView* /*sender*/,
/* [retval][out] */ RECT* frame)
{
- frame = m_frame;
+ *frame = m_frame;
return S_OK;
}
#include <WebKit/IWebUIDelegate.h>
#include <WebKit/IWebUIDelegatePrivate.h>
+#include <windef.h>
class UIDelegate : public IWebUIDelegate, IWebUIDelegatePrivate {
public:
- UIDelegate() : m_refCount(1), m_frame(0) { }
+ UIDelegate();
void processWork();
ULONG m_refCount;
private:
- RECT* m_frame;
+ RECT m_frame;
};
#endif