Search fields render placeholder text improperly.

https://bugs.webkit.org/show_bug.cgi?id=147192
<rdar://problem/21901076>

Reviewed by Alexey Proskuryakov.

Due to changes in the way AppKit renders search inputs, we must now explicitly
set the placeholder text of a search input rendered using the Mac theme to be
an empty string when rendering the search input box (not including the actual
placeholder text).

* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::setSearchCellState): Force the placeholder text of
    the NSSearchFieldCell for the Mac theme to be an empty string.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187170 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
index c27f765a13d36767d602029088bcf6a0313b7db2..4b453f795ae4cad497b28e9ff486439bdb359895 100644 (file)
--- a/Source/WebCore/ChangeLog
+++ b/Source/WebCore/ChangeLog
@@ -1,3 +1,20 @@
+2015-07-22  Wenson Hsieh  <wenson_hsieh@apple.com>
+
+        Search fields render placeholder text improperly.
+        https://bugs.webkit.org/show_bug.cgi?id=147192
+        <rdar://problem/21901076>
+
+        Reviewed by Alexey Proskuryakov.
+
+        Due to changes in the way AppKit renders search inputs, we must now explicitly
+        set the placeholder text of a search input rendered using the Mac theme to be
+        an empty string when rendering the search input box (not including the actual
+        placeholder text).
+
+        * rendering/RenderThemeMac.mm:
+        (WebCore::RenderThemeMac::setSearchCellState): Force the placeholder text of
+            the NSSearchFieldCell for the Mac theme to be an empty string.
+
 2015-07-22  Matthew Daiter  <mdaiter@apple.com>
 
         Need the ability to give only best source UIDs to UserMedia request

diff --git a/Source/WebCore/rendering/RenderThemeMac.mm b/Source/WebCore/rendering/RenderThemeMac.mm
index 4795ac8ad4596578af7a17d6363f601bed662697..d2af12328ce7a372a704bfaa0e85e01031539232 100644 (file)
--- a/Source/WebCore/rendering/RenderThemeMac.mm
+++ b/Source/WebCore/rendering/RenderThemeMac.mm
@@ -1631,6 +1631,7 @@ void RenderThemeMac::setSearchCellState(const RenderObject& o, const IntRect&)
 {
     NSSearchFieldCell* search = this->search();
 
+    [search setPlaceholderString:@""];
     [search setControlSize:controlSizeForFont(o.style())];
 
     // Update the various states we respond to.