WebKitTools:
authorandersca@apple.com <andersca@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 14 Nov 2007 22:30:35 +0000 (22:30 +0000)
committerandersca@apple.com <andersca@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 14 Nov 2007 22:30:35 +0000 (22:30 +0000)
        Reviewed by Adam.

        <rdar://problem/5309081>
        In DRT, "plugin.logDestroy = true" not working on Windows.

        * DumpRenderTree/win/TestNetscapePlugin/main.c:
        (NPP_Destroy):

LayoutTests:

        Reviewed by Adam.

        <rdar://problem/5309081>
        In DRT, "plugin.logDestroy = true" not working on Windows.

        Remove now succeeding test from the skipped list.

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/platform/win/Skipped
WebKitTools/ChangeLog
WebKitTools/DumpRenderTree/win/TestNetscapePlugin/main.c

index 4d6dea513d022417f3f520f9ded820cd1626ff67..e9515557d70a8aeacc079a29ec9faee362dee759 100644 (file)
@@ -1,3 +1,14 @@
+2007-11-14  Anders Carlsson  <andersca@apple.com>
+
+        Reviewed by Adam.
+
+        <rdar://problem/5309081>
+        In DRT, "plugin.logDestroy = true" not working on Windows.
+
+        Remove now succeeding test from the skipped list.
+        
+        * platform/win/Skipped:
+
 2007-11-14  Antti Koivisto  <antti@apple.com>
 
         Try to make this test less timing dependent.
index 6dbd410193de70357a997e694d2e3a49ccbc45bb..61c2c059a48bea56ab4c9072d8b6efb43b9170d9 100644 (file)
@@ -416,9 +416,6 @@ http/tests/loading
 fast/dom/frame-loading-via-document-write.html
 http/tests/security/frame-loading-via-document-write.html
 
-# <rdar://problem/5309081> "plugin.logDestroy = true" not working on Windows
-plugins/netscape-destroy-plugin-script-objects.html
-
 # Need to add functionality to DumpRenderTree to test IDN <rdar://problem/5301954>
 fast/encoding/idn-security.html
 
index 2e61228dd160d0c24b0809453ff1c4a6dd835f98..ac532b80b0edb0aa235499f4d92e5daba808e91d 100644 (file)
@@ -1,3 +1,13 @@
+2007-11-14  Anders Carlsson  <andersca@apple.com>
+
+        Reviewed by Adam.
+
+        <rdar://problem/5309081>
+        In DRT, "plugin.logDestroy = true" not working on Windows.
+        
+        * DumpRenderTree/win/TestNetscapePlugin/main.c:
+        (NPP_Destroy):
+
 2007-11-14  Eric Seidel  <eric@webkit.org>
 
         Reviewed by Sam.
index 86bc57f1777bfa6fec2541057ce1a50a305d3d73..8c542ed3c4bacec511caebb1a4b06a5a4d5e0066 100644 (file)
@@ -33,6 +33,8 @@
 
 #include "PluginObject.h"
 
+#include <stdio.h>
+
 extern "C"
 NPError __stdcall NP_Initialize(NPNetscapeFuncs* browserFuncs)
 {
@@ -95,6 +97,9 @@ NPError NPP_Destroy(NPP instance, NPSavedData **save)
         if (obj->onStreamLoad)
             free(obj->onStreamLoad);
         
+        if (obj->logDestroy)
+            printf("PLUGIN: NPP_Destroy\n");
+
         browser->releaseobject(&obj->header);
     }
     return NPERR_NO_ERROR;