Reviewed by Mark Rowe.
authoralp <alp@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 3 Nov 2007 15:52:08 +0000 (15:52 +0000)
committeralp <alp@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 3 Nov 2007 15:52:08 +0000 (15:52 +0000)
Restore correct double and triple click behaviour

We ended up ignoring GDK_2BUTTON_PRESS and GDK_3BUTTON_PRESS after
recent refactoring.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebKit/gtk/Api/webkitgtkpage.cpp
WebKit/gtk/ChangeLog

index d95a0bb93128e3dfa0a8aa88fcd047bfe445a526..94610715beee98e5d69a8af9e75983b0a12f07db 100644 (file)
@@ -98,16 +98,12 @@ static gboolean webkit_page_button_event(GtkWidget* widget, GdkEventButton* even
 {
     Frame* frame = core(getFrameFromPage(WEBKIT_PAGE(widget)));
 
 {
     Frame* frame = core(getFrameFromPage(WEBKIT_PAGE(widget)));
 
-    switch (event->type) {
-        case GDK_BUTTON_PRESS:
-            // FIXME: need to keep track of subframe focus for key events
-            gtk_widget_grab_focus(GTK_WIDGET(widget));
-            return frame->eventHandler()->handleMousePressEvent(PlatformMouseEvent(event));
-        case GDK_BUTTON_RELEASE:
-            return frame->eventHandler()->handleMouseReleaseEvent(PlatformMouseEvent(event));
-        default:
-            return FALSE;
-    }
+    if (event->type == GDK_BUTTON_RELEASE)
+        return frame->eventHandler()->handleMouseReleaseEvent(PlatformMouseEvent(event));
+
+    // FIXME: need to keep track of subframe focus for key events
+    gtk_widget_grab_focus(GTK_WIDGET(widget));
+    return frame->eventHandler()->handleMousePressEvent(PlatformMouseEvent(event));
 }
 
 static gboolean webkit_page_motion_event(GtkWidget* widget, GdkEventMotion* event)
 }
 
 static gboolean webkit_page_motion_event(GtkWidget* widget, GdkEventMotion* event)
index 9c06ac86932fb4254ac87563778df04311b2dfaf..7f66b4b49808916bedc222d6c1a0a7d045146437 100644 (file)
@@ -1,3 +1,14 @@
+2007-11-03  Alp Toker  <alp@atoker.com>
+
+        Reviewed by Mark Rowe.
+
+        Restore correct double and triple click behaviour
+
+        We ended up ignoring GDK_2BUTTON_PRESS and GDK_3BUTTON_PRESS after
+        recent refactoring.
+
+        * Api/webkitgtkpage.cpp:
+
 2007-11-03  Alp Toker  <alp@atoker.com>
 
         Reviewed by Mark Rowe.
 2007-11-03  Alp Toker  <alp@atoker.com>
 
         Reviewed by Mark Rowe.