Remove unnecessary public method DrawingAreaImpl::createGraphicsContext()
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 18 Feb 2013 05:53:12 +0000 (05:53 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 18 Feb 2013 05:53:12 +0000 (05:53 +0000)
https://bugs.webkit.org/show_bug.cgi?id=109893

Patch by Jae Hyun Park <jae.park@company100.net> on 2013-02-17
Reviewed by Anders Carlsson.

DrawingAreaImpl::createGraphicsContext() is unnecessary since
createGraphicsContext can be called directly using ShareableBitmap.

* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::display):
* WebProcess/WebPage/DrawingAreaImpl.h:
(DrawingAreaImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143146 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebKit2/ChangeLog
Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.cpp
Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.h

index 24da9020ac852fc46fb216dbb4f2a642a46b7cfe..844aea3681f8949ede88d6b19c839f258a4dfd06 100644 (file)
@@ -1,3 +1,18 @@
+2013-02-17  Jae Hyun Park  <jae.park@company100.net>
+
+        Remove unnecessary public method DrawingAreaImpl::createGraphicsContext()
+        https://bugs.webkit.org/show_bug.cgi?id=109893
+
+        Reviewed by Anders Carlsson.
+
+        DrawingAreaImpl::createGraphicsContext() is unnecessary since
+        createGraphicsContext can be called directly using ShareableBitmap.
+
+        * WebProcess/WebPage/DrawingAreaImpl.cpp:
+        (WebKit::DrawingAreaImpl::display):
+        * WebProcess/WebPage/DrawingAreaImpl.h:
+        (DrawingAreaImpl):
+
 2013-02-17  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
 
         [WK2][EFL] Remove fullscreen manager proxy as a message receiver on invalidate()
index de756b14ae3a57123579b8687ca3b2972594328d..63fd71864b99ab25666bd67887a0feadf30e6f8c 100644 (file)
@@ -652,11 +652,6 @@ static bool shouldPaintBoundsRect(const IntRect& bounds, const Vector<IntRect>&
     return wastedSpace <= wastedSpaceThreshold;
 }
 
-PassOwnPtr<GraphicsContext> DrawingAreaImpl::createGraphicsContext(ShareableBitmap* bitmap)
-{
-    return bitmap->createGraphicsContext();
-}
-
 void DrawingAreaImpl::display(UpdateInfo& updateInfo)
 {
     ASSERT(!m_isPaintingSuspended);
@@ -707,7 +702,7 @@ void DrawingAreaImpl::display(UpdateInfo& updateInfo)
     m_scrollRect = IntRect();
     m_scrollOffset = IntSize();
 
-    OwnPtr<GraphicsContext> graphicsContext = createGraphicsContext(bitmap.get());
+    OwnPtr<GraphicsContext> graphicsContext = bitmap->createGraphicsContext();
     graphicsContext->applyDeviceScaleFactor(deviceScaleFactor);
     
     updateInfo.updateRectBounds = bounds;
index 2ba999ad2ed4e5a112042c8dc5e55652d6da0266..f88410535421f4499195c79d057fce395ee80f1a 100644 (file)
@@ -101,7 +101,6 @@ private:
     void displayTimerFired();
     void display();
     void display(UpdateInfo&);
-    PassOwnPtr<WebCore::GraphicsContext> createGraphicsContext(ShareableBitmap*);
 
     uint64_t m_backingStoreStateID;