+2009-11-26 Adam Barth <abarth@webkit.org>
+
+ Reviewed by Eric Seidel.
+
+ [bzt] Kill WebKitLandingScripts
+ https://bugs.webkit.org/show_bug.cgi?id=31904
+
+ Step 2: Kill ensure_builders_are_green.
+
+ * Scripts/modules/buildsteps.py:
+ * Scripts/modules/commands/download.py:
+ * Scripts/modules/landingsequence.py:
+ * Scripts/modules/webkitlandingscripts.py:
+
2009-11-26 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
import os
+from modules.logging import error
from modules.webkitlandingscripts import WebKitLandingScripts
from modules.webkitport import WebKitPort
if fail_fast:
args.append("--exit-after-n-failures=1")
WebKitLandingScripts.run_and_throw_if_fail(args)
+
+ def ensure_builders_are_green(self, buildbot, options):
+ if not options.check_builders or buildbot.core_builders_are_green():
+ return
+ error("Builders at %s are red, please do not commit. Pass --ignore-builders to bypass this check." % (buildbot.buildbot_host))
def execute(self, options, args, tool):
bug_id = (args and args[0]) or parse_bug_id(tool.scm().create_patch())
- WebKitLandingScripts.ensure_builders_are_green(tool.buildbot, options)
+ tool.steps.ensure_builders_are_green(tool.buildbot, options)
os.chdir(tool.scm().checkout_root)
self.update_changelogs_with_reviewer(options.reviewer, bug_id, tool)
def _prepare_to_process(self, options, args, tool):
# Check the tree status first so we can fail early.
- WebKitLandingScripts.ensure_builders_are_green(tool.buildbot, options)
+ tool.steps.ensure_builders_are_green(tool.buildbot, options)
def _process_patch(self, patch, options, args, tool):
sequence = BuildAttachmentSequence(patch, options, tool)
def _prepare_to_process(self, options, args, tool):
# Check the tree status first so we can fail early.
- WebKitLandingScripts.ensure_builders_are_green(tool.buildbot, options)
+ tool.steps.ensure_builders_are_green(tool.buildbot, options)
def _process_patch(self, patch, options, args, tool):
sequence = ConditionalLandingSequence(patch, options, tool)
def build(self):
# Make sure the tree is still green after updating, before building this patch.
# The first patch ends up checking tree status twice, but that's OK.
- WebKitLandingScripts.ensure_builders_are_green(self._tool.buildbot, self._options)
+ self._tool.steps.ensure_builders_are_green(self._tool.buildbot, self._options)
WebKitLandingScripts.build_webkit(quiet=self._options.quiet, port=self._port)
def test(self):
log("Building WebKit")
cls.run_and_throw_if_fail(port.build_webkit_command(), quiet)
- @staticmethod
- def ensure_builders_are_green(buildbot, options):
- if not options.check_builders or buildbot.core_builders_are_green():
- return
- error("Builders at %s are red, please do not commit. Pass --ignore-builders to bypass this check." % (buildbot.buildbot_host))