https://bugs.webkit.org/show_bug.cgi?id=143134
Reviewed by Geoffrey Garen.
* jit/JSInterfaceJIT.h:
* jit/Repatch.cpp:
(JSC::tryCacheGetByID):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@182151
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
+2015-03-30 Per Arne Vollan <peavo@outlook.com>
+
+ Avoid using hardcoded values for JSValue::Int32Tag, if possible.
+ https://bugs.webkit.org/show_bug.cgi?id=143134
+
+ Reviewed by Geoffrey Garen.
+
+ * jit/JSInterfaceJIT.h:
+ * jit/Repatch.cpp:
+ (JSC::tryCacheGetByID):
+
2015-03-30 Filip Pizlo <fpizlo@apple.com>
REGRESSION: js/regress/inline-arguments-local-escape.html is flaky
}
#if USE(JSVALUE32_64)
- // Can't just propogate JSValue::Int32Tag as visual studio doesn't like it
- static const unsigned Int32Tag = 0xffffffff;
- COMPILE_ASSERT(Int32Tag == JSValue::Int32Tag, Int32Tag_out_of_sync);
+ static const unsigned Int32Tag = static_cast<unsigned>(JSValue::Int32Tag);
#else
static const unsigned Int32Tag = static_cast<unsigned>(TagTypeNumber >> 32);
#endif
#if USE(JSVALUE64)
stubJit.or64(AssemblyHelpers::TrustedImm64(TagTypeNumber), resultGPR);
#elif USE(JSVALUE32_64)
- stubJit.move(AssemblyHelpers::TrustedImm32(0xffffffff), resultTagGPR); // JSValue::Int32Tag
+ stubJit.move(AssemblyHelpers::TrustedImm32(JSValue::Int32Tag), resultTagGPR);
#endif
MacroAssembler::Jump success, fail;
#if USE(JSVALUE64)
stubJit.or64(AssemblyHelpers::TrustedImm64(TagTypeNumber), resultGPR);
#elif USE(JSVALUE32_64)
- stubJit.move(AssemblyHelpers::TrustedImm32(0xffffffff), resultTagGPR); // JSValue::Int32Tag
+ stubJit.move(AssemblyHelpers::TrustedImm32(JSValue::Int32Tag), resultTagGPR);
#endif
MacroAssembler::Jump success = stubJit.jump();