Web Inspector: source location in statusbar has few bugs in it
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 4 Feb 2013 09:01:20 +0000 (09:01 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 4 Feb 2013 09:01:20 +0000 (09:01 +0000)
https://bugs.webkit.org/show_bug.cgi?id=108748

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-02-04
Reviewed by Vsevolod Vlasov.

Call super method statusBarItems in SnippetJavaScriptSourceFrame class
and merge its results. Fix css styles for source location in statusbar
and rename its css class into a less confusing name.

No new test: no change in behaviour.

* inspector/front-end/SnippetJavaScriptSourceFrame.js:
(WebInspector.SnippetJavaScriptSourceFrame.prototype.statusBarItems):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame):
* inspector/front-end/inspector.css:
(.source-frame-cursor-position):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/inspector/front-end/SnippetJavaScriptSourceFrame.js
Source/WebCore/inspector/front-end/SourceFrame.js
Source/WebCore/inspector/front-end/inspector.css

index d0368cc2a6d192b75ca92dd00ce3d2aa9be25678..6f57f86e80a7a6554cfc6ebc9da7e2219835bcc4 100644 (file)
@@ -1,3 +1,23 @@
+2013-02-04  Andrey Lushnikov  <lushnikov@chromium.org>
+
+        Web Inspector: source location in statusbar has few bugs in it
+        https://bugs.webkit.org/show_bug.cgi?id=108748
+
+        Reviewed by Vsevolod Vlasov.
+
+        Call super method statusBarItems in SnippetJavaScriptSourceFrame class
+        and merge its results. Fix css styles for source location in statusbar
+        and rename its css class into a less confusing name.
+
+        No new test: no change in behaviour.
+
+        * inspector/front-end/SnippetJavaScriptSourceFrame.js:
+        (WebInspector.SnippetJavaScriptSourceFrame.prototype.statusBarItems):
+        * inspector/front-end/SourceFrame.js:
+        (WebInspector.SourceFrame):
+        * inspector/front-end/inspector.css:
+        (.source-frame-cursor-position):
+
 2013-02-04  Mike West  <mkwst@chromium.org>
 
         Cleanup: Normalize usage of ExceptionCode in ContainerNode::checkXxxChild()
index 281e7b2ed40e50ecd16b962f6387c8b9226ad0d4..2a70570db7bd8d2b37279f9348c343cf93951a06 100644 (file)
@@ -49,7 +49,7 @@ WebInspector.SnippetJavaScriptSourceFrame.prototype = {
      */
     statusBarItems: function()
     {
-        return [this._runButton.element];
+        return [this._runButton.element].concat(WebInspector.JavaScriptSourceFrame.prototype.statusBarItems.call(this));
     },
 
     _runButtonClicked: function()
index 53ecc33dd1b33d7796d9a4df7a84c5d92c1d8c94..00c53a084d66cd11aa5944bf859d76908ae3fa38 100644 (file)
@@ -63,7 +63,7 @@ WebInspector.SourceFrame = function(contentProvider)
     this.element.addEventListener("keydown", this._handleKeyDown.bind(this), false);
 
     this._sourcePositionElement = document.createElement("div");
-    this._sourcePositionElement.className = "source-frame-position";
+    this._sourcePositionElement.className = "source-frame-cursor-position";
 }
 
 /**
index b0e99a42c579537f894418c2520468c94a58cd99..ab84abe0113784898b074f557a4e15b8b633e123 100644 (file)
@@ -3054,7 +3054,11 @@ body.platform-mac .progress-bar-container progress {
     margin-top: 1px;
 }
 
-.source-frame-position {
+.source-frame-cursor-position {
     padding-left: 6px;
     padding-top: 5px;
+    display: inline-block;
+    pointer-events: auto;
+    -webkit-user-select: text;
+    font-size: 11px;
 }