Reviewed by Darin.

        Fix for <rdar://problem/5061024> REGRESSION: Returning false from onkeypress event on Input is ignored when key is Tab
        http://bugs.webkit.org/show_bug.cgi?id= 13020

        No known way to add a layout test for this.  We would need a way to know exactly how the event was consumed.

        * page/EventHandler.cpp: (WebCore::EventHandler::defaultKeyboardEventHandler):
          If the keypress event has its default behavior prevented, then we should consider the keydown event handled.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index 6e1aac1f62fcc8d386e60834c2b764f8803552c3..c5c2ff36483cca8c50cfef436871c24f4151a687 100644 (file)
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,15 @@
+2007-03-23  Adele Peterson  <adele@apple.com>
+
+        Reviewed by Darin.
+
+        Fix for <rdar://problem/5061024> REGRESSION: Returning false from onkeypress event on Input is ignored when key is Tab
+        http://bugs.webkit.org/show_bug.cgi?id= 13020
+
+        No known way to add a layout test for this.  We would need a way to know exactly how the event was consumed.
+
+        * page/EventHandler.cpp: (WebCore::EventHandler::defaultKeyboardEventHandler):
+          If the keypress event has its default behavior prevented, then we should consider the keydown event handled.
+
 2007-03-23  Justin Garcia  <justin.garcia@apple.com>
 
         Reviewed by darin

diff --git a/WebCore/page/EventHandler.cpp b/WebCore/page/EventHandler.cpp
index f034cd82cbe4acf2db5a48b2954ce9bad8ca1b48..6782173be3e41f10c8846e6bb569b83a60033700 100644 (file)
--- a/WebCore/page/EventHandler.cpp
+++ b/WebCore/page/EventHandler.cpp
@@ -1307,7 +1307,7 @@ void EventHandler::defaultKeyboardEventHandler(KeyboardEvent* event)
                 ExceptionCode ec;
                 node->dispatchEvent(keypress, ec, true);
             }
-            if (keypress->defaultHandled())
+            if (keypress->defaultHandled() || keypress->defaultPrevented())
                 event->setDefaultHandled();
         }
     } else if (event->type() == keypressEvent) {