2010-11-02 Gyuyoung Kim <gyuyoung.kim@samsung.com>
authorgyuyoung.kim@samsung.com <gyuyoung.kim@samsung.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 3 Nov 2010 06:59:14 +0000 (06:59 +0000)
committergyuyoung.kim@samsung.com <gyuyoung.kim@samsung.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 3 Nov 2010 06:59:14 +0000 (06:59 +0000)
        Unreviewed: Add myself to the list of Committers.

        * Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71215 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/fast/table/zero-colspan-crash.html
LayoutTests/storage/indexeddb/database-basics.html
LayoutTests/storage/indexeddb/objectstore-basics.html
LayoutTests/storage/indexeddb/resources/shared.js
WebCore/inspector/InspectorResourceAgent.cpp
WebKitTools/ChangeLog
WebKitTools/Scripts/webkitpy/common/config/committers.py

index be2614ce80cf0132bbd1e5a8cd3d32989610269f..04a596e51da7099193e350f0768fbe73cc22731e 100644 (file)
@@ -1,34 +1,34 @@
-<html>\r
-  <head>\r
-    <style type="text/css">\r
-        table\r
-        {\r
-            table-layout: fixed;\r
-            width: 1px;\r
-        }\r
-    </style>\r
-    <script>\r
-        if (window.layoutTestController) {\r
-            layoutTestController.dumpAsText();\r
-            layoutTestController.waitUntilDone();\r
-        }\r
-    </script>\r
-  </head>\r
-  <body onload="finish()">\r
-    This test is to ensure that we do not crash while rendering a fixed table layout.\r
-    <div id="result"><span style='color: red;'>FAIL:</span> Did not complete test</div>\r
-    <table>\r
-      <td width="1"></td>\r
-      <td colspan="65536"></td>\r
-    </table>\r
-    <script>\r
-        function finish()\r
-        {\r
-            if (window.layoutTestController)\r
-                layoutTestController.notifyDone();\r
-            document.getElementById("result").innerHTML = "<span style='color: green;'>PASS:</span> Did not crash.";\r
-        }\r
-    </script>\r
-  </body>\r
-</html>\r
-\r
+<html>
+  <head>
+    <style type="text/css">
+        table
+        {
+            table-layout: fixed;
+            width: 1px;
+        }
+    </style>
+    <script>
+        if (window.layoutTestController) {
+            layoutTestController.dumpAsText();
+            layoutTestController.waitUntilDone();
+        }
+    </script>
+  </head>
+  <body onload="finish()">
+    This test is to ensure that we do not crash while rendering a fixed table layout.
+    <div id="result"><span style='color: red;'>FAIL:</span> Did not complete test</div>
+    <table>
+      <td width="1"></td>
+      <td colspan="65536"></td>
+    </table>
+    <script>
+        function finish()
+        {
+            if (window.layoutTestController)
+                layoutTestController.notifyDone();
+            document.getElementById("result").innerHTML = "<span style='color: green;'>PASS:</span> Did not crash.";
+        }
+    </script>
+  </body>
+</html>
+
index db2d289392a8e6cbf0aa07edd713fab234ff7a28..31c887b4cf190290f5656ec1fa65810936f0c931 100644 (file)
@@ -74,8 +74,8 @@ function createObjectStore()
     shouldBeNull("db.objectStores[0]");
     shouldBeNull("db.objectStores.item(0)");
 
-    objectStore = evalAndLog('db.createObjectStore("test123")');\r
-    checkObjectStore();\r
+    objectStore = evalAndLog('db.createObjectStore("test123")');
+    checkObjectStore();
     commitAndContinue();
 }
 
@@ -85,42 +85,42 @@ function checkObjectStore()
     shouldBe("db.objectStores.length", "1");
     shouldBe("db.objectStores.contains('')", "false");
     shouldBe("db.objectStores.contains('test456')", "false");
-    shouldBe("db.objectStores.contains('test123')", "true");\r
-}\r
-\r
-function commitAndContinue()\r
-{\r
+    shouldBe("db.objectStores.contains('test123')", "true");
+}
+
+function commitAndContinue()
+{
     window.setTimeout(testSetVersionAbort, 0);
-}\r
-\r
-function testSetVersionAbort()\r
-{\r
-    result = evalAndLog('db.setVersion("version c")');\r
-    verifyResult(result);\r
-    result.onsuccess = createAnotherObjectStore;\r
-    result.onerror = unexpectedErrorCallback;\r
-}\r
-\r
-function createAnotherObjectStore()\r
-{\r
-    verifySuccessEvent(event);\r
-    shouldBeEqualToString("db.version", "version c");\r
-    shouldBeEqualToString("db.name", "name");\r
-    checkObjectStore();\r
-\r
-    objectStore = evalAndLog('db.createObjectStore("test456")');\r
-    var setVersionTrans = evalAndLog("setVersionTrans = event.result");\r
-    shouldBeTrue("setVersionTrans !== null");\r
-    setVersionTrans.oncomplete = unexpectedCompleteCallback;\r
-    setVersionTrans.onabort = checkMetadata;\r
-    setVersionTrans.abort();\r
-}\r
-\r
-function checkMetadata()\r
-{\r
-    shouldBeEqualToString("db.version", "version b");\r
-    checkObjectStore();\r
-    done();\r
+}
+
+function testSetVersionAbort()
+{
+    result = evalAndLog('db.setVersion("version c")');
+    verifyResult(result);
+    result.onsuccess = createAnotherObjectStore;
+    result.onerror = unexpectedErrorCallback;
+}
+
+function createAnotherObjectStore()
+{
+    verifySuccessEvent(event);
+    shouldBeEqualToString("db.version", "version c");
+    shouldBeEqualToString("db.name", "name");
+    checkObjectStore();
+
+    objectStore = evalAndLog('db.createObjectStore("test456")');
+    var setVersionTrans = evalAndLog("setVersionTrans = event.result");
+    shouldBeTrue("setVersionTrans !== null");
+    setVersionTrans.oncomplete = unexpectedCompleteCallback;
+    setVersionTrans.onabort = checkMetadata;
+    setVersionTrans.abort();
+}
+
+function checkMetadata()
+{
+    shouldBeEqualToString("db.version", "version b");
+    checkObjectStore();
+    done();
 }
 
 test();
index 99edc84a90316c1198e1470e01f546f8e4e351e4..005247eb67a701fef24be39ca2681a7f4670ec6a 100644 (file)
@@ -44,9 +44,9 @@ function setVersionSuccess()
 
     deleteAllObjectStores(db, createObjectStore);
 }
-\r
+
 function createObjectStore()
-{\r
+{
     debug("createObjectStore():");
     window.store = evalAndLog("store = db.createObjectStore('storeName', null)");
     var storeNames = evalAndLog("storeNames = db.objectStores");
@@ -65,19 +65,19 @@ function createObjectStore()
     } catch (err) {
         testPassed("Exception thrown.");
         // FIXME: Verify the correct exception thrown.
-    }\r
-\r
+    }
+
     createIndex();
-}\r
-\r
-function createIndex()\r
-{\r
-    debug("createIndex():");\r
-    var index = evalAndLog("index = store.createIndex('indexName', 'x', true)"); // true == unique requirement.\r
-    shouldBeTrue("index !== null");\r
-    shouldBeTrue("store.indexNames.contains('indexName')");\r
-    index = evalAndLog("index = store.index('indexName')");\r
-    shouldBeTrue("index !== null");\r
+}
+
+function createIndex()
+{
+    debug("createIndex():");
+    var index = evalAndLog("index = store.createIndex('indexName', 'x', true)"); // true == unique requirement.
+    shouldBeTrue("index !== null");
+    shouldBeTrue("store.indexNames.contains('indexName')");
+    index = evalAndLog("index = store.index('indexName')");
+    shouldBeTrue("index !== null");
  
     debug("Ask for an index that doesn't exist:");
     try {
@@ -89,57 +89,57 @@ function createIndex()
         // FIXME: Verify the correct exception thrown.
     }
 
-    commitAndContinue();    \r
+    commitAndContinue();    
 }
 
-function commitAndContinue()\r
-{\r
-    window.setTimeout(testSetVersionAbort, 0);\r
+function commitAndContinue()
+{
+    window.setTimeout(testSetVersionAbort, 0);
 }
 
-function testSetVersionAbort()\r
-{\r
-    result = evalAndLog('db.setVersion("version fail")');\r
-    verifyResult(result);\r
-    result.onsuccess = createAnotherIndex;\r
-    result.onerror = unexpectedErrorCallback;\r
-}\r
-\r
-function createAnotherIndex()\r
-{\r
-    verifySuccessEvent(event);\r
-    shouldBeEqualToString("db.version", "version fail");\r
-\r
-    var setVersionTrans = evalAndLog("setVersionTrans = event.result");\r
-    shouldBeTrue("setVersionTrans !== null");\r
-    setVersionTrans.oncomplete = unexpectedCompleteCallback;\r
-    setVersionTrans.onabort = checkMetadata;\r
-    window.store = evalAndLog("store = setVersionTrans.objectStore('storeName')");\r
-    var index = evalAndLog("index = store.createIndex('indexFail', 'x')");\r
-\r
-    setVersionTrans.abort();\r
-}\r
-\r
-function checkMetadata()\r
-{\r
-    shouldBeEqualToString("db.version", "new version");\r
-    shouldBe("store.indexNames", "['indexName']");\r
-    shouldBe("store.indexNames.length", "1");\r
-    shouldBe("store.indexNames.contains('')", "false");\r
-    shouldBe("store.indexNames.contains('indexFail')", "false");\r
-    shouldBe("store.indexNames.contains('indexName')", "true");\r
+function testSetVersionAbort()
+{
+    result = evalAndLog('db.setVersion("version fail")');
+    verifyResult(result);
+    result.onsuccess = createAnotherIndex;
+    result.onerror = unexpectedErrorCallback;
+}
+
+function createAnotherIndex()
+{
+    verifySuccessEvent(event);
+    shouldBeEqualToString("db.version", "version fail");
+
+    var setVersionTrans = evalAndLog("setVersionTrans = event.result");
+    shouldBeTrue("setVersionTrans !== null");
+    setVersionTrans.oncomplete = unexpectedCompleteCallback;
+    setVersionTrans.onabort = checkMetadata;
+    window.store = evalAndLog("store = setVersionTrans.objectStore('storeName')");
+    var index = evalAndLog("index = store.createIndex('indexFail', 'x')");
+
+    setVersionTrans.abort();
+}
+
+function checkMetadata()
+{
+    shouldBeEqualToString("db.version", "new version");
+    shouldBe("store.indexNames", "['indexName']");
+    shouldBe("store.indexNames.length", "1");
+    shouldBe("store.indexNames.contains('')", "false");
+    shouldBe("store.indexNames.contains('indexFail')", "false");
+    shouldBe("store.indexNames.contains('indexName')", "true");
     shouldBeEqualToString("store.indexNames[0]", "indexName");
     shouldBeNull("store.indexNames[1]");
     shouldBeNull("store.indexNames[100]");
     shouldBeNull("store.indexNames.item(1)");
     shouldBeNull("store.indexNames.item(100)");
-    addData();\r
-}\r
+    addData();
+}
 
 
 function addData()
 {
-    var transaction = evalAndLog("transaction = db.transaction()");\r
+    var transaction = evalAndLog("transaction = db.transaction()");
     transaction.onabort = unexpectedAbortCallback;
     window.store = evalAndLog("store = transaction.objectStore('storeName')");
     result = evalAndLog("store.add({x: 'value'}, 'key')");
index 5a3f50fe24bdba2286167d7d0706fdcd2da48387..01ec60645081307f1b04758fc8de8d606368270c 100644 (file)
@@ -76,23 +76,23 @@ function unexpectedAbortCallback()
     testFailed("Abort function called unexpectedly!");
     debug("");
     verifyAbortEvent(event);
-    done();\r
-}\r
-\r
-function unexpectedCompleteCallback()\r
-{\r
-    testFailed("oncomplete function called unexpectedly!");\r
-    debug("");\r
-    verifyCompleteEvent(event);\r
-    done();\r
+    done();
+}
+
+function unexpectedCompleteCallback()
+{
+    testFailed("oncomplete function called unexpectedly!");
+    debug("");
+    verifyCompleteEvent(event);
+    done();
 }
 
-// FIXME: remove the onfinished parameter.\r
-function deleteAllObjectStores(db, onfinished)\r
-{\r
-    while (db.objectStores.length)\r
-        db.removeObjectStore(db.objectStores.item(0));\r
-\r
-    debug("Deleted all object stores.");\r
+// FIXME: remove the onfinished parameter.
+function deleteAllObjectStores(db, onfinished)
+{
+    while (db.objectStores.length)
+        db.removeObjectStore(db.objectStores.item(0));
+
+    debug("Deleted all object stores.");
     onfinished();
 }
index 31be0c32d49783c29fcb00b2e037686ce1daa6d8..e121c6097aafb6bd1d97df459fb8d207329b25bc 100644 (file)
@@ -352,10 +352,10 @@ static PassRefPtr<InspectorObject> buildObjectForFrame(Frame* frame)
     RefPtr<InspectorObject> frameObject = InspectorObject::create();
     frameObject->setNumber("id", frameId(frame));
     frameObject->setNumber("parentId", frameId(frame->tree()->parent()));
-    if (frame->ownerElement()) {\r
-        String name = frame->ownerElement()->getAttribute(HTMLNames::nameAttr);\r
-        if (name.isEmpty())\r
-            name = frame->ownerElement()->getAttribute(HTMLNames::idAttr);\r
+    if (frame->ownerElement()) {
+        String name = frame->ownerElement()->getAttribute(HTMLNames::nameAttr);
+        if (name.isEmpty())
+            name = frame->ownerElement()->getAttribute(HTMLNames::idAttr);
         frameObject->setString("name", name);
     }
     frameObject->setString("url", frame->loader()->url().string());
index 04952d0653ab5ccfa436f10d5e82fd52a437ed80..501b1605d89c1ce46bdcdb219a1f4197392931a8 100644 (file)
@@ -1,3 +1,9 @@
+2010-11-02  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
+
+        Unreviewed: Add myself to the list of Committers.
+
+        * Scripts/webkitpy/common/config/committers.py:
+
 2010-11-02  Anders Carlsson  <andersca@apple.com>
 
         Fix build.
index 96fba03697c87833acad7aed1311bfd9d3992043..f828a753daab9e7232fda004c823cf9c9b9fdd74 100644 (file)
@@ -112,6 +112,7 @@ committers_unable_to_review = [
     Committer("Girish Ramakrishnan", ["girish@forwardbias.in", "ramakrishnan.girish@gmail.com"]),
     Committer("Graham Dennis", ["Graham.Dennis@gmail.com", "gdennis@webkit.org"]),
     Committer("Greg Bolsinga", "bolsinga@apple.com"),
+    Committer("Gyuyoung Kim", ["gyuyoung.kim@samsung.com", "gyuyoung@gmail.com", "gyuyoung@webkit.org"], "gyuyoung"),
     Committer("Hans Wennborg", "hans@chromium.org", "hwennborg"),
     Committer("Hayato Ito", "hayato@chromium.org", "hayato"),
     Committer("Hin-Chung Lam", ["hclam@google.com", "hclam@chromium.org"]),