Fix a stupid bug in Unicode::toUpper/toLower.

        Fixes all three test failures in the JavaScriptCore test
        suite.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26017 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/JavaScriptCore/ChangeLog b/JavaScriptCore/ChangeLog
index 6b3d8a3c9aea8a1dc0068c2c78d971bc9584d704..11a3ed4e3c905dd23beac7739b5862e603c7de34 100644 (file)
--- a/JavaScriptCore/ChangeLog
+++ b/JavaScriptCore/ChangeLog
@@ -1,3 +1,15 @@
+2007-10-03  Lars Knoll  <lars@trolltech.com>
+
+        Reviewed by Rob.
+
+        Fix a stupid bug in Unicode::toUpper/toLower.
+        Fixes all three test failures in the JavaScriptCore test
+        suite.
+
+        * wtf/unicode/qt4/UnicodeQt4.h:
+        (WTF::Unicode::toLower):
+        (WTF::Unicode::toUpper):
+
 2007-10-02  Darin Adler  <darin@apple.com>
 
         Reviewed by Adam.

diff --git a/JavaScriptCore/wtf/unicode/qt4/UnicodeQt4.h b/JavaScriptCore/wtf/unicode/qt4/UnicodeQt4.h
index f5004a8d5326155171f4fe0302947a0353f66955..28eee86408b5ab4c3d0c2c1dbac38040d74d34f3 100644 (file)
--- a/JavaScriptCore/wtf/unicode/qt4/UnicodeQt4.h
+++ b/JavaScriptCore/wtf/unicode/qt4/UnicodeQt4.h
@@ -174,7 +174,7 @@ namespace WTF {
 
 #if QT_VERSION >= 0x040300
     // FIXME: handle surrogates correctly in all methods
-    
+
     inline UChar32 toLower(UChar32 ch)
     {
       return QChar::toLower(ch);
@@ -186,9 +186,9 @@ namespace WTF {
         const UChar *s = src;
         UChar *r = result;
         UChar *re = result + resultLength;
-        
+
         // this avoids one out of bounds check in the loop
-        if (QChar(*s).isLowSurrogate()) 
+        if (QChar(*s).isLowSurrogate())
             *r++ = *s++;
 
         int needed = 0;
@@ -199,7 +199,7 @@ namespace WTF {
             const QUnicodeTables::Properties *prop = QUnicodeTables::properties(c);
             if (prop->lowerCaseSpecial) {
                 QString qstring;
-                if (c > 0x10000) {
+                if (c < 0x10000) {
                     qstring += QChar(c);
                 } else {
                     qstring += QChar(*(s-1));
@@ -239,9 +239,9 @@ namespace WTF {
         const UChar *s = src;
         UChar *r = result;
         UChar *re = result + resultLength;
-        
+
         // this avoids one out of bounds check in the loop
-        if (QChar(*s).isLowSurrogate()) 
+        if (QChar(*s).isLowSurrogate())
             *r++ = *s++;
 
         int needed = 0;
@@ -252,7 +252,7 @@ namespace WTF {
             const QUnicodeTables::Properties *prop = QUnicodeTables::properties(c);
             if (prop->upperCaseSpecial) {
                 QString qstring;
-                if (c > 0x10000) {
+                if (c < 0x10000) {
                     qstring += QChar(c);
                 } else {
                     qstring += QChar(*(s-1));
@@ -389,7 +389,7 @@ namespace WTF {
     {
       return (CharCategory) U_MASK(QChar::category(c));
     }
-    
+
 #else
 
     inline UChar32 toLower(UChar32 ch)
@@ -538,7 +538,7 @@ namespace WTF {
     }
 
 #endif
-    
+
   }
 }