2009-05-24 Xan Lopez <xlopez@igalia.com>

        Reviewed by Mark Rowe.

        https://bugs.webkit.org/show_bug.cgi?id=25987
        [GTK] Clarify WebKitWebView::download-requested documentation

        Explain a bit why this signal is not emitted by default and offer
        a common solution/setup for that issue.

        * webkit/webkitwebview.cpp:
        (webkit_web_view_class_init):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44113 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebKit/gtk/ChangeLog b/WebKit/gtk/ChangeLog
index 4f4d58afb96044ed7fa19cb2443249802d7f69d8..6ef533c5609e9f5414f203f3469c9c1387082c48 100644 (file)
--- a/WebKit/gtk/ChangeLog
+++ b/WebKit/gtk/ChangeLog
@@ -1,3 +1,16 @@
+2009-05-24  Xan Lopez  <xlopez@igalia.com>
+
+        Reviewed by Mark Rowe.
+
+        https://bugs.webkit.org/show_bug.cgi?id=25987
+        [GTK] Clarify WebKitWebView::download-requested documentation
+
+        Explain a bit why this signal is not emitted by default and offer
+        a common solution/setup for that issue.
+
+        * webkit/webkitwebview.cpp:
+        (webkit_web_view_class_init):
+
 2009-05-23  Jan Michael Alonzo  <jmalonzo@webkit.org>
 
         Rubber-stamped by Gustavo Noronha.

diff --git a/WebKit/gtk/webkit/webkitwebview.cpp b/WebKit/gtk/webkit/webkitwebview.cpp
index bde377711e5a487842a00a8460e33cc54026f144..082a3a2cdca6f58460d103229e943ac3c1d1ee72 100644 (file)
--- a/WebKit/gtk/webkit/webkitwebview.cpp
+++ b/WebKit/gtk/webkit/webkitwebview.cpp
@@ -1262,6 +1262,17 @@ static void webkit_web_view_class_init(WebKitWebViewClass* webViewClass)
      * the #WebKitDownload helper object you must handle this signal,
      * and return %FALSE.
      *
+     * Also, keep in mind that the default policy for WebKitGTK+ is to
+     * ignore files with a MIME type that it does not know how to
+     * handle, which means this signal won't be emitted in the default
+     * setup. One way to trigger downloads is to connect to
+     * WebKitWebView::mime-type-policy-decision-requested and call
+     * webkit_web_policy_decision_download() on the
+     * #WebKitWebPolicyDecision in the parameter list for the kind of
+     * files you want your application to download (a common solution
+     * is to download anything that WebKit can't handle, which you can
+     * figure out by using webkit_web_view_can_show_mime_type()).
+     *
      * Since: 1.1.2
      */
     webkit_web_view_signals[DOWNLOAD_REQUESTED] = g_signal_new("download-requested",