2010-11-09 Gyuyoung Kim <gyuyoung.kim@samsung.com>
authorgyuyoung.kim@samsung.com <gyuyoung.kim@samsung.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 10 Nov 2010 05:59:45 +0000 (05:59 +0000)
committergyuyoung.kim@samsung.com <gyuyoung.kim@samsung.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 10 Nov 2010 05:59:45 +0000 (05:59 +0000)
        Reviewed by Eric Seidel.

        [WML] Fix build breaks when WML is enabled.
        https://bugs.webkit.org/show_bug.cgi?id=49168

        The backForward() of Page class returns BackForwarddController class type.
        So, WML classes need to include the BackForwardController.h file. And, select()
        of RenderTextControl.h was removed. Thus, the select() should be replaced by
        setSelectionRange().

        * wml/WMLDoElement.cpp: Includes BackForwardController.h.
        * wml/WMLDocument.cpp: ditto.
        * wml/WMLInputElement.cpp:
        (WebCore::WMLInputElement::select): Replaced by setSelectionRange().
        * wml/WMLPageState.cpp: Includes BackForwardController.h.
        * wml/WMLPrevElement.cpp: ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebCore/ChangeLog
WebCore/wml/WMLDoElement.cpp
WebCore/wml/WMLDocument.cpp
WebCore/wml/WMLInputElement.cpp
WebCore/wml/WMLPageState.cpp
WebCore/wml/WMLPrevElement.cpp

index 37ab97261a397c576ca5d14bf2d1126ca8f4cc34..cb5e28527148b8a33ee16c0791f5688446d8831e 100644 (file)
@@ -1,3 +1,22 @@
+2010-11-09  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
+
+        Reviewed by Eric Seidel.
+
+        [WML] Fix build breaks when WML is enabled.
+        https://bugs.webkit.org/show_bug.cgi?id=49168
+
+        The backForward() of Page class returns BackForwarddController class type. 
+        So, WML classes need to include the BackForwardController.h file. And, select() 
+        of RenderTextControl.h was removed. Thus, the select() should be replaced by 
+        setSelectionRange().
+
+        * wml/WMLDoElement.cpp: Includes BackForwardController.h.
+        * wml/WMLDocument.cpp: ditto.
+        * wml/WMLInputElement.cpp: 
+        (WebCore::WMLInputElement::select): Replaced by setSelectionRange().
+        * wml/WMLPageState.cpp: Includes BackForwardController.h.
+        * wml/WMLPrevElement.cpp: ditto.
+
 2010-11-09  Chris Rogers  <crogers@google.com>
 
         Reviewed by Kenneth Russell.
index 899bee19739843050fee7c15774011d684cccc19..a8d48809decdb121e9b45a1a237b6ee4851be45f 100644 (file)
@@ -24,6 +24,7 @@
 #include "WMLDoElement.h"
 
 #include "Attribute.h"
+#include "BackForwardController.h"
 #include "Event.h"
 #include "EventNames.h"
 #include "HTMLNames.h"
index 440f8eeacbfe4fdc14e80483763b619a6208a73a..9b29899abacbb8ca5c8f45d20e1382c394a52e11 100644 (file)
@@ -23,6 +23,7 @@
 #if ENABLE(WML)
 #include "WMLDocument.h"
 
+#include "BackForwardController.h"
 #include "BackForwardList.h"
 #include "Frame.h"
 #include "Page.h"
index 2165bd44126b27e89448a9aaf9ae28f023ff4d36..2d7310afe8d3543c13adbef366e1a30aafe6cea5 100644 (file)
@@ -191,7 +191,7 @@ void WMLInputElement::restoreFormControlState(const String& state)
 void WMLInputElement::select()
 {
     if (RenderTextControl* r = toRenderTextControl(renderer()))
-        r->select();
+        setSelectionRange(this, 0, r->text().length());
 }
 
 void WMLInputElement::accessKeyAction(bool)
index 5779e0ecea51ed6315585c9cbc59bfba1c35646c..a3c6243630c4d61e618368d6ccc3f499dc04cb69 100644 (file)
@@ -24,6 +24,7 @@
 #if ENABLE(WML)
 #include "WMLPageState.h"
 
+#include "BackForwardController.h"
 #include "BackForwardList.h"
 #include "Document.h"
 #include "Frame.h"
index fccdc0bca82acbd61bdd94c5236c00c85d3d80dc..c07f019110af6f48d63b75b92eb2f76531b7387b 100644 (file)
@@ -23,6 +23,7 @@
 #if ENABLE(WML)
 #include "WMLPrevElement.h"
 
+#include "BackForwardController.h"
 #include "Page.h"
 #include "WMLCardElement.h"
 #include "WMLDocument.h"