2006-03-06 Eric Seidel <eseidel@apple.com>

        Reviewed by mjs.

        Fix more pages (apple.com, yahoo.com) by returning empty error image.
        Empty a couple more stubs and clean up stub style a little.

        * platform/cairo/ImageCairo.cpp:
        (WebCore::Image::loadResource):
        * platform/win/TemporaryLinkStubs.cpp:
        (QListBox::isSelected):
        (QSlider::sizeHint):
        (QScrollBar::~QScrollBar):
        (FrameWin::getObjectInstanceForWidget):
        (FrameWin::getEmbedInstanceForWidget):
        (FrameWin::recordFormValue):
        (FrameWin::getAppletInstanceForWidget):
        (FrameWin::passMouseDownEventToWidget):
        (FrameWin::passWheelEventToChildWidget):
        (FrameWin::createPlugin):
        (BrowserExtensionWin::createNewWindow):
        (Path::Path):
        (QLineEdit::~QLineEdit):
        (QLineEdit::setLiveSearch):
        (QComboBox::~QComboBox):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13166 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index 2b93ac9d1efb793cacca61efca84f859314468db..983e721da2d31c777843c4a8908c10fad1d117e1 100644 (file)
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,29 @@
+2006-03-06  Eric Seidel  <eseidel@apple.com>
+
+        Reviewed by mjs.
+
+        Fix more pages (apple.com, yahoo.com) by returning empty error image.
+        Empty a couple more stubs and clean up stub style a little.
+
+        * platform/cairo/ImageCairo.cpp:
+        (WebCore::Image::loadResource):
+        * platform/win/TemporaryLinkStubs.cpp:
+        (QListBox::isSelected):
+        (QSlider::sizeHint):
+        (QScrollBar::~QScrollBar):
+        (FrameWin::getObjectInstanceForWidget):
+        (FrameWin::getEmbedInstanceForWidget):
+        (FrameWin::recordFormValue):
+        (FrameWin::getAppletInstanceForWidget):
+        (FrameWin::passMouseDownEventToWidget):
+        (FrameWin::passWheelEventToChildWidget):
+        (FrameWin::createPlugin):
+        (BrowserExtensionWin::createNewWindow):
+        (Path::Path):
+        (QLineEdit::~QLineEdit):
+        (QLineEdit::setLiveSearch):
+        (QComboBox::~QComboBox):
+
 2006-03-06  Eric Seidel  <eseidel@apple.com>
 
         Reviewed by andersca.

diff --git a/WebCore/platform/cairo/ImageCairo.cpp b/WebCore/platform/cairo/ImageCairo.cpp
index 29d5dc0dc1aa855de05e4013e1ea4353b6307419..80b7ddab2148639be644ee10f44fdf7a9d068e86 100755 (executable)
--- a/WebCore/platform/cairo/ImageCairo.cpp
+++ b/WebCore/platform/cairo/ImageCairo.cpp
@@ -64,7 +64,7 @@ void Image::invalidateNativeData()
 Image* Image::loadResource(const char *name)
 {
     // FIXME: Read the error image from disk.
-    return 0;
+    return new Image();
 }
 
 bool Image::supportsType(const QString& type)

diff --git a/WebCore/platform/win/TemporaryLinkStubs.cpp b/WebCore/platform/win/TemporaryLinkStubs.cpp
index 6ccc60c29c76a05e48a53a7b3341f3e223382fd0..40c650378a4adc95023a967115702cc859d4bdeb 100644 (file)
--- a/WebCore/platform/win/TemporaryLinkStubs.cpp
+++ b/WebCore/platform/win/TemporaryLinkStubs.cpp
@@ -77,7 +77,6 @@ bool QTextEdit::hasSelectedText() const { notImplemented(); return 0; }
 int QTextEdit::selectionStart() { notImplemented(); return 0; }
 int ScrollView::scrollXOffset() const { notImplemented(); return 0; }
 bool QListBox::isSelected(int) const { notImplemented(); return 0; }
-QComboBox::~QComboBox() { notImplemented(); }
 Cursor::Cursor(Image*) { notImplemented(); }
 Widget::FocusPolicy QComboBox::focusPolicy() const { notImplemented(); return NoFocus; }
 void QTextEdit::setLineHeight(int) { notImplemented(); }
@@ -135,12 +134,10 @@ void QListBox::setEnabled(bool) { notImplemented(); }
 bool QListBox::checksDescendantsForFocus() const { notImplemented(); return 0; }
 Widget::FocusPolicy QListBox::focusPolicy() const { notImplemented(); return NoFocus; }
 WebCore::IntSize QSlider::sizeHint() const { notImplemented(); return IntSize(); }
-QLineEdit::~QLineEdit() { notImplemented(); }
 QTextEdit::~QTextEdit() { notImplemented(); }
 bool QTextEdit::checksDescendantsForFocus() const { notImplemented(); return false; }
 Widget::FocusPolicy QLineEdit::focusPolicy() const { notImplemented(); return NoFocus; }
 QScrollBar::~QScrollBar() { notImplemented(); }
-Path::Path(){ notImplemented(); }
 Path::Path(const IntRect&, Type){ notImplemented(); }
 Path::Path(const IntPointArray&){ notImplemented(); }
 Path::~Path(){ notImplemented(); }
@@ -175,24 +172,24 @@ void FrameWin::unfocusWindow() { notImplemented(); }
 bool FrameWin::locationbarVisible() { notImplemented(); return 0; }
 void FrameWin::respondToChangedSelection(WebCore::SelectionController const&,bool) { notImplemented(); }
 void FrameWin::issueRedoCommand(void) { notImplemented(); }
-KJS::Bindings::Instance * FrameWin::getObjectInstanceForWidget(Widget *) { notImplemented(); return 0; }
-KJS::Bindings::Instance * FrameWin::getEmbedInstanceForWidget(Widget *) { notImplemented(); return 0; }
+KJS::Bindings::Instance* FrameWin::getObjectInstanceForWidget(Widget *) { notImplemented(); return 0; }
+KJS::Bindings::Instance* FrameWin::getEmbedInstanceForWidget(Widget *) { notImplemented(); return 0; }
 bool FrameWin::canRedo() const { notImplemented(); return 0; }
 bool FrameWin::canUndo() const { notImplemented(); return 0; }
 bool FrameWin::runJavaScriptPrompt(String const&,String const&,String &) { notImplemented(); return 0; }
-void FrameWin::recordFormValue(QString const&,QString const&,WebCore::HTMLFormElementImpl *) { notImplemented(); }
+void FrameWin::recordFormValue(QString const&,QString const&,WebCore::HTMLFormElementImpl*) { notImplemented(); }
 void FrameWin::registerCommandForRedo(WebCore::EditCommandPtr const&) { notImplemented(); }
 void FrameWin::runJavaScriptAlert(String const&) { notImplemented(); }
 bool FrameWin::runJavaScriptConfirm(String const&) { notImplemented(); return 0; }
 bool FrameWin::openURL(KURL const&) { notImplemented(); return 0; }
 void FrameWin::print() { notImplemented(); }
-KJS::Bindings::Instance * FrameWin::getAppletInstanceForWidget(Widget *) { notImplemented(); return 0; }
-bool FrameWin::passMouseDownEventToWidget(Widget *) { notImplemented(); return 0; }
+KJS::Bindings::Instance* FrameWin::getAppletInstanceForWidget(Widget*) { notImplemented(); return 0; }
+bool FrameWin::passMouseDownEventToWidget(Widget*) { notImplemented(); return 0; }
 void FrameWin::registerCommandForUndo(WebCore::EditCommandPtr const&) { notImplemented(); }
 void FrameWin::issueCutCommand() { notImplemented(); }
 void FrameWin::issueCopyCommand() { notImplemented(); }
 void FrameWin::openURLRequest(KURL const&,struct WebCore::URLArgs const&) { notImplemented(); }
-bool FrameWin::passWheelEventToChildWidget(WebCore::NodeImpl *) { notImplemented(); return 0; }
+bool FrameWin::passWheelEventToChildWidget(NodeImpl*) { notImplemented(); return 0; }
 void FrameWin::issueUndoCommand() { notImplemented(); }
 QString FrameWin::mimeTypeForFileName(QString const&) const { notImplemented(); return QString(); }
 void FrameWin::clearRecordedFormValues() { notImplemented(); }
@@ -211,12 +208,12 @@ QString FrameWin::incomingReferrer() const { notImplemented(); return QString();
 enum WebCore::ObjectContentType FrameWin::objectContentType(KURL const&,QString const&) { notImplemented(); return (ObjectContentType)0; }
 bool FrameWin::canGoBackOrForward(int) const { notImplemented(); return 0; }
 void FrameWin::issuePasteAndMatchStyleCommand() { notImplemented(); }
-WebCore::Plugin * FrameWin::createPlugin(KURL const&,QStringList const&,QStringList const&,QString const&) { notImplemented(); return 0; }
+WebCore::Plugin* FrameWin::createPlugin(KURL const&,QStringList const&,QStringList const&,QString const&) { notImplemented(); return 0; }
 void BrowserExtensionWin::openURLRequest(KURL const&,struct WebCore::URLArgs const&) { notImplemented(); }
 int BrowserExtensionWin::getHistoryLength() { notImplemented(); return 0; }
 bool BrowserExtensionWin::canRunModal() { notImplemented(); return 0; }
 void BrowserExtensionWin::openURLNotify() { notImplemented(); }
-void BrowserExtensionWin::createNewWindow(KURL const&,struct WebCore::URLArgs const&,struct WebCore::WindowArgs const&,WebCore::Frame * &) { notImplemented(); }
+void BrowserExtensionWin::createNewWindow(KURL const&,struct WebCore::URLArgs const&,struct WebCore::WindowArgs const&,Frame*&) { notImplemented(); }
 bool BrowserExtensionWin::canRunModalNow() { notImplemented(); return 0; }
 void BrowserExtensionWin::runModal() { notImplemented(); }
 void BrowserExtensionWin::goBackOrForward(int) { notImplemented(); }
@@ -309,12 +306,15 @@ void GraphicsContext::clearShadow() { }
 void GraphicsContext::beginTransparencyLayer(float) { }
 void GraphicsContext::endTransparencyLayer() { }
 
+Path::Path(){ }
+
 bool RenderThemeWin::paintCheckbox(RenderObject*, const RenderObject::PaintInfo&, const IntRect&) { return false; }
 bool RenderThemeWin::paintRadio(RenderObject*, const RenderObject::PaintInfo&, const IntRect&) { return false; }
 bool RenderThemeWin::paintButton(RenderObject*, const RenderObject::PaintInfo&, const IntRect&) { return false; }
 bool RenderThemeWin::paintTextField(RenderObject*, const RenderObject::PaintInfo&, const IntRect&) { return false; }
 
 QLineEdit::QLineEdit(QLineEdit::Type) { }
+QLineEdit::~QLineEdit() { }
 void QLineEdit::setFont(WebCore::Font const&) { }
 void QLineEdit::setAlignment(Qt::AlignmentFlags) { }
 void QLineEdit::setWritingDirection(TextDirection) { }
@@ -330,8 +330,10 @@ void QLineEdit::setPlaceholderString(String const&) { }
 void QLineEdit::setColors(Color const&,Color const&) { }
 IntSize QLineEdit::sizeForCharacterWidth(int) const { return IntSize(); }
 int QLineEdit::baselinePosition(int) const { return 0; }
+void QLineEdit::setLiveSearch(bool) { }
 
 QComboBox::QComboBox() { }
+QComboBox::~QComboBox() { }
 void QComboBox::setFont(WebCore::Font const&) { }
 int QComboBox::baselinePosition(int) const { return 0; }
 void QComboBox::setWritingDirection(TextDirection) { }
@@ -342,5 +344,3 @@ IntSize QComboBox::sizeHint() const { return IntSize(); }
 IntRect QComboBox::frameGeometry() const { return IntRect(); }
 void QComboBox::setFrameGeometry(IntRect const&) { }
 
-void QLineEdit::setLiveSearch(bool) { }
-