2009-02-28 Dimitri Glazkov <dglazkov@chromium.org>

        Reviewed by Darin Fisher.

        https://bugs.webkit.org/show_bug.cgi?id=24261
        Fix V8 custom binding scrubbing error.

        Test: fast/dom/TreeWalker/TreeWalker-currentNode.html
        Test: traversal/exception-forwarding.html
        TesT: traversal/stay-within-root.html

        * bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
        * bindings/v8/custom/V8NodeIteratorCustom.cpp:
        (WebCore::toV8): Replace v8::Undefined() return value with v8::Null().
        * bindings/v8/custom/V8TreeWalkerCustom.cpp:
        (WebCore::toV8): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index 1161fe32aa768231231c3def39e3a9eadacf86f6..a4350e099e75624290b0e01077ff0e4042abda90 100644 (file)
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,20 @@
+2009-02-28  Dimitri Glazkov  <dglazkov@chromium.org>
+
+        Reviewed by Darin Fisher.
+
+        https://bugs.webkit.org/show_bug.cgi?id=24261
+        Fix V8 custom binding scrubbing error.
+
+        Test: fast/dom/TreeWalker/TreeWalker-currentNode.html
+        Test: traversal/exception-forwarding.html
+        TesT: traversal/stay-within-root.html
+
+        * bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
+        * bindings/v8/custom/V8NodeIteratorCustom.cpp:
+        (WebCore::toV8): Replace v8::Undefined() return value with v8::Null().
+        * bindings/v8/custom/V8TreeWalkerCustom.cpp:
+        (WebCore::toV8): Ditto.
+

 2009-02-28  Dimitri Glazkov  <dglazkov@chromium.org>
 
         Reviewed by Darin Fisher.
 2009-02-28  Dimitri Glazkov  <dglazkov@chromium.org>
 
         Reviewed by Darin Fisher.

diff --git a/WebCore/bindings/v8/custom/V8NodeIteratorCustom.cpp b/WebCore/bindings/v8/custom/V8NodeIteratorCustom.cpp
index 85269f3470a7471c39de52423e5f3e4014c7917e..48e6b8f7bf1967d912c111c578d9ea0319645e1f 100644 (file)
--- a/WebCore/bindings/v8/custom/V8NodeIteratorCustom.cpp
+++ b/WebCore/bindings/v8/custom/V8NodeIteratorCustom.cpp
@@ -51,7 +51,7 @@ static inline v8::Handle<v8::Value> toV8(PassRefPtr<Node> object, ExceptionCode
         return throwError(state->exception());
 
     if (!object)
         return throwError(state->exception());
 
     if (!object)

-        return v8::Undefined();
+        return v8::Null();

 
     return V8Proxy::NodeToV8Object(object.get());
 }
 
     return V8Proxy::NodeToV8Object(object.get());
 }

diff --git a/WebCore/bindings/v8/custom/V8TreeWalkerCustom.cpp b/WebCore/bindings/v8/custom/V8TreeWalkerCustom.cpp
index 08fd66bcb28fd0052fe3859dd63ad8543844b933..baf49c0370b35d5998ebbadc319eff99f17fe2b2 100644 (file)
--- a/WebCore/bindings/v8/custom/V8TreeWalkerCustom.cpp
+++ b/WebCore/bindings/v8/custom/V8TreeWalkerCustom.cpp
@@ -49,7 +49,7 @@ static inline v8::Handle<v8::Value> toV8(PassRefPtr<Node> object, ScriptState* s
         return throwError(state->exception());
 
     if (!object)
         return throwError(state->exception());
 
     if (!object)

-        return v8::Undefined();
+        return v8::Null();

 
     return V8Proxy::NodeToV8Object(object.get());
 }
 
     return V8Proxy::NodeToV8Object(object.get());
 }