More FALLBACK_PLATFORM adoption
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 4 Dec 2020 19:51:39 +0000 (19:51 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 4 Dec 2020 19:51:39 +0000 (19:51 +0000)
https://bugs.webkit.org/show_bug.cgi?id=219545

Patch by Adam Roben <aroben@apple.com> on 2020-12-04
Reviewed by Tim Horton.

PerformanceTests:

* MediaTime/Configurations/SDKVariant.xcconfig:
WK_EMPTY_$(THIS_IS_NOT_EMPTY) evaluates to the empty string, not to
NO.

Source/bmalloc:

* Configurations/SDKVariant.xcconfig:
WK_EMPTY_$(THIS_IS_NOT_EMPTY) evaluates to the empty string, not to
NO.

Source/JavaScriptCore:

* Configurations/SDKVariant.xcconfig:
WK_EMPTY_$(THIS_IS_NOT_EMPTY) evaluates to the empty string, not to
NO.

Source/ThirdParty:

* gtest/xcode/Config/SDKVariant.xcconfig:
WK_EMPTY_$(THIS_IS_NOT_EMPTY) evaluates to the empty string, not to
NO.

Source/ThirdParty/ANGLE:

* Configurations/SDKVariant.xcconfig:
WK_EMPTY_$(THIS_IS_NOT_EMPTY) evaluates to the empty string, not to
NO.

Source/ThirdParty/libwebrtc:

* Configurations/SDKVariant.xcconfig:
WK_EMPTY_$(THIS_IS_NOT_EMPTY) evaluates to the empty string, not to
NO.

Source/WebCore:

* Configurations/SDKVariant.xcconfig:
WK_EMPTY_$(THIS_IS_NOT_EMPTY) evaluates to the empty string, not to
NO.

Source/WebCore/PAL:

* Configurations/SDKVariant.xcconfig:
WK_EMPTY_$(THIS_IS_NOT_EMPTY) evaluates to the empty string, not to
NO.

Source/WebInspectorUI:

* Configurations/SDKVariant.xcconfig:
WK_EMPTY_$(THIS_IS_NOT_EMPTY) evaluates to the empty string, not to
NO.

Source/WebKit:

* Configurations/SDKVariant.xcconfig:
WK_EMPTY_$(THIS_IS_NOT_EMPTY) evaluates to the empty string, not to
NO.

Source/WebKitLegacy/mac:

* Configurations/SDKVariant.xcconfig:
WK_EMPTY_$(THIS_IS_NOT_EMPTY) evaluates to the empty string, not to
NO.

Source/WTF:

* Configurations/SDKVariant.xcconfig:
WK_EMPTY_$(THIS_IS_NOT_EMPTY) evaluates to the empty string, not to
NO.

Tools:

* DumpRenderTree/Scripts/check-xcfilelists.sh:
* TestWebKitAPI/Scripts/check-xcfilelists.sh:
* WebKitTestRunner/Scripts/check-xcfilelists.sh:
Use FALLBACK_PLATFORM if it's defined.

* ContentExtensionTester/Configurations/SDKVariant.xcconfig:
* DumpRenderTree/mac/Configurations/SDKVariant.xcconfig:
* ImageDiff/cg/Configurations/SDKVariant.xcconfig:
* MiniBrowser/Configurations/SDKVariant.xcconfig:
* MobileMiniBrowser/Configurations/SDKVariant.xcconfig:
* TestWebKitAPI/Configurations/SDKVariant.xcconfig:
* WebEditingTester/Configurations/SDKVariant.xcconfig:
* WebKitTestRunner/Configurations/SDKVariant.xcconfig:
* lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig:
WK_EMPTY_$(THIS_IS_NOT_EMPTY) evaluates to the empty string, not to
NO.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@270445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

37 files changed:
PerformanceTests/ChangeLog
PerformanceTests/MediaTime/Configurations/SDKVariant.xcconfig
Source/JavaScriptCore/ChangeLog
Source/JavaScriptCore/Configurations/SDKVariant.xcconfig
Source/ThirdParty/ANGLE/ChangeLog
Source/ThirdParty/ANGLE/Configurations/SDKVariant.xcconfig
Source/ThirdParty/ChangeLog
Source/ThirdParty/gtest/xcode/Config/SDKVariant.xcconfig
Source/ThirdParty/libwebrtc/ChangeLog
Source/ThirdParty/libwebrtc/Configurations/SDKVariant.xcconfig
Source/WTF/ChangeLog
Source/WTF/Configurations/SDKVariant.xcconfig
Source/WebCore/ChangeLog
Source/WebCore/Configurations/SDKVariant.xcconfig
Source/WebCore/PAL/ChangeLog
Source/WebCore/PAL/Configurations/SDKVariant.xcconfig
Source/WebInspectorUI/ChangeLog
Source/WebInspectorUI/Configurations/SDKVariant.xcconfig
Source/WebKit/ChangeLog
Source/WebKit/Configurations/SDKVariant.xcconfig
Source/WebKitLegacy/mac/ChangeLog
Source/WebKitLegacy/mac/Configurations/SDKVariant.xcconfig
Source/bmalloc/ChangeLog
Source/bmalloc/Configurations/SDKVariant.xcconfig
Tools/ChangeLog
Tools/ContentExtensionTester/Configurations/SDKVariant.xcconfig
Tools/DumpRenderTree/Scripts/check-xcfilelists.sh
Tools/DumpRenderTree/mac/Configurations/SDKVariant.xcconfig
Tools/ImageDiff/cg/Configurations/SDKVariant.xcconfig
Tools/MiniBrowser/Configurations/SDKVariant.xcconfig
Tools/MobileMiniBrowser/Configurations/SDKVariant.xcconfig
Tools/TestWebKitAPI/Configurations/SDKVariant.xcconfig
Tools/TestWebKitAPI/Scripts/check-xcfilelists.sh
Tools/WebEditingTester/Configurations/SDKVariant.xcconfig
Tools/WebKitTestRunner/Configurations/SDKVariant.xcconfig
Tools/WebKitTestRunner/Scripts/check-xcfilelists.sh
Tools/lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig

index 8277532..c5790c6 100644 (file)
@@ -1,3 +1,14 @@
+2020-12-04  Adam Roben  <aroben@apple.com>
+
+        More FALLBACK_PLATFORM adoption
+        https://bugs.webkit.org/show_bug.cgi?id=219545
+
+        Reviewed by Tim Horton.
+
+        * MediaTime/Configurations/SDKVariant.xcconfig:
+        WK_EMPTY_$(THIS_IS_NOT_EMPTY) evaluates to the empty string, not to
+        NO.
+
 2020-12-03  Adam Roben  <aroben@apple.com>
 
         Adopt FALLBACK_PLATFORM
index 5540046..b4b37a9 100644 (file)
@@ -1,4 +1,4 @@
-// Copyright (C) 2019 Apple Inc. All rights reserved.
+// Copyright (C) 2019-2020 Apple Inc. All rights reserved.
 //
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions
@@ -27,7 +27,7 @@ WK_NOT_YES = NO;
 
 WK_DEFAULT_PLATFORM_NAME = $(WK_DEFAULT_PLATFORM_NAME_$(WK_EMPTY_$(FALLBACK_PLATFORM)));
 WK_DEFAULT_PLATFORM_NAME_YES = $(PLATFORM_NAME);
-WK_DEFAULT_PLATFORM_NAME_NO = $(FALLBACK_PLATFORM);
+WK_DEFAULT_PLATFORM_NAME_ = $(FALLBACK_PLATFORM);
 
 WK_ALTERNATE_FRAMEWORKS_DIR = $(WK_ALTERNATE_FRAMEWORKS_DIR_$(SDK_VARIANT));
 WK_ALTERNATE_FRAMEWORKS_DIR_iosmac = /System/iOSSupport;
index 8fad07d..682ee95 100644 (file)
@@ -1,3 +1,14 @@
+2020-12-04  Adam Roben  <aroben@apple.com>
+
+        More FALLBACK_PLATFORM adoption
+        https://bugs.webkit.org/show_bug.cgi?id=219545
+
+        Reviewed by Tim Horton.
+
+        * Configurations/SDKVariant.xcconfig:
+        WK_EMPTY_$(THIS_IS_NOT_EMPTY) evaluates to the empty string, not to
+        NO.
+
 2020-12-04  Caio Lima  <ticaiolima@gmail.com>
 
         [JIT] Value profile stores wrong value in BaselineJIT for some operations
index 5540046..b4b37a9 100644 (file)
@@ -1,4 +1,4 @@
-// Copyright (C) 2019 Apple Inc. All rights reserved.
+// Copyright (C) 2019-2020 Apple Inc. All rights reserved.
 //
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions
@@ -27,7 +27,7 @@ WK_NOT_YES = NO;
 
 WK_DEFAULT_PLATFORM_NAME = $(WK_DEFAULT_PLATFORM_NAME_$(WK_EMPTY_$(FALLBACK_PLATFORM)));
 WK_DEFAULT_PLATFORM_NAME_YES = $(PLATFORM_NAME);
-WK_DEFAULT_PLATFORM_NAME_NO = $(FALLBACK_PLATFORM);
+WK_DEFAULT_PLATFORM_NAME_ = $(FALLBACK_PLATFORM);
 
 WK_ALTERNATE_FRAMEWORKS_DIR = $(WK_ALTERNATE_FRAMEWORKS_DIR_$(SDK_VARIANT));
 WK_ALTERNATE_FRAMEWORKS_DIR_iosmac = /System/iOSSupport;
index 00a7667..534307c 100644 (file)
@@ -1,3 +1,14 @@
+2020-12-04  Adam Roben  <aroben@apple.com>
+
+        More FALLBACK_PLATFORM adoption
+        https://bugs.webkit.org/show_bug.cgi?id=219545
+
+        Reviewed by Tim Horton.
+
+        * Configurations/SDKVariant.xcconfig:
+        WK_EMPTY_$(THIS_IS_NOT_EMPTY) evaluates to the empty string, not to
+        NO.
+
 2020-12-04  Rob Buis  <rbuis@igalia.com>
 
         WebGL2: Null pointer dereference in std::string implementation in gl::Shader::getTransformFeedbackVaryingMappedName
index 5540046..b4b37a9 100644 (file)
@@ -1,4 +1,4 @@
-// Copyright (C) 2019 Apple Inc. All rights reserved.
+// Copyright (C) 2019-2020 Apple Inc. All rights reserved.
 //
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions
@@ -27,7 +27,7 @@ WK_NOT_YES = NO;
 
 WK_DEFAULT_PLATFORM_NAME = $(WK_DEFAULT_PLATFORM_NAME_$(WK_EMPTY_$(FALLBACK_PLATFORM)));
 WK_DEFAULT_PLATFORM_NAME_YES = $(PLATFORM_NAME);
-WK_DEFAULT_PLATFORM_NAME_NO = $(FALLBACK_PLATFORM);
+WK_DEFAULT_PLATFORM_NAME_ = $(FALLBACK_PLATFORM);
 
 WK_ALTERNATE_FRAMEWORKS_DIR = $(WK_ALTERNATE_FRAMEWORKS_DIR_$(SDK_VARIANT));
 WK_ALTERNATE_FRAMEWORKS_DIR_iosmac = /System/iOSSupport;
index 907034a..6621ece 100644 (file)
@@ -1,3 +1,14 @@
+2020-12-04  Adam Roben  <aroben@apple.com>
+
+        More FALLBACK_PLATFORM adoption
+        https://bugs.webkit.org/show_bug.cgi?id=219545
+
+        Reviewed by Tim Horton.
+
+        * gtest/xcode/Config/SDKVariant.xcconfig:
+        WK_EMPTY_$(THIS_IS_NOT_EMPTY) evaluates to the empty string, not to
+        NO.
+
 2020-12-03  Adam Roben  <aroben@apple.com>
 
         Adopt FALLBACK_PLATFORM
index 5540046..b4b37a9 100644 (file)
@@ -1,4 +1,4 @@
-// Copyright (C) 2019 Apple Inc. All rights reserved.
+// Copyright (C) 2019-2020 Apple Inc. All rights reserved.
 //
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions
@@ -27,7 +27,7 @@ WK_NOT_YES = NO;
 
 WK_DEFAULT_PLATFORM_NAME = $(WK_DEFAULT_PLATFORM_NAME_$(WK_EMPTY_$(FALLBACK_PLATFORM)));
 WK_DEFAULT_PLATFORM_NAME_YES = $(PLATFORM_NAME);
-WK_DEFAULT_PLATFORM_NAME_NO = $(FALLBACK_PLATFORM);
+WK_DEFAULT_PLATFORM_NAME_ = $(FALLBACK_PLATFORM);
 
 WK_ALTERNATE_FRAMEWORKS_DIR = $(WK_ALTERNATE_FRAMEWORKS_DIR_$(SDK_VARIANT));
 WK_ALTERNATE_FRAMEWORKS_DIR_iosmac = /System/iOSSupport;
index 88a772c..fdaf849 100644 (file)
@@ -1,3 +1,14 @@
+2020-12-04  Adam Roben  <aroben@apple.com>
+
+        More FALLBACK_PLATFORM adoption
+        https://bugs.webkit.org/show_bug.cgi?id=219545
+
+        Reviewed by Tim Horton.
+
+        * Configurations/SDKVariant.xcconfig:
+        WK_EMPTY_$(THIS_IS_NOT_EMPTY) evaluates to the empty string, not to
+        NO.
+
 2020-12-03  Adam Roben  <aroben@apple.com>
 
         Adopt FALLBACK_PLATFORM
index 5540046..b4b37a9 100644 (file)
@@ -1,4 +1,4 @@
-// Copyright (C) 2019 Apple Inc. All rights reserved.
+// Copyright (C) 2019-2020 Apple Inc. All rights reserved.
 //
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions
@@ -27,7 +27,7 @@ WK_NOT_YES = NO;
 
 WK_DEFAULT_PLATFORM_NAME = $(WK_DEFAULT_PLATFORM_NAME_$(WK_EMPTY_$(FALLBACK_PLATFORM)));
 WK_DEFAULT_PLATFORM_NAME_YES = $(PLATFORM_NAME);
-WK_DEFAULT_PLATFORM_NAME_NO = $(FALLBACK_PLATFORM);
+WK_DEFAULT_PLATFORM_NAME_ = $(FALLBACK_PLATFORM);
 
 WK_ALTERNATE_FRAMEWORKS_DIR = $(WK_ALTERNATE_FRAMEWORKS_DIR_$(SDK_VARIANT));
 WK_ALTERNATE_FRAMEWORKS_DIR_iosmac = /System/iOSSupport;
index 33e3af5..477c9d6 100644 (file)
@@ -1,3 +1,14 @@
+2020-12-04  Adam Roben  <aroben@apple.com>
+
+        More FALLBACK_PLATFORM adoption
+        https://bugs.webkit.org/show_bug.cgi?id=219545
+
+        Reviewed by Tim Horton.
+
+        * Configurations/SDKVariant.xcconfig:
+        WK_EMPTY_$(THIS_IS_NOT_EMPTY) evaluates to the empty string, not to
+        NO.
+
 2020-12-03  Adam Roben  <aroben@apple.com>
 
         Adopt FALLBACK_PLATFORM
index 5540046..b4b37a9 100644 (file)
@@ -1,4 +1,4 @@
-// Copyright (C) 2019 Apple Inc. All rights reserved.
+// Copyright (C) 2019-2020 Apple Inc. All rights reserved.
 //
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions
@@ -27,7 +27,7 @@ WK_NOT_YES = NO;
 
 WK_DEFAULT_PLATFORM_NAME = $(WK_DEFAULT_PLATFORM_NAME_$(WK_EMPTY_$(FALLBACK_PLATFORM)));
 WK_DEFAULT_PLATFORM_NAME_YES = $(PLATFORM_NAME);
-WK_DEFAULT_PLATFORM_NAME_NO = $(FALLBACK_PLATFORM);
+WK_DEFAULT_PLATFORM_NAME_ = $(FALLBACK_PLATFORM);
 
 WK_ALTERNATE_FRAMEWORKS_DIR = $(WK_ALTERNATE_FRAMEWORKS_DIR_$(SDK_VARIANT));
 WK_ALTERNATE_FRAMEWORKS_DIR_iosmac = /System/iOSSupport;
index b2c74c7..671474f 100644 (file)
@@ -1,3 +1,14 @@
+2020-12-04  Adam Roben  <aroben@apple.com>
+
+        More FALLBACK_PLATFORM adoption
+        https://bugs.webkit.org/show_bug.cgi?id=219545
+
+        Reviewed by Tim Horton.
+
+        * Configurations/SDKVariant.xcconfig:
+        WK_EMPTY_$(THIS_IS_NOT_EMPTY) evaluates to the empty string, not to
+        NO.
+
 2020-12-04  Said Abou-Hallawa  <said@apple.com>
 
         [GPU Process] Share the NativeImage with GPU Process through a ShareableBitmap
index 5540046..b4b37a9 100644 (file)
@@ -1,4 +1,4 @@
-// Copyright (C) 2019 Apple Inc. All rights reserved.
+// Copyright (C) 2019-2020 Apple Inc. All rights reserved.
 //
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions
@@ -27,7 +27,7 @@ WK_NOT_YES = NO;
 
 WK_DEFAULT_PLATFORM_NAME = $(WK_DEFAULT_PLATFORM_NAME_$(WK_EMPTY_$(FALLBACK_PLATFORM)));
 WK_DEFAULT_PLATFORM_NAME_YES = $(PLATFORM_NAME);
-WK_DEFAULT_PLATFORM_NAME_NO = $(FALLBACK_PLATFORM);
+WK_DEFAULT_PLATFORM_NAME_ = $(FALLBACK_PLATFORM);
 
 WK_ALTERNATE_FRAMEWORKS_DIR = $(WK_ALTERNATE_FRAMEWORKS_DIR_$(SDK_VARIANT));
 WK_ALTERNATE_FRAMEWORKS_DIR_iosmac = /System/iOSSupport;
index 60be920..cbb0a73 100644 (file)
@@ -1,3 +1,14 @@
+2020-12-04  Adam Roben  <aroben@apple.com>
+
+        More FALLBACK_PLATFORM adoption
+        https://bugs.webkit.org/show_bug.cgi?id=219545
+
+        Reviewed by Tim Horton.
+
+        * Configurations/SDKVariant.xcconfig:
+        WK_EMPTY_$(THIS_IS_NOT_EMPTY) evaluates to the empty string, not to
+        NO.
+
 2020-12-03  Adam Roben  <aroben@apple.com>
 
         Adopt FALLBACK_PLATFORM
index 5540046..b4b37a9 100644 (file)
@@ -1,4 +1,4 @@
-// Copyright (C) 2019 Apple Inc. All rights reserved.
+// Copyright (C) 2019-2020 Apple Inc. All rights reserved.
 //
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions
@@ -27,7 +27,7 @@ WK_NOT_YES = NO;
 
 WK_DEFAULT_PLATFORM_NAME = $(WK_DEFAULT_PLATFORM_NAME_$(WK_EMPTY_$(FALLBACK_PLATFORM)));
 WK_DEFAULT_PLATFORM_NAME_YES = $(PLATFORM_NAME);
-WK_DEFAULT_PLATFORM_NAME_NO = $(FALLBACK_PLATFORM);
+WK_DEFAULT_PLATFORM_NAME_ = $(FALLBACK_PLATFORM);
 
 WK_ALTERNATE_FRAMEWORKS_DIR = $(WK_ALTERNATE_FRAMEWORKS_DIR_$(SDK_VARIANT));
 WK_ALTERNATE_FRAMEWORKS_DIR_iosmac = /System/iOSSupport;
index fdd211c..db27811 100644 (file)
@@ -1,3 +1,14 @@
+2020-12-04  Adam Roben  <aroben@apple.com>
+
+        More FALLBACK_PLATFORM adoption
+        https://bugs.webkit.org/show_bug.cgi?id=219545
+
+        Reviewed by Tim Horton.
+
+        * Configurations/SDKVariant.xcconfig:
+        WK_EMPTY_$(THIS_IS_NOT_EMPTY) evaluates to the empty string, not to
+        NO.
+
 2020-12-03  Adam Roben  <aroben@apple.com>
 
         Adopt FALLBACK_PLATFORM
index 5540046..b4b37a9 100644 (file)
@@ -1,4 +1,4 @@
-// Copyright (C) 2019 Apple Inc. All rights reserved.
+// Copyright (C) 2019-2020 Apple Inc. All rights reserved.
 //
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions
@@ -27,7 +27,7 @@ WK_NOT_YES = NO;
 
 WK_DEFAULT_PLATFORM_NAME = $(WK_DEFAULT_PLATFORM_NAME_$(WK_EMPTY_$(FALLBACK_PLATFORM)));
 WK_DEFAULT_PLATFORM_NAME_YES = $(PLATFORM_NAME);
-WK_DEFAULT_PLATFORM_NAME_NO = $(FALLBACK_PLATFORM);
+WK_DEFAULT_PLATFORM_NAME_ = $(FALLBACK_PLATFORM);
 
 WK_ALTERNATE_FRAMEWORKS_DIR = $(WK_ALTERNATE_FRAMEWORKS_DIR_$(SDK_VARIANT));
 WK_ALTERNATE_FRAMEWORKS_DIR_iosmac = /System/iOSSupport;
index b9b7591..a1fe21a 100644 (file)
@@ -1,3 +1,14 @@
+2020-12-04  Adam Roben  <aroben@apple.com>
+
+        More FALLBACK_PLATFORM adoption
+        https://bugs.webkit.org/show_bug.cgi?id=219545
+
+        Reviewed by Tim Horton.
+
+        * Configurations/SDKVariant.xcconfig:
+        WK_EMPTY_$(THIS_IS_NOT_EMPTY) evaluates to the empty string, not to
+        NO.
+
 2020-12-04  Said Abou-Hallawa  <said@apple.com>
 
         [GPU Process] Share the NativeImage with GPU Process through a ShareableBitmap
index 5540046..b4b37a9 100644 (file)
@@ -1,4 +1,4 @@
-// Copyright (C) 2019 Apple Inc. All rights reserved.
+// Copyright (C) 2019-2020 Apple Inc. All rights reserved.
 //
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions
@@ -27,7 +27,7 @@ WK_NOT_YES = NO;
 
 WK_DEFAULT_PLATFORM_NAME = $(WK_DEFAULT_PLATFORM_NAME_$(WK_EMPTY_$(FALLBACK_PLATFORM)));
 WK_DEFAULT_PLATFORM_NAME_YES = $(PLATFORM_NAME);
-WK_DEFAULT_PLATFORM_NAME_NO = $(FALLBACK_PLATFORM);
+WK_DEFAULT_PLATFORM_NAME_ = $(FALLBACK_PLATFORM);
 
 WK_ALTERNATE_FRAMEWORKS_DIR = $(WK_ALTERNATE_FRAMEWORKS_DIR_$(SDK_VARIANT));
 WK_ALTERNATE_FRAMEWORKS_DIR_iosmac = /System/iOSSupport;
index 2b143dd..95fd8b1 100644 (file)
@@ -1,3 +1,14 @@
+2020-12-04  Adam Roben  <aroben@apple.com>
+
+        More FALLBACK_PLATFORM adoption
+        https://bugs.webkit.org/show_bug.cgi?id=219545
+
+        Reviewed by Tim Horton.
+
+        * Configurations/SDKVariant.xcconfig:
+        WK_EMPTY_$(THIS_IS_NOT_EMPTY) evaluates to the empty string, not to
+        NO.
+
 2020-12-03  Adam Roben  <aroben@apple.com>
 
         Adopt FALLBACK_PLATFORM
index 5540046..b4b37a9 100644 (file)
@@ -1,4 +1,4 @@
-// Copyright (C) 2019 Apple Inc. All rights reserved.
+// Copyright (C) 2019-2020 Apple Inc. All rights reserved.
 //
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions
@@ -27,7 +27,7 @@ WK_NOT_YES = NO;
 
 WK_DEFAULT_PLATFORM_NAME = $(WK_DEFAULT_PLATFORM_NAME_$(WK_EMPTY_$(FALLBACK_PLATFORM)));
 WK_DEFAULT_PLATFORM_NAME_YES = $(PLATFORM_NAME);
-WK_DEFAULT_PLATFORM_NAME_NO = $(FALLBACK_PLATFORM);
+WK_DEFAULT_PLATFORM_NAME_ = $(FALLBACK_PLATFORM);
 
 WK_ALTERNATE_FRAMEWORKS_DIR = $(WK_ALTERNATE_FRAMEWORKS_DIR_$(SDK_VARIANT));
 WK_ALTERNATE_FRAMEWORKS_DIR_iosmac = /System/iOSSupport;
index 050b445..33ec707 100644 (file)
@@ -1,3 +1,14 @@
+2020-12-04  Adam Roben  <aroben@apple.com>
+
+        More FALLBACK_PLATFORM adoption
+        https://bugs.webkit.org/show_bug.cgi?id=219545
+
+        Reviewed by Tim Horton.
+
+        * Configurations/SDKVariant.xcconfig:
+        WK_EMPTY_$(THIS_IS_NOT_EMPTY) evaluates to the empty string, not to
+        NO.
+
 2020-12-03  Adam Roben  <aroben@apple.com>
 
         Adopt FALLBACK_PLATFORM
index 5540046..b4b37a9 100644 (file)
@@ -1,4 +1,4 @@
-// Copyright (C) 2019 Apple Inc. All rights reserved.
+// Copyright (C) 2019-2020 Apple Inc. All rights reserved.
 //
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions
@@ -27,7 +27,7 @@ WK_NOT_YES = NO;
 
 WK_DEFAULT_PLATFORM_NAME = $(WK_DEFAULT_PLATFORM_NAME_$(WK_EMPTY_$(FALLBACK_PLATFORM)));
 WK_DEFAULT_PLATFORM_NAME_YES = $(PLATFORM_NAME);
-WK_DEFAULT_PLATFORM_NAME_NO = $(FALLBACK_PLATFORM);
+WK_DEFAULT_PLATFORM_NAME_ = $(FALLBACK_PLATFORM);
 
 WK_ALTERNATE_FRAMEWORKS_DIR = $(WK_ALTERNATE_FRAMEWORKS_DIR_$(SDK_VARIANT));
 WK_ALTERNATE_FRAMEWORKS_DIR_iosmac = /System/iOSSupport;
index 404557e..c1bc8da 100644 (file)
@@ -1,3 +1,27 @@
+2020-12-04  Adam Roben  <aroben@apple.com>
+
+        More FALLBACK_PLATFORM adoption
+        https://bugs.webkit.org/show_bug.cgi?id=219545
+
+        Reviewed by Tim Horton.
+
+        * DumpRenderTree/Scripts/check-xcfilelists.sh:
+        * TestWebKitAPI/Scripts/check-xcfilelists.sh:
+        * WebKitTestRunner/Scripts/check-xcfilelists.sh:
+        Use FALLBACK_PLATFORM if it's defined.
+
+        * ContentExtensionTester/Configurations/SDKVariant.xcconfig:
+        * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig:
+        * ImageDiff/cg/Configurations/SDKVariant.xcconfig:
+        * MiniBrowser/Configurations/SDKVariant.xcconfig:
+        * MobileMiniBrowser/Configurations/SDKVariant.xcconfig:
+        * TestWebKitAPI/Configurations/SDKVariant.xcconfig:
+        * WebEditingTester/Configurations/SDKVariant.xcconfig:
+        * WebKitTestRunner/Configurations/SDKVariant.xcconfig:
+        * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig:
+        WK_EMPTY_$(THIS_IS_NOT_EMPTY) evaluates to the empty string, not to
+        NO.
+
 2020-12-03  Alex Christensen  <achristensen@webkit.org>
 
         Introduce new download SPI
index 5540046..b4b37a9 100644 (file)
@@ -1,4 +1,4 @@
-// Copyright (C) 2019 Apple Inc. All rights reserved.
+// Copyright (C) 2019-2020 Apple Inc. All rights reserved.
 //
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions
@@ -27,7 +27,7 @@ WK_NOT_YES = NO;
 
 WK_DEFAULT_PLATFORM_NAME = $(WK_DEFAULT_PLATFORM_NAME_$(WK_EMPTY_$(FALLBACK_PLATFORM)));
 WK_DEFAULT_PLATFORM_NAME_YES = $(PLATFORM_NAME);
-WK_DEFAULT_PLATFORM_NAME_NO = $(FALLBACK_PLATFORM);
+WK_DEFAULT_PLATFORM_NAME_ = $(FALLBACK_PLATFORM);
 
 WK_ALTERNATE_FRAMEWORKS_DIR = $(WK_ALTERNATE_FRAMEWORKS_DIR_$(SDK_VARIANT));
 WK_ALTERNATE_FRAMEWORKS_DIR_iosmac = /System/iOSSupport;
index 234dfbb..3b5046f 100755 (executable)
@@ -9,4 +9,4 @@ SCRIPT="${BUILD_SCRIPTS_DIR}/generate-xcfilelists"
 [ -f "${SCRIPT}" ] || SCRIPT="${PROJECT_DIR}/../../Tools/Scripts/generate-xcfilelists"
 [ -f "${SCRIPT}" ] || { echo "### Cannot find generate-xcfilelists script"; exit 1; }
 
-"${SCRIPT}" generate-xcode --project DumpRenderTree --platform "${PLATFORM_NAME}" --configuration "${CONFIGURATION}"
+"${SCRIPT}" generate-xcode --project DumpRenderTree --platform "${FALLBACK_PLATFORM:-$PLATFORM_NAME}" --configuration "${CONFIGURATION}"
index 5540046..b4b37a9 100644 (file)
@@ -1,4 +1,4 @@
-// Copyright (C) 2019 Apple Inc. All rights reserved.
+// Copyright (C) 2019-2020 Apple Inc. All rights reserved.
 //
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions
@@ -27,7 +27,7 @@ WK_NOT_YES = NO;
 
 WK_DEFAULT_PLATFORM_NAME = $(WK_DEFAULT_PLATFORM_NAME_$(WK_EMPTY_$(FALLBACK_PLATFORM)));
 WK_DEFAULT_PLATFORM_NAME_YES = $(PLATFORM_NAME);
-WK_DEFAULT_PLATFORM_NAME_NO = $(FALLBACK_PLATFORM);
+WK_DEFAULT_PLATFORM_NAME_ = $(FALLBACK_PLATFORM);
 
 WK_ALTERNATE_FRAMEWORKS_DIR = $(WK_ALTERNATE_FRAMEWORKS_DIR_$(SDK_VARIANT));
 WK_ALTERNATE_FRAMEWORKS_DIR_iosmac = /System/iOSSupport;
index 5540046..b4b37a9 100644 (file)
@@ -1,4 +1,4 @@
-// Copyright (C) 2019 Apple Inc. All rights reserved.
+// Copyright (C) 2019-2020 Apple Inc. All rights reserved.
 //
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions
@@ -27,7 +27,7 @@ WK_NOT_YES = NO;
 
 WK_DEFAULT_PLATFORM_NAME = $(WK_DEFAULT_PLATFORM_NAME_$(WK_EMPTY_$(FALLBACK_PLATFORM)));
 WK_DEFAULT_PLATFORM_NAME_YES = $(PLATFORM_NAME);
-WK_DEFAULT_PLATFORM_NAME_NO = $(FALLBACK_PLATFORM);
+WK_DEFAULT_PLATFORM_NAME_ = $(FALLBACK_PLATFORM);
 
 WK_ALTERNATE_FRAMEWORKS_DIR = $(WK_ALTERNATE_FRAMEWORKS_DIR_$(SDK_VARIANT));
 WK_ALTERNATE_FRAMEWORKS_DIR_iosmac = /System/iOSSupport;
index 5540046..b4b37a9 100644 (file)
@@ -1,4 +1,4 @@
-// Copyright (C) 2019 Apple Inc. All rights reserved.
+// Copyright (C) 2019-2020 Apple Inc. All rights reserved.
 //
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions
@@ -27,7 +27,7 @@ WK_NOT_YES = NO;
 
 WK_DEFAULT_PLATFORM_NAME = $(WK_DEFAULT_PLATFORM_NAME_$(WK_EMPTY_$(FALLBACK_PLATFORM)));
 WK_DEFAULT_PLATFORM_NAME_YES = $(PLATFORM_NAME);
-WK_DEFAULT_PLATFORM_NAME_NO = $(FALLBACK_PLATFORM);
+WK_DEFAULT_PLATFORM_NAME_ = $(FALLBACK_PLATFORM);
 
 WK_ALTERNATE_FRAMEWORKS_DIR = $(WK_ALTERNATE_FRAMEWORKS_DIR_$(SDK_VARIANT));
 WK_ALTERNATE_FRAMEWORKS_DIR_iosmac = /System/iOSSupport;
index 5540046..b4b37a9 100644 (file)
@@ -1,4 +1,4 @@
-// Copyright (C) 2019 Apple Inc. All rights reserved.
+// Copyright (C) 2019-2020 Apple Inc. All rights reserved.
 //
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions
@@ -27,7 +27,7 @@ WK_NOT_YES = NO;
 
 WK_DEFAULT_PLATFORM_NAME = $(WK_DEFAULT_PLATFORM_NAME_$(WK_EMPTY_$(FALLBACK_PLATFORM)));
 WK_DEFAULT_PLATFORM_NAME_YES = $(PLATFORM_NAME);
-WK_DEFAULT_PLATFORM_NAME_NO = $(FALLBACK_PLATFORM);
+WK_DEFAULT_PLATFORM_NAME_ = $(FALLBACK_PLATFORM);
 
 WK_ALTERNATE_FRAMEWORKS_DIR = $(WK_ALTERNATE_FRAMEWORKS_DIR_$(SDK_VARIANT));
 WK_ALTERNATE_FRAMEWORKS_DIR_iosmac = /System/iOSSupport;
index 5540046..b4b37a9 100644 (file)
@@ -1,4 +1,4 @@
-// Copyright (C) 2019 Apple Inc. All rights reserved.
+// Copyright (C) 2019-2020 Apple Inc. All rights reserved.
 //
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions
@@ -27,7 +27,7 @@ WK_NOT_YES = NO;
 
 WK_DEFAULT_PLATFORM_NAME = $(WK_DEFAULT_PLATFORM_NAME_$(WK_EMPTY_$(FALLBACK_PLATFORM)));
 WK_DEFAULT_PLATFORM_NAME_YES = $(PLATFORM_NAME);
-WK_DEFAULT_PLATFORM_NAME_NO = $(FALLBACK_PLATFORM);
+WK_DEFAULT_PLATFORM_NAME_ = $(FALLBACK_PLATFORM);
 
 WK_ALTERNATE_FRAMEWORKS_DIR = $(WK_ALTERNATE_FRAMEWORKS_DIR_$(SDK_VARIANT));
 WK_ALTERNATE_FRAMEWORKS_DIR_iosmac = /System/iOSSupport;
index 959a30d..619609b 100755 (executable)
@@ -9,4 +9,4 @@ SCRIPT="${BUILD_SCRIPTS_DIR}/generate-xcfilelists"
 [ -f "${SCRIPT}" ] || SCRIPT="${PROJECT_DIR}/../../Tools/Scripts/generate-xcfilelists"
 [ -f "${SCRIPT}" ] || { echo "### Cannot find generate-xcfilelists script"; exit 1; }
 
-"${SCRIPT}" generate-xcode --project TestWebKitAPI --platform "${PLATFORM_NAME}" --configuration "${CONFIGURATION}"
+"${SCRIPT}" generate-xcode --project TestWebKitAPI --platform "${FALLBACK_PLATFORM:-$PLATFORM_NAME}" --configuration "${CONFIGURATION}"
index 5540046..b4b37a9 100644 (file)
@@ -1,4 +1,4 @@
-// Copyright (C) 2019 Apple Inc. All rights reserved.
+// Copyright (C) 2019-2020 Apple Inc. All rights reserved.
 //
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions
@@ -27,7 +27,7 @@ WK_NOT_YES = NO;
 
 WK_DEFAULT_PLATFORM_NAME = $(WK_DEFAULT_PLATFORM_NAME_$(WK_EMPTY_$(FALLBACK_PLATFORM)));
 WK_DEFAULT_PLATFORM_NAME_YES = $(PLATFORM_NAME);
-WK_DEFAULT_PLATFORM_NAME_NO = $(FALLBACK_PLATFORM);
+WK_DEFAULT_PLATFORM_NAME_ = $(FALLBACK_PLATFORM);
 
 WK_ALTERNATE_FRAMEWORKS_DIR = $(WK_ALTERNATE_FRAMEWORKS_DIR_$(SDK_VARIANT));
 WK_ALTERNATE_FRAMEWORKS_DIR_iosmac = /System/iOSSupport;
index 5540046..b4b37a9 100644 (file)
@@ -1,4 +1,4 @@
-// Copyright (C) 2019 Apple Inc. All rights reserved.
+// Copyright (C) 2019-2020 Apple Inc. All rights reserved.
 //
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions
@@ -27,7 +27,7 @@ WK_NOT_YES = NO;
 
 WK_DEFAULT_PLATFORM_NAME = $(WK_DEFAULT_PLATFORM_NAME_$(WK_EMPTY_$(FALLBACK_PLATFORM)));
 WK_DEFAULT_PLATFORM_NAME_YES = $(PLATFORM_NAME);
-WK_DEFAULT_PLATFORM_NAME_NO = $(FALLBACK_PLATFORM);
+WK_DEFAULT_PLATFORM_NAME_ = $(FALLBACK_PLATFORM);
 
 WK_ALTERNATE_FRAMEWORKS_DIR = $(WK_ALTERNATE_FRAMEWORKS_DIR_$(SDK_VARIANT));
 WK_ALTERNATE_FRAMEWORKS_DIR_iosmac = /System/iOSSupport;
index e5ecbb6..3415106 100755 (executable)
@@ -9,4 +9,4 @@ SCRIPT="${BUILD_SCRIPTS_DIR}/generate-xcfilelists"
 [ -f "${SCRIPT}" ] || SCRIPT="${PROJECT_DIR}/../../Tools/Scripts/generate-xcfilelists"
 [ -f "${SCRIPT}" ] || { echo "### Cannot find generate-xcfilelists script"; exit 1; }
 
-"${SCRIPT}" generate-xcode --project WebKitTestRunner --platform "${PLATFORM_NAME}" --configuration "${CONFIGURATION}"
+"${SCRIPT}" generate-xcode --project WebKitTestRunner --platform "${FALLBACK_PLATFORM:-$PLATFORM_NAME}" --configuration "${CONFIGURATION}"
index 5540046..b4b37a9 100644 (file)
@@ -1,4 +1,4 @@
-// Copyright (C) 2019 Apple Inc. All rights reserved.
+// Copyright (C) 2019-2020 Apple Inc. All rights reserved.
 //
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions
@@ -27,7 +27,7 @@ WK_NOT_YES = NO;
 
 WK_DEFAULT_PLATFORM_NAME = $(WK_DEFAULT_PLATFORM_NAME_$(WK_EMPTY_$(FALLBACK_PLATFORM)));
 WK_DEFAULT_PLATFORM_NAME_YES = $(PLATFORM_NAME);
-WK_DEFAULT_PLATFORM_NAME_NO = $(FALLBACK_PLATFORM);
+WK_DEFAULT_PLATFORM_NAME_ = $(FALLBACK_PLATFORM);
 
 WK_ALTERNATE_FRAMEWORKS_DIR = $(WK_ALTERNATE_FRAMEWORKS_DIR_$(SDK_VARIANT));
 WK_ALTERNATE_FRAMEWORKS_DIR_iosmac = /System/iOSSupport;