2006-09-17 Eric Seidel <eric@eseidel.com>
authoreseidel <eseidel@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 18 Sep 2006 06:45:54 +0000 (06:45 +0000)
committereseidel <eseidel@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 18 Sep 2006 06:45:54 +0000 (06:45 +0000)
        Reviewed by ap.

        REGRESSION (r16245): double-clicking on javascript exceptions fails to show source
        http://bugzilla.opendarwin.org/show_bug.cgi?id=10813

        * bridge/mac/WebCoreFrameBridge.mm:
        (+[WebCoreFrameBridge stringWithData:textEncodingName:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebCore/ChangeLog
WebCore/bridge/mac/WebCoreFrameBridge.mm

index 85663bbb089764d96c9f7018825ee989d7597b2c..108f05764f40f348e1380f6011c263064da4f261 100644 (file)
@@ -1,3 +1,13 @@
+2006-09-17  Eric Seidel  <eric@eseidel.com>
+
+        Reviewed by ap.
+        
+        REGRESSION (r16245): double-clicking on javascript exceptions fails to show source
+        http://bugzilla.opendarwin.org/show_bug.cgi?id=10813
+
+        * bridge/mac/WebCoreFrameBridge.mm:
+        (+[WebCoreFrameBridge stringWithData:textEncodingName:]):
+
 2006-09-17  Alexey Proskuryakov  <ap@nypop.com>
 
         Reviewed by Hyatt.
index 6d2b8a0b0f23a6c5c79868e4406cc3555311756b..f5b71895dda2b850e8bf75ed9070504990fde773 100644 (file)
@@ -1488,7 +1488,8 @@ static HTMLFormElement *formElementFromDOMElement(DOMElement *element)
 
 + (NSString *)stringWithData:(NSData *)data textEncodingName:(NSString *)textEncodingName
 {
-    return WebCore::TextEncoding(textEncodingName).decode(reinterpret_cast<const char*>([data bytes]), [data length]);
+    NSString* name = textEncodingName ? textEncodingName : @"iso-8859-1";
+    return WebCore::TextEncoding(name).decode(reinterpret_cast<const char*>([data bytes]), [data length]);
 }
 
 - (BOOL)needsLayout