- fix <rdar://problem/
5596160> fast/events/objc-event-api.html fails when run alone (or first)
* WebView/WebHTMLView.mm:
(-[WebHTMLView setDataSource:]): This method calls addMouseMovedObserver
because addMouseMovedObserver returns early if the dataSource
is not nil. But if the dataSource is already set (which happens when
a WebHTMLView is being reused) then addMouseMovedObserver must not
be called again.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28104
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
+2007-11-28 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Maciej Stachowiak.
+
+ - fix <rdar://problem/5596160> fast/events/objc-event-api.html fails when run alone (or first)
+
+ * WebView/WebHTMLView.mm:
+ (-[WebHTMLView setDataSource:]): This method calls addMouseMovedObserver
+ because addMouseMovedObserver returns early if the dataSource
+ is not nil. But if the dataSource is already set (which happens when
+ a WebHTMLView is being reused) then addMouseMovedObserver must not
+ be called again.
+
2007-11-27 Anders Carlsson <andersca@apple.com>
Reviewed by Brady.
ASSERT(dataSource);
if (_private->dataSource != dataSource) {
ASSERT(!_private->closed);
+ BOOL hadDataSource = _private->dataSource != nil;
+
[dataSource retain];
[_private->dataSource release];
_private->dataSource = dataSource;
[_private->pluginController setDataSource:dataSource];
- [self addMouseMovedObserver];
+
+ if (!hadDataSource)
+ [self addMouseMovedObserver];
}
}