1 crash in WebProcess at com.apple.WebKit2:
WebKit::WebPage::didChangeScrollOffsetForMainFrame + 31
Reviewed by Adele Peterson.
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::didChangeScrollOffset):
Add null check for the FrameView. This function can be called when the
FrameView is being torn down during a transition to a new FrameView.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didChangeScrollOffsetForMainFrame):
Revert last attempt.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79064
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
+2011-02-18 Sam Weinig <sam@webkit.org>
+
+ Reviewed by Adele Peterson.
+
+ Real fix for <rdar://problem/9025723> CrashTracer: [USER]
+ 1 crash in WebProcess at com.apple.WebKit2:
+ WebKit::WebPage::didChangeScrollOffsetForMainFrame + 31
+
+ * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
+ (WebKit::WebFrameLoaderClient::didChangeScrollOffset):
+ Add null check for the FrameView. This function can be called when the
+ FrameView is being torn down during a transition to a new FrameView.
+
+ * WebProcess/WebPage/WebPage.cpp:
+ (WebKit::WebPage::didChangeScrollOffsetForMainFrame):
+ Revert last attempt.
+
2011-02-18 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
if (!m_frame->isMainFrame())
return;
+ // If this is called when tearing down a FrameView, the WebCore::Frame's
+ // current FrameView will be null.
+ if (!m_frame->coreFrame()->view())
+ return;
+
webPage->didChangeScrollOffsetForMainFrame();
}
void WebPage::didChangeScrollOffsetForMainFrame()
{
Frame* frame = m_page->mainFrame();
- if (!frame)
- return;
-
IntPoint scrollPosition = frame->view()->scrollPosition();
IntPoint maximumScrollPosition = frame->view()->maximumScrollPosition();