Fix bug in HTML5 Fullscreen API implementation that was preventing YouTube HTML5...
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 27 Feb 2013 18:19:04 +0000 (18:19 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 27 Feb 2013 18:19:04 +0000 (18:19 +0000)
https://bugs.webkit.org/show_bug.cgi?id=110905

Patch by John Griggs <jgriggs@rim.com> on 2013-02-27
Reviewed by Yong Li.

Return true from ChromeClientBlackBerry::supportsFullScreenForElement instead of the negation of the boolean flag (withKeyboard) passed in.

* WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore::ChromeClientBlackBerry::supportsFullScreenForElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144209 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebKit/blackberry/ChangeLog
Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp

index 0a36a26..bcd936f 100644 (file)
@@ -1,3 +1,17 @@
+2013-02-27  John Griggs  <jgriggs@rim.com>
+
+        2013-02-27  John Griggs  <jgriggs@rim.com>
+
+        Fix bug in HTML5 Fullscreen API implementation that was preventing YouTube HTML5 media controls fullscreen button from working properly.
+        https://bugs.webkit.org/show_bug.cgi?id=110905
+
+        Reviewed by Yong Li.
+
+        Return true from ChromeClientBlackBerry::supportsFullScreenForElement instead of the negation of the boolean flag (withKeyboard) passed in.
+
+        * WebCoreSupport/ChromeClientBlackBerry.cpp:
+        (WebCore::ChromeClientBlackBerry::supportsFullScreenForElement):
+
 2013-02-27  Sean Wang  <Xuewen.Wang@torchmobile.com.cn>
 
         [BlackBerry] Context menu cannot be invoked after doing text selection in landscape mode
index 072a423..40e157e 100644 (file)
@@ -740,9 +740,9 @@ void ChromeClientBlackBerry::exitFullscreenForNode(Node* node)
 }
 
 #if ENABLE(FULLSCREEN_API)
-bool ChromeClientBlackBerry::supportsFullScreenForElement(const WebCore::Element* element, bool withKeyboard)
+bool ChromeClientBlackBerry::supportsFullScreenForElement(const WebCore::Element*, bool)
 {
-    return !withKeyboard;
+    return true;
 }
 
 void ChromeClientBlackBerry::enterFullScreenForElement(WebCore::Element* element)