Move commits viewer to the end of details view

https://bugs.webkit.org/show_bug.cgi?id=141315

Rubber-stamped by Andreas Kling.

Show the difference instead of the old value per kling's request.

* public/v2/app.js:
(App.PaneController._updateDetails):
* public/v2/index.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@179731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/Websites/perf.webkit.org/ChangeLog b/Websites/perf.webkit.org/ChangeLog
index f2ac8c00eab126e9a922d5bf36a1ef2b039cc4e5..eb9a7d2551328fd2537f395ae921175e61bff017 100644 (file)
--- a/Websites/perf.webkit.org/ChangeLog
+++ b/Websites/perf.webkit.org/ChangeLog
@@ -1,3 +1,16 @@
+2015-02-05  Ryosuke Niwa  <rniwa@webkit.org>
+
+        Move commits viewer to the end of details view
+        https://bugs.webkit.org/show_bug.cgi?id=141315
+
+        Rubber-stamped by Andreas Kling.
+
+        Show the difference instead of the old value per kling's request.
+
+        * public/v2/app.js:
+        (App.PaneController._updateDetails):
+        * public/v2/index.html:
+
 2015-02-05  Ryosuke Niwa  <rniwa@webkit.org>
 
         Move commits viewer to the end of details view

diff --git a/Websites/perf.webkit.org/public/v2/app.js b/Websites/perf.webkit.org/public/v2/app.js
index 788ac4598f674ef2fd1fb9053d926b15ade278e3..ec459e07368d8b2f031ea80df925c2a165180eb9 100755 (executable)
--- a/Websites/perf.webkit.org/public/v2/app.js
+++ b/Websites/perf.webkit.org/public/v2/app.js
@@ -763,10 +763,14 @@ App.PaneController = Ember.ObjectController.extend({
         }
 
         var chartData = this.get('chartData');
+        var valueDiff = oldMeasurement ? chartData.formatter(currentMeasurement.mean() - oldMeasurement.mean()) : null;
+        if (valueDiff && valueDiff > 0)
+            valueDiff = '+' + valueDiff;
+
         this.set('details', Ember.Object.create({
             status: this._computeStatus(currentPoint),
             currentValue: chartData.formatter(currentMeasurement.mean()),
-            oldValue: oldMeasurement ? chartData.formatter(oldMeasurement.mean()) : null,
+            valueDiff: valueDiff,
             buildNumber: buildNumber,
             buildURL: buildURL,
             buildTime: currentMeasurement.formattedBuildTime(),

diff --git a/Websites/perf.webkit.org/public/v2/index.html b/Websites/perf.webkit.org/public/v2/index.html
index 508e18d0f49b4d91a184781467d3917328cb7176..6daddce4b6b0cb6458a325dcf07dbbe0aea7ca52 100755 (executable)
--- a/Websites/perf.webkit.org/public/v2/index.html
+++ b/Websites/perf.webkit.org/public/v2/index.html
@@ -259,8 +259,8 @@
                     <th>Current</th>
                     <td>
                         {{details.currentValue}} {{chartData.unit}}
-                        {{#if details.oldValue}}
-                            (from {{details.oldValue}} {{chartData.unit}})
+                        {{#if details.valueDiff}}
+                            ({{details.valueDiff}} {{chartData.unit}})
                         {{/if}}
                         {{#if details.status.label}}
                             <br>