[BlackBerry] Reader Mode: Opening two links quickly from reader mode causes browser...
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 7 Feb 2013 15:08:22 +0000 (15:08 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 7 Feb 2013 15:08:22 +0000 (15:08 +0000)
https://bugs.webkit.org/show_bug.cgi?id=109124

Patch by Sean Wang <Xuewen.Wang@torchmobile.com.cn> on 2013-02-07
Reviewed by Yong Li.

RIM BUG 291246 Internally reviewed by YongLi.
Move the WebPageGroupLoadDeferrer object from ChromeClientBlackBerry::createWindow()
into WebPageClientImpl::createWindow() to make it more close to its protecting place.

* WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore::ChromeClientBlackBerry::createWindow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142117 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebKit/blackberry/ChangeLog
Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp

index 3c405b651c910caf656241d957d5fcf7fc7bf3a1..fb63314ad6b01cc813064f3004a99d43d44edb75 100644 (file)
@@ -1,3 +1,17 @@
+2013-02-07  Sean Wang  <Xuewen.Wang@torchmobile.com.cn>
+
+        [BlackBerry] Reader Mode: Opening two links quickly from reader mode causes browser bad state
+        https://bugs.webkit.org/show_bug.cgi?id=109124
+
+        Reviewed by Yong Li.
+
+        RIM BUG 291246 Internally reviewed by YongLi.
+        Move the WebPageGroupLoadDeferrer object from ChromeClientBlackBerry::createWindow()
+        into WebPageClientImpl::createWindow() to make it more close to its protecting place.
+
+        * WebCoreSupport/ChromeClientBlackBerry.cpp:
+        (WebCore::ChromeClientBlackBerry::createWindow):
+
 2013-02-07  Mike Fenton  <mifenton@rim.com>
 
         [BlackBerry] Send type details with IMF mask as part of focus gained.
index 10847e2f46b4bc30b2e3545cbede4aa59c696351..720cc6ee450404d57fd099d17ad4e17a77d5aaa1 100644 (file)
@@ -236,9 +236,6 @@ Page* ChromeClientBlackBerry::createWindow(Frame* frame, const FrameLoadRequest&
         return 0;
 #endif
 
-    PageGroupLoadDeferrer deferrer(m_webPagePrivate->m_page, true);
-    TimerBase::fireTimersInNestedEventLoop();
-
     int x = features.xSet ? features.x : 0;
     int y = features.ySet ? features.y : 0;
     int width = features.widthSet? features.width : -1;