Fixed <rdar://problem/3952084> REGRESSION: Links at projectseven.com now draw and...

	Turn off use of new CGContextStrokeLineSegments API.  We should
	turn back on when 3952944 is fixed.

        Reviewed by Darin.

        * WebCoreSupport.subproj/WebTextRenderer.m:
        (-[WebTextRenderer drawLineForCharacters:yOffset:width:color:thickness:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@8364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebKit/ChangeLog b/WebKit/ChangeLog
index 7bbed823de290538770ab9d72a4bfc85940ddf41..2db196145962dd1ed9cd49118be223af57d7b45e 100644 (file)
--- a/WebKit/ChangeLog
+++ b/WebKit/ChangeLog
@@ -1,3 +1,15 @@
+2005-01-13  Richard Williamson   <rjw@apple.com>
+
+       Fixed <rdar://problem/3952084> REGRESSION: Links at projectseven.com now draw and update incorrectly during hover
+
+       Turn off use of new CGContextStrokeLineSegments API.  We should
+       turn back on when 3952944 is fixed.
+
+        Reviewed by Darin.
+
+        * WebCoreSupport.subproj/WebTextRenderer.m:
+        (-[WebTextRenderer drawLineForCharacters:yOffset:width:color:thickness:]):
+
 2005-01-13  Chris Blumenberg  <cblu@apple.com>
 
        Fixed: <rdar://problem/3937663> repro assertion failure and crash dragging image that has PDF source

diff --git a/WebKit/WebCoreSupport.subproj/WebTextRenderer.m b/WebKit/WebCoreSupport.subproj/WebTextRenderer.m
index 170f593e5b2505317517aaf48461b54c358e8ff4..6670ef3c8441f61b53863d128fad79c969d94b34 100644 (file)
--- a/WebKit/WebCoreSupport.subproj/WebTextRenderer.m
+++ b/WebKit/WebCoreSupport.subproj/WebTextRenderer.m
@@ -572,7 +572,10 @@ static BOOL alwaysUseATSU = NO;
     }
 
 
-#if BUILDING_ON_PANTHER            
+    // With Q2DX turned on CGContextStrokeLineSegments sometimes fails to draw lines.  See 3952084.
+    // So, it has been requested that we turn off use of the new API until 3952084 is fixed.
+#if 1         
+//#if BUILDING_ON_PANTHER         
     CGContextMoveToPoint(cgContext, point.x, point.y + [self lineSpacing] + 1.5 - [self descent] + yOffset);
     // Subtract 1 to ensure that the line is always within bounds of element.
     CGContextAddLineToPoint(cgContext, point.x + width - 1.0, point.y + [self lineSpacing] + 1.5 - [self descent] + yOffset);