2010-07-27 Steve Block <steveblock@google.com>
authorsteveblock@google.com <steveblock@google.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 27 Jul 2010 13:55:51 +0000 (13:55 +0000)
committersteveblock@google.com <steveblock@google.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 27 Jul 2010 13:55:51 +0000 (13:55 +0000)
        Reviewed by Jeremy Orlow.

        LayoutTests/fast/dom/DeviceOrientation/window-property.html assumes use of V8
        https://bugs.webkit.org/show_bug.cgi?id=43025

        This change modifies window-property.html and its expected result to work with JSC.
        A V8-specific expected result is added for Android.

        * fast/dom/DeviceOrientation/script-tests/window-property.js:
        * fast/dom/DeviceOrientation/window-property-expected.txt:
        * platform/android-v8: Added.
        * platform/android-v8/fast: Added.
        * platform/android-v8/fast/dom: Added.
        * platform/android-v8/fast/dom/DeviceOrientation: Added.
        * platform/android-v8/fast/dom/DeviceOrientation/window-property-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64125 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/fast/dom/DeviceOrientation/script-tests/window-property.js
LayoutTests/fast/dom/DeviceOrientation/window-property-expected.txt
LayoutTests/platform/android-v8/fast/dom/DeviceOrientation/window-property-expected.txt [new file with mode: 0644]

index 9946bd4f9e1b6edc001a21574318865610ab5da0..23ee90c0e7b93eb698762ddb03de0c05ce4076af 100644 (file)
@@ -1,3 +1,21 @@
+2010-07-27  Steve Block  <steveblock@google.com>
+
+        Reviewed by Jeremy Orlow.
+
+        LayoutTests/fast/dom/DeviceOrientation/window-property.html assumes use of V8
+        https://bugs.webkit.org/show_bug.cgi?id=43025
+
+        This change modifies window-property.html and its expected result to work with JSC.
+        A V8-specific expected result is added for Android.
+
+        * fast/dom/DeviceOrientation/script-tests/window-property.js:
+        * fast/dom/DeviceOrientation/window-property-expected.txt:
+        * platform/android-v8: Added.
+        * platform/android-v8/fast: Added.
+        * platform/android-v8/fast/dom: Added.
+        * platform/android-v8/fast/dom/DeviceOrientation: Added.
+        * platform/android-v8/fast/dom/DeviceOrientation/window-property-expected.txt: Added.
+
 2010-07-27  Anton Muhin  <antonm@chromium.org>
 
         Reviewed by Darin Adler.
 2010-07-27  Anton Muhin  <antonm@chromium.org>
 
         Reviewed by Darin Adler.
index e7458b46221f1cf37c05d7eaf597e6f534058ca6..8e6505966fab649fcd91c80aca27a4af9b6a0135 100644 (file)
@@ -9,7 +9,8 @@ function hasDeviceOrientationEventProperty()
     return false;
 }
 
     return false;
 }
 
-shouldBeTrue("typeof window.DeviceOrientationEvent == 'function'");
+shouldBeTrue("typeof window.DeviceOrientationEvent == 'object'");
+shouldBeFalse("typeof window.DeviceOrientationEvent == 'function'");
 shouldBeTrue("hasDeviceOrientationEventProperty()");
 shouldBeTrue("'DeviceOrientationEvent' in window");
 shouldBeTrue("window.hasOwnProperty('DeviceOrientationEvent')");
 shouldBeTrue("hasDeviceOrientationEventProperty()");
 shouldBeTrue("'DeviceOrientationEvent' in window");
 shouldBeTrue("window.hasOwnProperty('DeviceOrientationEvent')");
@@ -26,6 +27,6 @@ function hasOnDeviceOrientationProperty()
 shouldBeTrue("typeof window.ondeviceorientation == 'object'");
 shouldBeTrue("hasOnDeviceOrientationProperty()");
 shouldBeTrue("'ondeviceorientation' in window");
 shouldBeTrue("typeof window.ondeviceorientation == 'object'");
 shouldBeTrue("hasOnDeviceOrientationProperty()");
 shouldBeTrue("'ondeviceorientation' in window");
-shouldBeFalse("window.hasOwnProperty('ondeviceorientation')");
+shouldBeTrue("window.hasOwnProperty('ondeviceorientation')");
 
 window.successfullyParsed = true;
 
 window.successfullyParsed = true;
index 95075a0443ad9109c7cbdc243f6ce935ff11b863..308ab7ac6d1fc24965dcbee74ee93213ec2827e4 100644 (file)
@@ -3,14 +3,15 @@ Tests that the window.DeviceOrientationEvent and window.ondeviceorientation prop
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
 
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
 
-PASS typeof window.DeviceOrientationEvent == 'function' is true
+PASS typeof window.DeviceOrientationEvent == 'object' is true
+PASS typeof window.DeviceOrientationEvent == 'function' is false
 PASS hasDeviceOrientationEventProperty() is true
 PASS 'DeviceOrientationEvent' in window is true
 PASS window.hasOwnProperty('DeviceOrientationEvent') is true
 PASS typeof window.ondeviceorientation == 'object' is true
 PASS hasOnDeviceOrientationProperty() is true
 PASS 'ondeviceorientation' in window is true
 PASS hasDeviceOrientationEventProperty() is true
 PASS 'DeviceOrientationEvent' in window is true
 PASS window.hasOwnProperty('DeviceOrientationEvent') is true
 PASS typeof window.ondeviceorientation == 'object' is true
 PASS hasOnDeviceOrientationProperty() is true
 PASS 'ondeviceorientation' in window is true
-PASS window.hasOwnProperty('ondeviceorientation') is false
+PASS window.hasOwnProperty('ondeviceorientation') is true
 PASS successfullyParsed is true
 
 TEST COMPLETE
 PASS successfullyParsed is true
 
 TEST COMPLETE
diff --git a/LayoutTests/platform/android-v8/fast/dom/DeviceOrientation/window-property-expected.txt b/LayoutTests/platform/android-v8/fast/dom/DeviceOrientation/window-property-expected.txt
new file mode 100644 (file)
index 0000000..900c9ca
--- /dev/null
@@ -0,0 +1,18 @@
+Tests that the window.DeviceOrientationEvent and window.ondeviceorientation properties are present.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+FAIL typeof window.DeviceOrientationEvent == 'object' should be true. Was false.
+FAIL typeof window.DeviceOrientationEvent == 'function' should be false. Was true.
+PASS hasDeviceOrientationEventProperty() is true
+PASS 'DeviceOrientationEvent' in window is true
+PASS window.hasOwnProperty('DeviceOrientationEvent') is true
+PASS typeof window.ondeviceorientation == 'object' is true
+PASS hasOnDeviceOrientationProperty() is true
+PASS 'ondeviceorientation' in window is true
+FAIL window.hasOwnProperty('ondeviceorientation') should be true. Was false.
+PASS successfullyParsed is true
+
+TEST COMPLETE
+