git://git.webkit.org / WebKit-https.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: f47a3b6)
Update speedometer patch to provide better UI, fix merge result bug and add "Score...
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 1 May 2015 19:42:35 +0000 (19:42 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 1 May 2015 19:42:35 +0000 (19:42 +0000)
https://bugs.webkit.org/show_bug.cgi?id=144487

Patch by Dewei Zhu <dewei_zhu@apple.com> on 2015-05-01
Reviewed by Ryosuke Niwa.

* Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
(BenchmarkRunner.merge): Fix bug.
* Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch: Update appearance and add "Score" metric.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@183685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

PerformanceTests/Speedometer/resources/main.js patch | blob | history
Tools/ChangeLog patch | blob | history
Tools/Scripts/webkitpy/benchmark_runner/benchmark_runner.py patch | blob | history
Tools/Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch patch | blob | history

diff --git a/PerformanceTests/Speedometer/resources/main.js b/PerformanceTests/Speedometer/resources/main.js
index 887febbf98676dc164d15968e475ff21cc463c67..535f5fb8568109095c59c86f020f6fcf4daab4da 100644 (file)
--- a/PerformanceTests/Speedometer/resources/main.js
+++ b/PerformanceTests/Speedometer/resources/main.js
@@ -52,7 +52,7 @@ window.benchmarkClient = {
         function totalTimeInDisplayUnit(time) {
             if (displayUnit == 'ms')
                 return time;
-            return 60 * 1000 * suitesCount / time;
+            return computerScore(time);
         }
 
         function sigFigFromPercentDelta(percentDelta) {
@@ -158,6 +158,10 @@ function startBenchmark() {
     runner.runMultipleIterations(benchmarkClient.iterationCount);
 }
 
+function computeScore(time) {
+    return 60 * 1000 * benchmarkClient.suitesCount / time;
+}
+
 function showSection(sectionIdentifier, pushState) {
     var currentSectionElement = document.querySelector('section.selected');
     console.assert(currentSectionElement);
diff --git a/Tools/ChangeLog b/Tools/ChangeLog
index dddd42b63abca7540daead7cbc88d310983583fe..bb9710f9df9f67d68c8ea4f8c9978e0d3f78646d 100644 (file)
--- a/Tools/ChangeLog
+++ b/Tools/ChangeLog
@@ -1,3 +1,14 @@
+2015-05-01  Dewei Zhu  <dewei_zhu@apple.com>
+
+        Update speedometer patch to provide better UI, fix merge result bug and add "Score" metric to speedometer benchmark.
+        https://bugs.webkit.org/show_bug.cgi?id=144487
+
+        Reviewed by Ryosuke Niwa.
+
+        * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
+        (BenchmarkRunner.merge): Fix bug.
+        * Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch: Update appearance and add "Score" metric.
+
 2015-05-01  Brady Eidson  <beidson@apple.com>
 
         Add API to disable meta refreshes.
diff --git a/Tools/Scripts/webkitpy/benchmark_runner/benchmark_runner.py b/Tools/Scripts/webkitpy/benchmark_runner/benchmark_runner.py
index 84350cf850e71875fe77d81d69785fa0f2390856..bafbb7a0b2949a92d96e67af42c735ddfedfc0f0 100644 (file)
--- a/Tools/Scripts/webkitpy/benchmark_runner/benchmark_runner.py
+++ b/Tools/Scripts/webkitpy/benchmark_runner/benchmark_runner.py
@@ -96,9 +96,7 @@ class BenchmarkRunner(object):
         assert(isinstance(a, type(b)))
         argType = type(a)
         # special handle for list type, and should be handle before equal check
-        if argType == types.ListType:
-            return a + b
-        if a == b:
+        if argType == types.ListType and len(a) and (type(a[0]) == types.StringType or type(a[0]) == types.UnicodeType):
             return a
         if argType == types.DictType:
             result = {}
diff --git a/Tools/Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch b/Tools/Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch
index 33b0f32e1eb3244bc00448452b4f57d08293059f..f4092d59fe606af175d839206a2e9d45d63bb91b 100644 (file)
--- a/Tools/Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch
+++ b/Tools/Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch
@@ -11,10 +11,10 @@ index 419b9f2..0b04c69 100644
  </head>
  <body>
 diff --git a/Speedometer/resources/benchmark-report.js b/Speedometer/resources/benchmark-report.js
-index c4b4c64..c4453cd 100644
+index c4b4c64..874f597 100644
 --- a/Speedometer/resources/benchmark-report.js
 +++ b/Speedometer/resources/benchmark-report.js
-@@ -1,16 +1,9 @@
+@@ -1,30 +1,26 @@
  // This file can be customized to report results as needed.
  
  (function () {
@@ -28,10 +28,32 @@ index c4b4c64..c4453cd 100644
 -    scriptElement.src = '../resources/runner.js';
 -    document.head.appendChild(scriptElement);
 -
-     var styleElement = document.createElement('style');
-     styleElement.textContent = 'pre { padding-top: 600px; }';
-     document.head.appendChild(styleElement);
-@@ -36,10 +29,8 @@
+-    var styleElement = document.createElement('style');
+-    styleElement.textContent = 'pre { padding-top: 600px; }';
+-    document.head.appendChild(styleElement);
+-
++    showSection('running')
+     var createTest;
+     var valuesByIteration = new Array;
++    var timeValues = new Array;
+ 
+     window.onload = function () {
+-        document.body.removeChild(document.querySelector('main'));
+         startBenchmark();
+     }
+ 
+     window.benchmarkClient = {
+         iterationCount: 5, // Use 4 different instances of DRT/WTR to run 5 iterations.
++        willAddTestFrame: function (frame) {
++            var main = document.querySelector('main');
++            var style = getComputedStyle(main);
++            frame.style.left = main.offsetLeft + parseInt(style.borderLeftWidth) + parseInt(style.paddingLeft) + 'px';
++            frame.style.top = main.offsetTop + parseInt(style.borderTopWidth) + parseInt(style.paddingTop) + 'px';
++        },
+         willStartFirstIteration: function (iterationCount) {
+             createTest = function (name, aggregator, isLastTest) {
+                 return {
+@@ -36,15 +32,12 @@
                      name: name,
                      aggregator: aggregator};
              }
@@ -40,22 +62,28 @@ index c4b4c64..c4453cd 100644
          didRunSuites: function (measuredValues) {
 -            PerfTestRunner.measureValueAsync(measuredValues.total);
              valuesByIteration.push(measuredValues.tests);
++            timeValues.push(measuredValues.total);
          },
          didFinishLastIteration: function () {
-@@ -52,19 +43,30 @@
+-            document.head.removeChild(document.querySelector('style'));
+-
+             var measuredValuesByFullName = {};
+             function addToMeasuredValue(value, fullName, aggregator) {
+                 var values = measuredValuesByFullName[fullName] || new Array;
+@@ -52,19 +45,30 @@
                  values.push(value);
                  values.aggregator = aggregator;
              }
 -
 +            var dict = {}
++            var scores= timeValues.map(computeScore);
 +            function addToDictionaryValue(value, suiteName, testName, subtestName) {
-+                dict["Speedometer"] = dict["Speedometer"] || { "metrics" : { "Time" : [ "Total", ] }, "tests" : {}};
++                dict["Speedometer"] = dict["Speedometer"] || { "metrics" : { "Time" : [ "Total", ], "Score": { "current" : [scores] } }, "tests" : {}};
 +                dict["Speedometer"]["tests"][suiteName] = dict["Speedometer"]["tests"][suiteName] || {"metrics" : { "Time" : [ "Total", ] }, "tests" : {}};
 +                dict["Speedometer"]["tests"][suiteName]["tests"][testName] = dict["Speedometer"]["tests"][suiteName]["tests"][testName] || { "metrics" : { "Time" : [ "Total", ] }, "tests" : {}};
 +                dict["Speedometer"]["tests"][suiteName]["tests"][testName]["tests"][subtestName] = dict["Speedometer"]["tests"][suiteName]["tests"][testName]["tests"][subtestName] || { "metrics" : { "Time" : { "current" : [[]] } }};
 +                dict["Speedometer"]["tests"][suiteName]["tests"][testName]["tests"][subtestName]["metrics"]["Time"]["current"][0].push(value);
 +            }
-+            
              valuesByIteration.forEach(function (measuredValues) {
                  for (var suiteName in measuredValues) {
                      var suite = measuredValues[suiteName];
@@ -75,7 +103,7 @@ index c4b4c64..c4453cd 100644
  
              var fullNames = new Array;
              for (var fullName in measuredValuesByFullName)
-@@ -72,8 +74,22 @@
+@@ -72,8 +76,22 @@
  
              for (var i = 0; i < fullNames.length; i++) {
                  var values = measuredValuesByFullName[fullNames[i]];
@@ -83,11 +111,11 @@ index c4b4c64..c4453cd 100644
              }
 +            var xhr = new XMLHttpRequest();
 +            xhr.open("POST", "/report");
-+ 
++
 +            xhr.setRequestHeader("Content-type", "application/json");
 +            xhr.setRequestHeader("Content-length", results.length);
 +            xhr.setRequestHeader("Connection", "close");
-+ 
++
 +            xhr.onreadystatechange = function() {
 +                if(xhr.readyState == XMLHttpRequest.DONE && xhr.status == 200) {
 +                    var closeRequest = new XMLHttpRequest();
Mirror of the WebKit open source project from svn.webkit.org.