Reviewed by Anders.

        * DumpRenderTree/DumpRenderTree.m: (main): Turn on pop-up blocking so that
        we can test it in layout tests. We don't really need tests that run with
        pop-up blocking off at the moment. If we do some day, we can add some
        API for turning it off in the layout test controller.

        * Scripts/run-webkit-tests: Since we don't use NSLanguage at all any more,
        don't ignore the leak; it should no longer show up.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebKitTools/ChangeLog b/WebKitTools/ChangeLog
index c754f523d9409ef436f82d64c5b01e4b43ac83bf..7b0e7111ea299b7706ddd31fe239a73fefed4fc1 100644 (file)
--- a/WebKitTools/ChangeLog
+++ b/WebKitTools/ChangeLog
@@ -1,3 +1,15 @@
+2006-03-19  Darin Adler  <darin@apple.com>
+
+        Reviewed by Anders.
+
+        * DumpRenderTree/DumpRenderTree.m: (main): Turn on pop-up blocking so that
+        we can test it in layout tests. We don't really need tests that run with
+        pop-up blocking off at the moment. If we do some day, we can add some
+        API for turning it off in the layout test controller.
+
+        * Scripts/run-webkit-tests: Since we don't use NSLanguage at all any more,
+        don't ignore the leak; it should no longer show up.
+
 2006-03-17  Anders Carlsson  <andersca@mac.com>
 
         Reviewed by Eric.

diff --git a/WebKitTools/DumpRenderTree/DumpRenderTree.m b/WebKitTools/DumpRenderTree/DumpRenderTree.m
index 68fb7ae4248df008878de54812d35dfe98506a94..fab0d9215e011ea1753d2c077b9071c3732877ae 100644 (file)
--- a/WebKitTools/DumpRenderTree/DumpRenderTree.m
+++ b/WebKitTools/DumpRenderTree/DumpRenderTree.m
@@ -208,6 +208,7 @@ int main(int argc, const char *argv[])
     [preferences setDefaultFixedFontSize:13];
     [preferences setMinimumFontSize:9];
     [preferences setJavaEnabled:NO];
+    [preferences setJavaScriptCanOpenWindowsAutomatically:NO];
 
     int option;
     while ((option = getopt_long(argc, (char * const *)argv, "", options, NULL)) != -1)

diff --git a/WebKitTools/Scripts/run-webkit-tests b/WebKitTools/Scripts/run-webkit-tests
index d3903ccbddb05e0a5a381161c4efe8083e0d1ff2..82da69084635e8a9ab39b475442049d3198e66da 100755 (executable)
--- a/WebKitTools/Scripts/run-webkit-tests
+++ b/WebKitTools/Scripts/run-webkit-tests
@@ -700,14 +700,13 @@ sub countAndPrintLeaks
     my @exclude = (
         "pthread_create", # false positive leak of 'THRD', Radar 3387783
         "_CFPreferencesDomainDeepCopyDictionary", # leak apparently in CFPreferences, Radar 4220786
-        "+[NSLanguage initialize]", # leak apparently in NSLanguage, Radar 3986177
         "FOGetCoveredUnicodeChars", # leak apparently in ATS, Radar 3943604
         "PCFragPrepareClosureFromFile", # leak in Code Fragment Manager, Radar 3426998
         "Flash_EnforceLocalSecurity", # leaks in flash plugin code, Radar 4449747
         "ICCFPrefWrapper::GetPrefDictionary()" # leaks in quicktime plugin code, Radar 4449794
     );
 
-    # Note that this exclusion doesn't quite work right; sometimes a leak of 'THRD' with no stack trace will
+    # Note that the exclusion for bug 3387783 doesn't quite work right; sometimes a leak of 'THRD' will
     # still appear in the leaks output.
 
     my $excludes = "-exclude '" . (join "' -exclude '", @exclude) . "'";