[Microdata] HTMLPropertiesCollection code cleanup
authorarko@motorola.com <arko@motorola.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 13 Feb 2013 21:33:18 +0000 (21:33 +0000)
committerarko@motorola.com <arko@motorola.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 13 Feb 2013 21:33:18 +0000 (21:33 +0000)
https://bugs.webkit.org/show_bug.cgi?id=109721

Reviewed by Ryosuke Niwa.

Removed forward declaration of DOMStringList class.
Removed unused findRefElements() method declaration.
Also Removed unused parameter Element* from updatePropertyCache() method.

No new test since no change in behavior.

* html/HTMLPropertiesCollection.cpp:
(WebCore::HTMLPropertiesCollection::updateNameCache):
* html/HTMLPropertiesCollection.h:
(WebCore):
(HTMLPropertiesCollection):
(WebCore::HTMLPropertiesCollection::updatePropertyCache):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/html/HTMLPropertiesCollection.cpp
Source/WebCore/html/HTMLPropertiesCollection.h

index 3e6c92cd905d19d3cf530e8caa6335c29a29a803..cca06deeb90215c6e2998f633cbc8f83411278ee 100644 (file)
@@ -1,3 +1,23 @@
+2013-02-13  Arko Saha  <arko@motorola.com>
+
+        [Microdata] HTMLPropertiesCollection code cleanup
+        https://bugs.webkit.org/show_bug.cgi?id=109721
+
+        Reviewed by Ryosuke Niwa.
+
+        Removed forward declaration of DOMStringList class.
+        Removed unused findRefElements() method declaration.
+        Also Removed unused parameter Element* from updatePropertyCache() method.
+
+        No new test since no change in behavior.
+
+        * html/HTMLPropertiesCollection.cpp:
+        (WebCore::HTMLPropertiesCollection::updateNameCache):
+        * html/HTMLPropertiesCollection.h:
+        (WebCore):
+        (HTMLPropertiesCollection):
+        (WebCore::HTMLPropertiesCollection::updatePropertyCache):
+
 2013-02-13  Kondapally Kalyan  <kalyan.kondapally@intel.com>
 
         [WebGL][EFL][GTK][Qt]Add support for OES_vertex_array_object.
index ded54d26adadaf882c8bd8e2ccddf0fc6dc83eaf..dc91ed96da6026026520f4aca7239b846be96e5c 100644 (file)
@@ -35,7 +35,6 @@
 #include "HTMLPropertiesCollection.h"
 
 #include "DOMSettableTokenList.h"
-#include "DOMStringList.h"
 #include "HTMLElement.h"
 #include "HTMLNames.h"
 #include "Node.h"
@@ -122,7 +121,7 @@ void HTMLPropertiesCollection::updateNameCache() const
         for (HTMLElement* element = virtualItemAfter(refElement, 0); element; element = virtualItemAfter(refElement, element)) {
             DOMSettableTokenList* itemProperty = element->itemProp();
             for (unsigned propertyIndex = 0; propertyIndex < itemProperty->length(); ++propertyIndex)
-                updatePropertyCache(element, itemProperty->item(propertyIndex));
+                updatePropertyCache(itemProperty->item(propertyIndex));
         }
     }
 
index 2f1672b08ed462133de86fbd747597fb940e73d8..ae165d50765fe490d663c9c71b82b93c2879892d 100644 (file)
@@ -38,7 +38,6 @@
 
 namespace WebCore {
 
-class DOMStringList;
 class PropertyNodeList;
 
 class HTMLPropertiesCollection : public HTMLCollection {
@@ -61,14 +60,12 @@ public:
 private:
     HTMLPropertiesCollection(Node*);
 
-    Node* findRefElements(Node* previous) const;
-
     virtual Element* virtualItemAfter(unsigned& offsetInArray, Element*) const OVERRIDE;
     HTMLElement* virtualItemAfter(HTMLElement* base, Element* previous) const;
 
     void updateNameCache() const;
 
-    void updatePropertyCache(Element*, const AtomicString& propertyName) const
+    void updatePropertyCache(const AtomicString& propertyName) const
     {
         if (!m_propertyNames)
             m_propertyNames = DOMStringList::create();