[chromium] Disable incremental uploading in threaded compositing path

https://bugs.webkit.org/show_bug.cgi?id=72669

Patch by James Robinson <jamesr@chromium.org> on 2011-11-17
Reviewed by Kenneth Russell.

Since we don't currently support atomic incremental uploads, incremental uploads in the threaded path result in
very strange-looking texture popping as tiles come in on pages that require more than 16 tile uploads per frame.
This disables that logic (by setting the upload limit per frame to 99999) until we handle the incremental
updates in an atomic fashion.

* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::scheduledActionUpdateMoreResources):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100710 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
index 3890ae8b2f0b6704aef0d409167355e8fbf1f47e..c277a88c6104760d12a85b7b1960eb51053dd617 100644 (file)
--- a/Source/WebCore/ChangeLog
+++ b/Source/WebCore/ChangeLog
@@ -1,3 +1,18 @@
+2011-11-17  James Robinson  <jamesr@chromium.org>
+
+        [chromium] Disable incremental uploading in threaded compositing path
+        https://bugs.webkit.org/show_bug.cgi?id=72669
+
+        Reviewed by Kenneth Russell.
+
+        Since we don't currently support atomic incremental uploads, incremental uploads in the threaded path result in
+        very strange-looking texture popping as tiles come in on pages that require more than 16 tile uploads per frame.
+        This disables that logic (by setting the upload limit per frame to 99999) until we handle the incremental
+        updates in an atomic fashion.
+
+        * platform/graphics/chromium/cc/CCThreadProxy.cpp:
+        (WebCore::CCThreadProxy::scheduledActionUpdateMoreResources):
+
 2011-11-06  Nat Duca  <nduca@chromium.org>
 
         [chromium] Fix handling of setNeedsCommit and setNeedsAnimate in threaded mode

diff --git a/Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.cpp b/Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.cpp
index 5babce3d459f936ced5dfa58a01fc8fee3926428..eda718d304a540acb7ed73abdcb9a6dcacd3bc51 100644 (file)
--- a/Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.cpp
+++ b/Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.cpp
@@ -430,7 +430,7 @@ void CCThreadProxy::scheduledActionUpdateMoreResources()
 {
     TRACE_EVENT("CCThreadProxy::scheduledActionUpdateMoreResources", this, 0);
     ASSERT(m_currentTextureUpdaterOnImplThread);
-    static const int UpdatesPerFrame = 16;
+    static const int UpdatesPerFrame = 99999;
     m_currentTextureUpdaterOnImplThread->update(m_layerTreeHostImpl->context(), UpdatesPerFrame);
 }