[BlackBerry] Needs one-shot drawing synchronization flag should be set before renderi...
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 4 Feb 2013 17:38:58 +0000 (17:38 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 4 Feb 2013 17:38:58 +0000 (17:38 +0000)
https://bugs.webkit.org/show_bug.cgi?id=108760

Patch by Andrew Lo <anlo@rim.com> on 2013-02-04
Reviewed by Yong Li.
Internally reviewed by Arvid Nilsson.

Internal PR 286218.
When acquiring the backing store ownership in WebPagePrivate::resumeBackingStore
we need to set the needs one-shot drawing synchronization flag
before rendering, so that when the render is completed we
commit the root layer.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::resumeBackingStore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebKit/blackberry/Api/WebPage.cpp
Source/WebKit/blackberry/ChangeLog

index 1bf2f201d2eb23d5043b3f14919990f6e76a926c..0f08a16010483b5c65667c59ab04e176e8e7cde7 100644 (file)
@@ -3563,6 +3563,10 @@ void WebPagePrivate::resumeBackingStore()
         m_backingStore->d->resetTiles();
         m_backingStore->d->updateTiles(false /* updateVisible */, false /* immediate */);
 
+#if USE(ACCELERATED_COMPOSITING)
+        setNeedsOneShotDrawingSynchronization();
+#endif
+
         m_backingStore->d->renderAndBlitVisibleContentsImmediately();
     } else {
         if (m_backingStore->d->isOpenGLCompositing())
@@ -3570,11 +3574,10 @@ void WebPagePrivate::resumeBackingStore()
 
         // Rendering was disabled while we were hidden, so we need to update all tiles.
         m_backingStore->d->updateTiles(true /* updateVisible */, false /* immediate */);
-    }
-
 #if USE(ACCELERATED_COMPOSITING)
-    setNeedsOneShotDrawingSynchronization();
+        setNeedsOneShotDrawingSynchronization();
 #endif
+    }
 
     setShouldResetTilesWhenShown(false);
 }
index ee43b59fdfc51d66368cfc44b98270e60d218882..d5a116186f1ece56e5630261524f15145a3a9ed9 100644 (file)
@@ -1,3 +1,20 @@
+2013-02-04  Andrew Lo  <anlo@rim.com>
+
+        [BlackBerry] Needs one-shot drawing synchronization flag should be set before rendering when resuming the backing store
+        https://bugs.webkit.org/show_bug.cgi?id=108760
+
+        Reviewed by Yong Li.
+        Internally reviewed by Arvid Nilsson.
+
+        Internal PR 286218.
+        When acquiring the backing store ownership in WebPagePrivate::resumeBackingStore
+        we need to set the needs one-shot drawing synchronization flag
+        before rendering, so that when the render is completed we
+        commit the root layer.
+
+        * Api/WebPage.cpp:
+        (BlackBerry::WebKit::WebPagePrivate::resumeBackingStore):
+
 2013-02-03  KwangYong Choi  <ky0.choi@samsung.com>
 
         Fix build warning after r141473