2009-12-02 Eric Seidel <eric@webkit.org>
authoreric@webkit.org <eric@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 2 Dec 2009 09:43:14 +0000 (09:43 +0000)
committereric@webkit.org <eric@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 2 Dec 2009 09:43:14 +0000 (09:43 +0000)
        Reviewed by Adam Barth.

        build-queue is throwing exceptions and complaining about
        lack of --no-update on build-attachment.  Make it stop.

        * Scripts/modules/buildsteps.py:
        * Scripts/modules/commands/download.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebKitTools/ChangeLog
WebKitTools/Scripts/modules/buildsteps.py
WebKitTools/Scripts/modules/commands/download.py

index 629003711e3ac0b662184e6d9a386b09dded1adc..959b908229a961c32c445690b6c9d6d10341c33d 100644 (file)
@@ -1,3 +1,13 @@
+2009-12-02  Eric Seidel  <eric@webkit.org>
+
+        Reviewed by Adam Barth.
+
+        build-queue is throwing exceptions and complaining about
+        lack of --no-update on build-attachment.  Make it stop.
+
+        * Scripts/modules/buildsteps.py:
+        * Scripts/modules/commands/download.py:
+
 2009-12-02  Adam Barth  <abarth@webkit.org>
 
         Unreviewed "build" fix.  Forgot to declare my variables.  :(
index edde38c9413d4bf564bb08e4f10fd130141a87b2..d796b3afc0c63b703724f664cdc1a13e70bebe92 100644 (file)
@@ -43,6 +43,7 @@ class BuildSteps:
             make_option("--no-clean", action="store_false", dest="clean", default=True, help="Don't check if the working directory is clean before applying patches"),
         ]
 
+    # FIXME: These distinctions are bogus.  We need a better model for handling options.
     @staticmethod
     def build_options():
         return [
index 2a1347a39ceb65b9ad01cb5b4da318fbf3681be4..ecaadd0a1663c9ec39df8a9f7f3945dab8523c29 100644 (file)
@@ -266,7 +266,7 @@ class CheckStyle(AbstractPatchProcessingCommand):
         sequence.run_and_handle_errors()
 
 
-class BuildAttachmentSequence(LandingSequence):
+class BuildAttachmentSequence(ConditionalLandingSequence):
     def __init__(self, patch, options, tool):
         LandingSequence.__init__(self, patch, options, tool)
 
@@ -283,6 +283,7 @@ class BuildAttachment(AbstractPatchProcessingCommand):
     def __init__(self):
         options = BuildSteps.cleaning_options()
         options += BuildSteps.build_options()
+        options += BuildSteps.land_options()
         AbstractPatchProcessingCommand.__init__(self, "Apply and build patches from bugzilla", "ATTACHMENT_ID [ATTACHMENT_IDS]", options)
 
     def _fetch_list_of_patches_to_process(self, options, args, tool):