srflx and relay ICE candidates lack raddr (rel-addr) and rport (rel-port) attributes...
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 15 Dec 2017 02:14:04 +0000 (02:14 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 15 Dec 2017 02:14:04 +0000 (02:14 +0000)
https://bugs.webkit.org/show_bug.cgi?id=180842

Patch by Youenn Fablet <youenn@apple.com> on 2017-12-14
Reviewed by Jon Lee.

Manually tested since there is no way to gather reflexive or stun candidates in WebKit CI.

* Modules/mediastream/PeerConnectionBackend.cpp:
(WebCore::filterICECandidate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225955 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/Modules/mediastream/PeerConnectionBackend.cpp

index 6216034..1c04ec7 100644 (file)
@@ -1,3 +1,15 @@
+2017-12-14  Youenn Fablet  <youenn@apple.com>
+
+        srflx and relay ICE candidates lack raddr (rel-addr) and rport (rel-port) attributes if getUserMedia access has not been granted
+        https://bugs.webkit.org/show_bug.cgi?id=180842
+
+        Reviewed by Jon Lee.
+
+        Manually tested since there is no way to gather reflexive or stun candidates in WebKit CI.
+
+        * Modules/mediastream/PeerConnectionBackend.cpp:
+        (WebCore::filterICECandidate):
+
 2017-12-14  Commit Queue  <commit-queue@webkit.org>
 
         Unreviewed, rolling out r225878.
index 2ad84bd..4687e23 100644 (file)
@@ -336,7 +336,13 @@ static String filterICECandidate(String&& sdp)
             skipNextItem = false;
             return;
         }
-        if (item == "raddr" || item == "rport") {
+        if (item == "raddr") {
+            filteredSDP.append(" raddr 0.0.0.0");
+            skipNextItem = true;
+            return;
+        }
+        if (item == "rport") {
+            filteredSDP.append(" rport 0");
             skipNextItem = true;
             return;
         }