Reviewed by Alice

        Fixed my previous checkin, which was pruning the users entire icon db on startup everytime

        * loader/icon/IconDatabase.cpp:
        (WebCore::IconDatabase::retainIconForPageURL): Bind the PageURL to argument 1, as SQL bindings
          are indexed to 1, not 0

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16029 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index 75f32ea2471313f8ba2cd5948a964a09afa7b1a4..f9ee9a2faa058ca72630cc132a86f7273fecc301 100644 (file)
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,13 @@
+2006-08-24  Brady Eidson  <beidson@apple.com>
+
+        Reviewed by Alice
+
+        Fixed my previous checkin, which was pruning the users entire icon db on startup everytime
+
+        * loader/icon/IconDatabase.cpp:
+        (WebCore::IconDatabase::retainIconForPageURL): Bind the PageURL to argument 1, as SQL bindings
+          are indexed to 1, not 0
+
 2006-08-24  Geoffrey Garen  <ggaren@apple.com>
 
         Reviewed by Darin.

diff --git a/WebCore/loader/icon/IconDatabase.cpp b/WebCore/loader/icon/IconDatabase.cpp
index 9ee58dc0763880cfb3e07094a7a88cb4b3f64e52..71fc36992ca8838ad38c5372843d0c66027dfd35 100644 (file)
--- a/WebCore/loader/icon/IconDatabase.cpp
+++ b/WebCore/loader/icon/IconDatabase.cpp
@@ -371,7 +371,7 @@ void IconDatabase::retainIconForPageURL(const String& pageURL)
                 m_preparedPageRetainInsertStatement->prepare();
             }
             m_preparedPageRetainInsertStatement->reset();
-            m_preparedPageRetainInsertStatement->bindText16(0, pageURL);
+            m_preparedPageRetainInsertStatement->bindText16(1, pageURL);
             if (m_preparedPageRetainInsertStatement->step() != SQLITE_DONE)
                 LOG_ERROR("Failed to record icon retention in temporary table for IconURL %s", pageURL.ascii().data());
             return;