Reviewed by Darin.
removed recently-added PreferredType concept; we found a better way to do what
ths was accomplishing
* bridge/WindowFeatures.h:
(WebCore::WindowFeatures::WindowFeatures):
removed definition of PreferredType
* page/ContextMenuController.cpp:
(WebCore::openNewWindow):
removed use of PreferredType
WebKit/mac:
Reviewed by Darin.
removed recently-added PreferredType concept; we found a better way to do what
ths was accomplishing
* WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::createWindow):
removed use of PreferredType
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27754
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
+2007-11-13 John Sullivan <sullivan@apple.com>
+
+ Reviewed by Darin.
+
+ removed recently-added PreferredType concept; we found a better way to do what
+ ths was accomplishing
+
+ * bridge/WindowFeatures.h:
+ (WebCore::WindowFeatures::WindowFeatures):
+ removed definition of PreferredType
+
+ * page/ContextMenuController.cpp:
+ (WebCore::openNewWindow):
+ removed use of PreferredType
+
2007-11-12 Alexey Proskuryakov <ap@webkit.org>
Reviewed by Darin.
namespace WebCore {
struct WindowFeatures {
- typedef enum {
- PreferUnspecified,
- PreferNewWindow,
- PreferNewTab
- } PreferredType;
-
WindowFeatures()
: xSet(false), ySet(false), widthSet(false), heightSet(false),
menuBarVisible(true), statusBarVisible(true), toolBarVisible(true),
locationBarVisible(true), scrollbarsVisible(true), resizable(true),
- fullscreen(false), dialog(false), preferredType(PreferUnspecified)
+ fullscreen(false), dialog(false)
{}
float x;
bool fullscreen;
bool dialog;
- PreferredType preferredType;
};
} // namespace WebCore
{
if (Page* oldPage = frame->page()) {
WindowFeatures features;
- features.preferredType = WindowFeatures::PreferNewWindow;
if (Page* newPage = oldPage->chrome()->createWindow(frame,
FrameLoadRequest(ResourceRequest(urlToLoad, frame->loader()->outgoingReferrer())), features))
newPage->chrome()->show();
+2007-11-13 John Sullivan <sullivan@apple.com>
+
+ Reviewed by Darin.
+
+ removed recently-added PreferredType concept; we found a better way to do what
+ ths was accomplishing
+
+ * WebCoreSupport/WebChromeClient.mm:
+ (WebChromeClient::createWindow):
+ removed use of PreferredType
+
2007-11-13 John Sullivan <sullivan@apple.com>
Reviewed by Dan Bernstein.
if (height)
[dictFeatures setObject:height forKey:@"height"];
- switch (features.preferredType) {
- case WindowFeatures::PreferNewWindow:
- [dictFeatures setObject:@"window" forKey:@"preferredType"];
- break;
- case WindowFeatures::PreferNewTab:
- [dictFeatures setObject:@"tab" forKey:@"preferredType"];
- break;
- case WindowFeatures::PreferUnspecified:
- break;
- default:
- ASSERT_NOT_REACHED();
- }
-
newWebView = CallUIDelegate(m_webView, @selector(webView:createWebViewWithRequest:windowFeatures:), URLRequest, dictFeatures);
[dictFeatures release];