Reviewed by Darin.
- updated results, null is not round-tripped through the bindings
because of regressions the original change caused in other applications.
- added an echo for "undefined".
* plugins/bindings-test-expected.txt:
* plugins/bindings-test.html:
WebCore:
Reviewed by Darin.
<rdar://problem/
4651318> REGRESSION: can't drag library items to widget in Dashcode
<rdar://problem/
4701626> REGRESSION: Unit Converter widget doesn't work convert data in its fields
jsNull should not be returned as NSNull because existing applications do not
expect that return value. Return as nil for backwards compatibility.
* bindings/objc/WebScriptObject.mm:
(+[WebScriptObject _convertValueToObjcValue:originExecutionContext:executionContext:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16178
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
+2006-09-01 Timothy Hatcher <timothy@apple.com>
+
+ Reviewed by Darin.
+
+ - updated results, null is not round-tripped through the bindings
+ because of regressions the original change caused in other applications.
+ - added an echo for "undefined".
+
+ * plugins/bindings-test-expected.txt:
+ * plugins/bindings-test.html:
+
2006-09-01 Alexey Proskuryakov <ap@nypop.com>
Reviewed by Eric.
ALERT: string = string (same)
ALERT: 42 = 42 (same)
ALERT: number = number (same)
-ALERT: null = null (same)
-ALERT: object = object (same)
+ALERT: null = undefined (same)
+ALERT: object = undefined (different)
+ALERT: undefined = undefined (same)
+ALERT: undefined = undefined (same)
ALERT: one,two = one,two (same)
ALERT: object = object (same)
ALERT: String Hello == Hello
echoTest("hello");
echoTest(42);
echoTest(null);
+ echoTest(undefined);
echoTest(new Array("one", "two"));
// Test exceptions
+2006-09-01 Timothy Hatcher <timothy@apple.com>
+
+ Reviewed by Darin.
+
+ <rdar://problem/4651318> REGRESSION: can't drag library items to widget in Dashcode
+ <rdar://problem/4701626> REGRESSION: Unit Converter widget doesn't work convert data in its fields
+
+ jsNull should not be returned as NSNull because existing applications do not
+ expect that return value. Return as nil for backwards compatibility.
+
+ * bindings/objc/WebScriptObject.mm:
+ (+[WebScriptObject _convertValueToObjcValue:originExecutionContext:executionContext:]):
+
2006-09-01 Alexey Proskuryakov <ap@nypop.com>
Release build fix.
if (value->isUndefined())
return [WebUndefined undefined];
- if (value->isNull())
- return [NSNull null];
-
- // Other types (e.g., UnspecifiedType) converted to nil.
- // This should never happen.
+ // jsNull is not returned as NSNull because existing applications do not expect
+ // that return value. Return as nil for compatibility. <rdar://problem/4651318> <rdar://problem/4701626>
+ // Other types (e.g., UnspecifiedType) also return as nil.
return nil;
}