REGRESSION(r180333): Analysis tasks can't be associated with bugs
authorrniwa@webkit.org <rniwa@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 21 Feb 2015 00:35:18 +0000 (00:35 +0000)
committerrniwa@webkit.org <rniwa@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 21 Feb 2015 00:35:18 +0000 (00:35 +0000)
https://bugs.webkit.org/show_bug.cgi?id=141858

Reviewed by Andreas Kling.

Added back the erroneously removed table to associate bugs. Also moved "details-table-container" div outside
of the chart-details partial template as it needs to wrap associate bugs in analysis task pages.

* public/v2/chart-pane.css:
* public/v2/index.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@180466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Websites/perf.webkit.org/ChangeLog
Websites/perf.webkit.org/public/v2/chart-pane.css
Websites/perf.webkit.org/public/v2/index.html

index f23c4e87f045c0a81356e4f0ce256687664daba2..2305adf3722e4eb2f51465a6ffec0b75c1c9a0fd 100644 (file)
@@ -1,3 +1,16 @@
+2015-02-20  Ryosuke Niwa  <rniwa@webkit.org>
+
+        REGRESSION(r180333): Analysis tasks can't be associated with bugs
+        https://bugs.webkit.org/show_bug.cgi?id=141858
+
+        Reviewed by Andreas Kling.
+
+        Added back the erroneously removed table to associate bugs. Also moved "details-table-container" div outside
+        of the chart-details partial template as it needs to wrap associate bugs in analysis task pages.
+
+        * public/v2/chart-pane.css:
+        * public/v2/index.html:
+
 2015-02-20  Ryosuke Niwa  <rniwa@webkit.org>
 
         Selecting revisions for A/B testing is hard
index 4da24550dcbde3b28b83e9ef095c2059dcb13a07..e6d1f8627f5cd5bb38b0e4a1bf9d4728e540a18f 100755 (executable)
     height: 15rem;
 }
 
-.analysis-chart-pane .details {
-    overflow: scroll;
-}
-
 .analysis-chart-pane table {
     margin: 0.5rem;
 }
 .chart-pane .details-table,
 .chart-pane .commits-viewer {
     font-size: 0.8rem;
-    width: 100%;
+    width: auto;
     table-layout: fixed;
     border-collapse: collapse;
 }
index f330d1e7582dd7030d9548d1c4c0cf27c3909ba7..eb32ae2d42450399a20db701c4ec5eb2e2792ee5 100755 (executable)
                                 selection=overviewSelection}}
                         {{/if}}
                         </div>
-                        {{partial "chart-details"}}
+                        <div class="details-table-container">
+                            {{partial "chart-details"}}
+                        </div>
                     </div>
                 </div>
 
 
     <script type="text/x-handlebars" data-template-name="chart-details">
     {{#if details}}
-    <div class="details-table-container">
         <table class="details-table">
             <tbody class="bugs">
             {{#each details.bugTrackers}}
                 {{commits-viewer repository=repository revisionInfo=this caption=name}}
             {{/each}}
         </div>
-    </div>
     {{/if}}
     </script>
 
                         rangeRoute="analysisTask"}}
                 </div>
                 <div class="details">
-                    {{partial "chart-details"}}
+                    <div class="details-table-container">
+                        <table class="analysis-bugs">
+                            <tbody>
+                                {{#each bugTrackers}}
+                                    <tr>
+                                        <th>{{label}}</th>
+                                        <td>
+                                            <form {{action "associateBug" this editedBugNumber on="submit"}}>
+                                                {{input type=text value=editedBugNumber}}
+                                            </form>
+                                        </td>
+                                    </tr>
+                                {{/each}}
+                            </tbody>
+                        </table>
+                        {{partial "chart-details"}}
+                    </div>
                 </div>
             </section>
         {{/if}}