Remove assertion from revisionContentForIteration that is causing errors on the dashb...
authorjmarcell@apple.com <jmarcell@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 20 Jan 2016 06:20:03 +0000 (06:20 +0000)
committerjmarcell@apple.com <jmarcell@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 20 Jan 2016 06:20:03 +0000 (06:20 +0000)
https://bugs.webkit.org/show_bug.cgi?id=153262

Reviewed by Alexey Proskuryakov.

Occasionaly some buildbot iterations will not have their "got_revisions" property populated. In
such cases this revisionContentForIteration method does not have any content to return, thus the
assertion fails.

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
(BuildbotQueueView.prototype.revisionContentForIteration): Removed assertion that was causing errors.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@195342 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js
Tools/ChangeLog

index 248edab..23b9d07 100644 (file)
@@ -292,7 +292,6 @@ BuildbotQueueView.prototype = {
             fragment.appendChild(content);
             shouldAddPlusSign = true;
         }
-        console.assert(fragment.childNodes.length);
         return fragment;
     },
 
index 6a5c0e4..40744a6 100644 (file)
@@ -1,3 +1,17 @@
+2016-01-19  Jason Marcell  <jmarcell@apple.com>
+
+        Remove assertion from revisionContentForIteration that is causing errors on the dashboard.
+        https://bugs.webkit.org/show_bug.cgi?id=153262
+
+        Reviewed by Alexey Proskuryakov.
+
+        Occasionaly some buildbot iterations will not have their "got_revisions" property populated. In
+        such cases this revisionContentForIteration method does not have any content to return, thus the
+        assertion fails.
+
+        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
+        (BuildbotQueueView.prototype.revisionContentForIteration): Removed assertion that was causing errors.
+
 2016-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
 
         [GTK] Runtime critical warnings when loading a URL after a session restore