Reviewed by Tim H.
authorap <ap@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 4 Oct 2006 04:34:45 +0000 (04:34 +0000)
committerap <ap@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 4 Oct 2006 04:34:45 +0000 (04:34 +0000)
        http://bugs.webkit.org/show_bug.cgi?id=11130
        Convert "undefined" to AE missing value

WebCore:
        * bridge/mac/WebCoreFrameBridge.mm:
        (aeDescFromJSValue): return missing value for UndefinedType.

LayoutTests:
        * fast/AppleScript/001-expected.txt:
        * fast/AppleScript/array-expected.txt:
        Updated the results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/fast/AppleScript/001-expected.txt
LayoutTests/fast/AppleScript/array-expected.txt
WebCore/ChangeLog
WebCore/bridge/mac/WebCoreFrameBridge.mm

index 820775cee473f3a714c76ade870d0f7b9e14c174..66421e0c64713395e9b1a9e3bd1faddade6601f1 100644 (file)
@@ -1,3 +1,14 @@
+2006-10-03  Alexey Proskuryakov  <ap@nypop.com>
+
+        Reviewed by Tim H.
+
+        http://bugs.webkit.org/show_bug.cgi?id=11130
+        Convert "undefined" to AE missing value
+
+        * fast/AppleScript/001-expected.txt:
+        * fast/AppleScript/array-expected.txt:
+        Updated the results.
+
 2006-10-03  Justin Garcia  <justin.garcia@apple.com>
 
         Reviewed by harrison
index a2314931d0be6c37a675c2a083ba5a96c8a0d8b0..2945dc1c7627092b0c53dd124a9f2fa86697e477 100644 (file)
@@ -15,7 +15,7 @@ An automated test for basic AppleScript "do JavaScript" support. ('utxt')
 An automated test for basic AppleScript "do JavaScript" support. ('utxt')
 [object HTMLDocument] ('utxt')
 do JavaScript - converting to AppleScript types ('utxt')
-<> ('null')
+msng ('type')
 (null)
 [object Object] ('utxt')
 
index c45cfe33d263fd2e07053b34906e7b8d3ab51626..e3cd9d68b3fea61c699fef5ff9121ced5099f27a 100644 (file)
@@ -1,5 +1,5 @@
 (1, 2, three) ('list')
-(<>, <>, 2) ('list')
+(msng, msng, 2) ('list')
 (0, "0,") ('list')
 
 
index 6db96545ca0c838ca745a66a280f79a1f6a79eb9..8e8a86722a0ecf7b6ef2c669eeded905f90660ec 100644 (file)
@@ -1,3 +1,13 @@
+2006-10-03  Alexey Proskuryakov  <ap@nypop.com>
+
+        Reviewed by Tim H.
+
+        http://bugs.webkit.org/show_bug.cgi?id=11130
+        Convert "undefined" to AE missing value
+
+        * bridge/mac/WebCoreFrameBridge.mm:
+        (aeDescFromJSValue): return missing value for UndefinedType.
+
 2006-10-03  Dave Hyatt  <hyatt@apple.com>
 
         Scrolling work.  Eliminate convertTo/FromContainingWindow as cross-platform functions.  Add back in
index 2c02694431f7a5b09539d39bab7f56ea399c0746..4d8848017f35e34c45e06e3a7a93738debbb693f 100644 (file)
@@ -217,11 +217,13 @@ static NSAppleEventDescriptor* aeDescFromJSValue(ExecState* exec, JSValue* jsVal
             }
             break;
         }
+        case UndefinedType:
+            aeDesc = [NSAppleEventDescriptor descriptorWithTypeCode:cMissingValue];
+            break;
         default:
             LOG_ERROR("Unknown JavaScript type: %d", jsValue->type());
             // no break;
         case UnspecifiedType:
-        case UndefinedType:
         case NullType:
         case GetterSetterType:
             aeDesc = [NSAppleEventDescriptor nullDescriptor];