git://git.webkit.org / WebKit-https.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: e2cb543)
Directional single quotation marks are not rotated in vertical text
authormmaxfield@apple.com <mmaxfield@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 6 Dec 2014 05:14:12 +0000 (05:14 +0000)
committermmaxfield@apple.com <mmaxfield@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 6 Dec 2014 05:14:12 +0000 (05:14 +0000)
https://bugs.webkit.org/show_bug.cgi?id=138526

Source/WebCore:

Reviewed by Darin Adler.

In vertical text, directional single quotation marks are not rotated along with
the rest of the letters.

Test: fast/text/vertical-quotation-marks.html

* platform/graphics/FontGlyphs.cpp:
(WebCore::shouldIgnoreRotation):

LayoutTests:

Compare vertical and horizontal renderings.

Reviewed by Darin Adler.

* fast/text/vertical-quotation-marks-expected.html: Added.
* fast/text/vertical-quotation-marks.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog patch | blob | history
LayoutTests/fast/text/vertical-quotation-marks-expected.html [new file with mode: 0644] patch | blob
LayoutTests/fast/text/vertical-quotation-marks.html [new file with mode: 0644] patch | blob
Source/WebCore/ChangeLog patch | blob | history
Source/WebCore/platform/graphics/FontGlyphs.cpp patch | blob | history

diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
index 84042512875fc0b01f1ca613988f348fe84146a6..8cfe3e85155531ce4164a10293a121b7a9e84f8d 100644 (file)
--- a/LayoutTests/ChangeLog
+++ b/LayoutTests/ChangeLog
@@ -1,3 +1,15 @@
+2014-12-05  Myles C. Maxfield  <mmaxfield@apple.com>
+
+        Directional single quotation marks are not rotated in vertical text
+        https://bugs.webkit.org/show_bug.cgi?id=138526
+
+        Compare vertical and horizontal renderings.
+
+        Reviewed by Darin Adler.
+
+        * fast/text/vertical-quotation-marks-expected.html: Added.
+        * fast/text/vertical-quotation-marks.html: Added.
+
 2014-12-05  Dhi Aurrahman  <diorahman@rockybars.com>
 
         Implement parser for :lang pseudo class selector arguments that contain wildcard '*' subtags
diff --git a/LayoutTests/fast/text/vertical-quotation-marks-expected.html b/LayoutTests/fast/text/vertical-quotation-marks-expected.html
new file mode 100644 (file)
index 0000000..84be55d
--- /dev/null
+++ b/LayoutTests/fast/text/vertical-quotation-marks-expected.html
@@ -0,0 +1,10 @@
+<!DOCTYPE html>
+<html>
+<head>
+</head>
+<body>
+<div style="line-height: 50px; -webkit-transform-origin: left bottom; -webkit-transform: rotate(90deg) translateX(-50px); display: inline-block">
+What&#x2019;s going&#x2018; on?
+</div>
+</body>
+</html
diff --git a/LayoutTests/fast/text/vertical-quotation-marks.html b/LayoutTests/fast/text/vertical-quotation-marks.html
new file mode 100644 (file)
index 0000000..0366350
--- /dev/null
+++ b/LayoutTests/fast/text/vertical-quotation-marks.html
@@ -0,0 +1,10 @@
+<!DOCTYPE html>
+<html>
+<head>
+</head>
+<body>
+<div style="line-height: 50px; -webkit-writing-mode:vertical-rl;">
+What&#x2019;s going&#x2018; on?
+</div>
+</body>
+</html
diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
index c3a66309c48400579a3b5def29e93b942bddd244..d87a446ad13e18dcb1dd48996fd41279e2744926 100644 (file)
--- a/Source/WebCore/ChangeLog
+++ b/Source/WebCore/ChangeLog
@@ -1,3 +1,18 @@
+2014-12-05  Myles C. Maxfield  <mmaxfield@apple.com>
+
+        Directional single quotation marks are not rotated in vertical text
+        https://bugs.webkit.org/show_bug.cgi?id=138526
+
+        Reviewed by Darin Adler.
+
+        In vertical text, directional single quotation marks are not rotated along with
+        the rest of the letters.
+
+        Test: fast/text/vertical-quotation-marks.html
+
+        * platform/graphics/FontGlyphs.cpp:
+        (WebCore::shouldIgnoreRotation):
+
 2014-12-05  Dhi Aurrahman  <diorahman@rockybars.com>
 
         Implement parser for :lang pseudo class selector arguments that contain wildcard '*' subtags
diff --git a/Source/WebCore/platform/graphics/FontGlyphs.cpp b/Source/WebCore/platform/graphics/FontGlyphs.cpp
index 3330b23e06ffe56d45588fa6c9afd9261f1e4828..9321635fcdaff0e66cf4b1422c58d8e7d7dbc342 100644 (file)
--- a/Source/WebCore/platform/graphics/FontGlyphs.cpp
+++ b/Source/WebCore/platform/graphics/FontGlyphs.cpp
@@ -145,8 +145,7 @@ static bool shouldIgnoreRotation(UChar32 character)
     if (isInRange(character, 0x01100, 0x011FF) || isInRange(character, 0x01401, 0x0167F) || isInRange(character, 0x01800, 0x018FF))
         return true;
 
-    if (character == 0x02016 || character == 0x02018 || character == 0x02019 || character == 0x02020 || character == 0x02021
-        || character == 0x2030 || character == 0x02031)
+    if (character == 0x02016 || character == 0x02020 || character == 0x02021 || character == 0x2030 || character == 0x02031)
         return true;
 
     if (isInRange(character, 0x0203B, 0x0203D) || character == 0x02042 || character == 0x02044 || character == 0x02047
Mirror of the WebKit open source project from svn.webkit.org.