Reviewed by Darin and Oliver.

        <rdar://problem/5422410>
        http://bugs.webkit.org/show_bug.cgi?id=15019
        REGRESSION (r25124-r25140): New posts and hot topics won't show at mobile01.com

        Remove the call to checkCallImplicitClose(). Calling it in loadPlugin is bad for two reasons:

        1. It could cause onload to be dispatched even when the page has subresources that are still
        loading, such as images.

        2. Now that loadPlugin is called during layout, it could cause onload to be dispatched during
        layout, which can execute javascript and do pretty much anything while the render tree is in an
        inconsistent state.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::loadPlugin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25194 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index cee002e00e62d9ad2f197e3713418f64abdece9b..a4b59357289f91c533d528ecf6fd45f52a5fb41e 100644 (file)
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,23 @@
+2007-08-22  Anders Carlsson  <andersca@apple.com>
+
+        Reviewed by Darin and Oliver.
+
+        <rdar://problem/5422410>
+        http://bugs.webkit.org/show_bug.cgi?id=15019
+        REGRESSION (r25124-r25140): New posts and hot topics won't show at mobile01.com
+
+        Remove the call to checkCallImplicitClose(). Calling it in loadPlugin is bad for two reasons:
+        
+        1. It could cause onload to be dispatched even when the page has subresources that are still
+        loading, such as images.
+        
+        2. Now that loadPlugin is called during layout, it could cause onload to be dispatched during
+        layout, which can execute javascript and do pretty much anything while the render tree is in an
+        inconsistent state.
+        
+        * loader/FrameLoader.cpp:
+        (WebCore::FrameLoader::loadPlugin):
+
 2007-08-22  Anders Carlsson  <andersca@apple.com>
 
         Reviewed by Adam.

diff --git a/WebCore/loader/FrameLoader.cpp b/WebCore/loader/FrameLoader.cpp
index b61cd78f921c1b6153f32cff9edc9fff77f6e277..b32217f02d0acb360b3e0e5e9d6eab6bc49333c2 100644 (file)
--- a/WebCore/loader/FrameLoader.cpp
+++ b/WebCore/loader/FrameLoader.cpp
@@ -1537,7 +1537,6 @@ bool FrameLoader::loadPlugin(RenderPart* renderer, const KURL& url, const String
         }
     }
 
-    checkCallImplicitClose();
     return widget != 0;
 }