https://bugs.webkit.org/show_bug.cgi?id=79237
Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2012-02-24
Reviewed by Andreas Kling.
Source/WebKit:
Adds the main directory of WebKit's source to find headers of JavaScriptCore.
* PlatformEfl.cmake:
Source/WebKit/efl:
Adds missing implementation setValueForUser and setAutofilled to EFL's DumpRenderTreeSupport.
* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::setValueForUser):
(DumpRenderTreeSupportEfl::setAutofilled):
* WebCoreSupport/DumpRenderTreeSupportEfl.h:
Tools:
Adds missing implementation setValueForUser and setAutofilled to EFL's LayoutTestController.
Those implementations are related with input fields and allow to pass following tests:
fast/forms/onchange-setvalueforuser.html
fast/forms/input-autofilled.html
fast/forms/reset-autofilled.html
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::setValueForUser):
(LayoutTestController::setAutofilled):
LayoutTests:
Adds missing implementation setValueForUser and setAutofilled to EFL's LayoutTestController.
Those implementations are related with input fields and allow to pass following tests:
fast/forms/onchange-setvalueforuser.html
fast/forms/input-autofilled.html
fast/forms/reset-autofilled.html
* platform/efl/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108806
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
+2012-02-24 Grzegorz Czajkowski <g.czajkowski@samsung.com>
+
+ [EFL][DRT] Implement setValueForUser and setAutofilled.
+ https://bugs.webkit.org/show_bug.cgi?id=79237
+
+ Reviewed by Andreas Kling.
+
+ Adds missing implementation setValueForUser and setAutofilled to EFL's LayoutTestController.
+ Those implementations are related with input fields and allow to pass following tests:
+ fast/forms/onchange-setvalueforuser.html
+ fast/forms/input-autofilled.html
+ fast/forms/reset-autofilled.html
+
+ * platform/efl/Skipped:
+
2012-02-24 Csaba Osztrogonác <ossy@webkit.org>
[Qt] Unreviewed gardening, skip new failing tests.
svg/custom/manually-parsed-svg-disallowed-in-dashboard.html
svg/custom/svg-disallowed-in-dashboard-object.html
-# EFL's LayoutTestController does not implement setValueForUser
-fast/forms/onchange-setvalueforuser.html
-
# EFL's LayoutTestController does not implement setViewModeMediaFeature
fast/media/media-query-list-02.html
fast/media/media-query-list-03.html
# EFL's LayoutTestController does not implement setAuthorAndUserStylesEnabled
fast/css/disabled-author-styles.html
-# EFL's LayoutTestController does not implement setAutofilled
-fast/forms/input-autofilled.html
-fast/forms/reset-autofilled.html
-
# EFL's LayoutTestController does not implement disableImageLoading
http/tests/misc/favicon-loads-with-icon-loading-override.html
http/tests/misc/favicon-loads-with-images-disabled.html
+2012-02-24 Grzegorz Czajkowski <g.czajkowski@samsung.com>
+
+ [EFL][DRT] Implement setValueForUser and setAutofilled.
+ https://bugs.webkit.org/show_bug.cgi?id=79237
+
+ Reviewed by Andreas Kling.
+
+ Adds the main directory of WebKit's source to find headers of JavaScriptCore.
+
+ * PlatformEfl.cmake:
+
2012-02-23 Patrick Gansterer <paroga@webkit.org>
[CMake] Add WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS macro
)
LIST(APPEND WebKit_INCLUDE_DIRECTORIES
+ "${CMAKE_SOURCE_DIR}/Source"
"${WEBKIT_DIR}/efl/ewk"
"${WEBKIT_DIR}/efl/WebCoreSupport"
+ "${JAVASCRIPTCORE_DIR}/ForwardingHeaders"
"${JAVASCRIPTCORE_DIR}/wtf/gobject"
"${WEBCORE_DIR}/platform/efl"
"${WEBCORE_DIR}/platform/graphics/cairo"
+2012-02-24 Grzegorz Czajkowski <g.czajkowski@samsung.com>
+
+ [EFL][DRT] Implement setValueForUser and setAutofilled.
+ https://bugs.webkit.org/show_bug.cgi?id=79237
+
+ Reviewed by Andreas Kling.
+
+ Adds missing implementation setValueForUser and setAutofilled to EFL's DumpRenderTreeSupport.
+
+ * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
+ (DumpRenderTreeSupportEfl::setValueForUser):
+ (DumpRenderTreeSupportEfl::setAutofilled):
+ * WebCoreSupport/DumpRenderTreeSupportEfl.h:
+
2012-02-24 Shinya Kawanaka <shinyak@chromium.org>
SpellCheckRequest needs to know the context where the spellcheck happened.
#include <FindOptions.h>
#include <FloatSize.h>
#include <FrameView.h>
+#include <HTMLInputElement.h>
#include <IntRect.h>
+#include <JSElement.h>
#include <PrintContext.h>
#include <RenderTreeAsText.h>
#include <Settings.h>
#include <bindings/js/GCController.h>
#include <history/HistoryItem.h>
#include <workers/WorkerThread.h>
+#include <wtf/OwnArrayPtr.h>
#include <wtf/text/AtomicString.h>
unsigned DumpRenderTreeSupportEfl::activeAnimationsCount(const Evas_Object* ewkFrame)
animationController->suspendAnimations();
}
+void DumpRenderTreeSupportEfl::setValueForUser(JSContextRef context, JSValueRef nodeObject, JSStringRef value)
+{
+ JSC::ExecState* exec = toJS(context);
+ WebCore::Element* element = WebCore::toElement(toJS(exec, nodeObject));
+ if (!element)
+ return;
+ WebCore::HTMLInputElement* inputElement = element->toInputElement();
+ if (!inputElement)
+ return;
+
+ size_t bufferSize = JSStringGetMaximumUTF8CStringSize(value);
+ OwnArrayPtr<char> valueBuffer = adoptArrayPtr(new char[bufferSize]);
+ JSStringGetUTF8CString(value, valueBuffer.get(), bufferSize);
+ inputElement->setValueForUser(String::fromUTF8(valueBuffer.get()));
+}
+
+void DumpRenderTreeSupportEfl::setAutofilled(JSContextRef context, JSValueRef nodeObject, bool autofilled)
+{
+ JSC::ExecState* exec = toJS(context);
+ WebCore::Element* element = WebCore::toElement(toJS(exec, nodeObject));
+ if (!element)
+ return;
+ WebCore::HTMLInputElement* inputElement = element->toInputElement();
+ if (!inputElement)
+ return;
+
+ inputElement->setAutofilled(autofilled);
+}
+
bool DumpRenderTreeSupportEfl::findString(const Evas_Object* ewkView, const char* text, WebCore::FindOptions options)
{
WebCore::Page* page = EWKPrivate::corePage(ewkView);
#include <Eina.h>
#include <FindOptions.h>
#include <IntRect.h>
+#include <JavaScriptCore/APICast.h>
+#include <JavaScriptCore/JSStringRef.h>
#include <wtf/Vector.h>
#include <wtf/text/WTFString.h>
static WebCore::IntRect selectionRectangle(const Evas_Object* ewkFrame);
static String suitableDRTFrameName(const Evas_Object* ewkFrame);
static void suspendAnimations(Evas_Object* ewkFrame);
+ static void setValueForUser(JSContextRef, JSValueRef nodeObject, JSStringRef value);
+ static void setAutofilled(JSContextRef, JSValueRef nodeObject, bool autofilled);
static bool findString(const Evas_Object* ewkView, const char* text, WebCore::FindOptions);
+2012-02-24 Grzegorz Czajkowski <g.czajkowski@samsung.com>
+
+ [EFL][DRT] Implement setValueForUser and setAutofilled.
+ https://bugs.webkit.org/show_bug.cgi?id=79237
+
+ Reviewed by Andreas Kling.
+
+ Adds missing implementation setValueForUser and setAutofilled to EFL's LayoutTestController.
+ Those implementations are related with input fields and allow to pass following tests:
+ fast/forms/onchange-setvalueforuser.html
+ fast/forms/input-autofilled.html
+ fast/forms/reset-autofilled.html
+
+ * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
+ (LayoutTestController::setValueForUser):
+ (LayoutTestController::setAutofilled):
+
2012-02-24 Zoltan Horvath <zoltan@webkit.org>
[Qt] Allow to use WebCore imagedecoders
setUserStyleSheetEnabled(true);
}
-void LayoutTestController::setValueForUser(JSContextRef, JSValueRef, JSStringRef)
+void LayoutTestController::setValueForUser(JSContextRef context, JSValueRef nodeObject, JSStringRef value)
{
- notImplemented();
+ DumpRenderTreeSupportEfl::setValueForUser(context, nodeObject, value);
}
void LayoutTestController::setViewModeMediaFeature(JSStringRef)
notImplemented();
}
-void LayoutTestController::setAutofilled(JSContextRef, JSValueRef, bool)
+void LayoutTestController::setAutofilled(JSContextRef context, JSValueRef nodeObject, bool autofilled)
{
- notImplemented();
+ DumpRenderTreeSupportEfl::setAutofilled(context, nodeObject, autofilled);
}
void LayoutTestController::disableImageLoading()